From patchwork Fri Sep 30 16:20:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101720 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp380846qgf; Fri, 30 Sep 2016 09:21:54 -0700 (PDT) X-Received: by 10.66.10.132 with SMTP id i4mr13116946pab.101.1475252514794; Fri, 30 Sep 2016 09:21:54 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z2si20697547pfb.226.2016.09.30.09.21.54; Fri, 30 Sep 2016 09:21:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934181AbcI3QVw (ORCPT + 27 others); Fri, 30 Sep 2016 12:21:52 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:64222 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934014AbcI3QVv (ORCPT ); Fri, 30 Sep 2016 12:21:51 -0400 Received: from wuerfel.lan. ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue103) with ESMTPA (Nemesis) id 0MCfv0-1bghAw2fli-009PIH; Fri, 30 Sep 2016 18:21:36 +0200 From: Arnd Bergmann To: Alex Deucher , =?utf-8?q?Christian_K=C3=B6n?= =?utf-8?q?ig?= Cc: Arnd Bergmann , David Airlie , Jammy Zhou , Rex Zhu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/amdgpu: enable powerplay unconditionally Date: Fri, 30 Sep 2016 18:20:56 +0200 Message-Id: <20160930162134.158641-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:+tX5ZwVqYu/bF58ydD2Ii+ypvsqBWK9IB+4lJG8TK5sJ6XC5fYW BL34Fm1gkjZW1UOah2xQea1JR/J//bpNHXClOntdCN5Owo4KLgxrPT28S0+cd81Bv2qzri1 7GDQMOmhvABscRiBvTPE3iLLY8qzcLDMdUFZ5hhayIQPiqwRup7huS2tusS2dfFm3nLtVa0 3a+qpw6//28bSsWaYqBww== X-UI-Out-Filterresults: notjunk:1; V01:K0:3qjzHjJLX6s=:np8uo1MM9nZxlNJ9Y2k12i 81PLHK/KKSRMnqxJXHXdyumYOJFDpsjbJ9aNI9itJfhqhKWIe1J7VNZ95oY77QGYw40ZuAQt0 5YxLml5Bo6485rMxiyLYDQoWR8QnkjtZVVHykW1dWHg7R9B6suy+PLs8vVxXUXGSykqbyBN77 3XWW1qF4lthH1thiYoAka21n4Ablk6C8LDA9O2k/Ht/4N1pliBDdgo0KxgjqePOYXRPnwWxt8 b129TCIIF9L47/OPNGYIWBhBAd03HqwPOaOdoXnRoqa6d4I8TBAF73qd0mfOPgtF9j0ymi38k chz5AzhSwVj1a5fbchjWuOB+x65Hmp8UGl93rQ45W7+UjEOzDzPpG0qYfLEVbdfRJarvDIRQd 0ovbgfMzHzIoPFhiHLZbfCTmkyI+A0V8Tieh46hcJqMEYw8fR/+ZHvsLGeeeVz5aqXsR3EMO0 GqB6Rs8JsLjKcs+16dfBmHpj5HfHj/DpnXlPL+B9IlkEbB83ThZX3kw112En0HtmC2CtGUdaD 8QYjtf9wKHEXABxAybNU5/kjGYlRv/Nf1BThvZDaissnCdpkrw/2MGFII0FBLCRSNtIArITQf gHTh9qYZWjn2MKWbqzbl2zC/lFl3T11g4T2XmtHzQOjPyzuzHv6ZTmic47NgYeKel/P88bsK5 1fyzJVpOiOPw5ZfBxJeShbGYUYwvcFKH4UOVJJHZtWsOuaA5G1vwXVkeMMezn4LJmHPI= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Using the newly exported amd_set_clockgating_by_smu function in the main amdgpu driver means that we can no longer build the driver without also enabling the powerplay component, otherwise we get this link error: ERROR: "amd_set_clockgating_by_smu" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! The easiest way to avoid this error is to always enable the Kconfig symbol when the amdgpu driver is enabled. Fixes: a8ca34136453 ("drm/amdgpu: set gfx clock gating for tonga/polaris.") Fixes: 1bb08f91b0f6 ("drm/amdgpu: set system clock gating for tonga/polaris.") Signed-off-by: Arnd Bergmann --- It's quite likely that there is a better way to do this, as the separation of the drivers is intentional. If my patch isn't acceptable, please come up with a different solution. --- drivers/gpu/drm/amd/powerplay/Kconfig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.9.0 diff --git a/drivers/gpu/drm/amd/powerplay/Kconfig b/drivers/gpu/drm/amd/powerplay/Kconfig index af380335b425..6d4f155a0453 100644 --- a/drivers/gpu/drm/amd/powerplay/Kconfig +++ b/drivers/gpu/drm/amd/powerplay/Kconfig @@ -1,6 +1,4 @@ config DRM_AMD_POWERPLAY - bool "Enable AMD powerplay component" - depends on DRM_AMDGPU - default n + def_bool DRM_AMDGPU help select this option will enable AMD powerplay component.