From patchwork Fri Nov 18 16:36:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101488 Delivered-To: patch@linaro.org Received: by 10.182.1.168 with SMTP id 8csp179169obn; Fri, 18 Nov 2016 08:37:27 -0800 (PST) X-Received: by 10.129.196.74 with SMTP id s10mr597800ywj.150.1479487047019; Fri, 18 Nov 2016 08:37:27 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q67si1868201ywe.246.2016.11.18.08.37.26; Fri, 18 Nov 2016 08:37:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753513AbcKRQhX (ORCPT + 26 others); Fri, 18 Nov 2016 11:37:23 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:52426 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752247AbcKRQhU (ORCPT ); Fri, 18 Nov 2016 11:37:20 -0500 Received: from wuerfel.lan ([78.43.21.235]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id 0MdLhj-1cOcMB37wp-00IW0D; Fri, 18 Nov 2016 17:37:08 +0100 From: Arnd Bergmann To: Kishon Vijay Abraham I Cc: Arnd Bergmann , Felipe Balbi , Guenter Roeck , Frank Wang , Shawn Lin , linux-kernel@vger.kernel.org Subject: [PATCH] phy: rockchip-inno-usb2: add extcon dependency Date: Fri, 18 Nov 2016 17:36:26 +0100 Message-Id: <20161118163704.1236495-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:a1X1QN/JH/gx7nlMDnupDOcvmG7EGARiWm3V068kGfp9WU3a/0k dQ+uXNaan9NbVDWZnkAwGjZ6wKSMKHe38eSdub46EMg1Pby8fVa7ERcjibw8RWjpiGPSuEI occ/JXi2ztvQ9k+bPQ+HOVtBSW/NsHIxBT+DyeJGLWAlHkBbs/RuDxr+s+v+vSZrnVZNuYe zE3njw4kyYZV2BSZr5OgA== X-UI-Out-Filterresults: notjunk:1; V01:K0:clN7oDIjz8k=:dxjUk+HdstR9iw3FkifCDD edyrknbHeAKjRGjLJqIFLMwtUUl6+5OWgcU2ProewwwLEpM5lXcop6YlwYwbZbQ99kw4QSUKJ 5Jj+EQAee4TU11dR/W9x8bUjG++xYT2+hRqV9jCNvpM76VWpXlI1vZM+CVUDbMtofuZiXzd1X +XwIcHg/X24SbYZpQqxuL/DpxNabBJ8GPFwOSnB2ki/2dU965hqgH4X2a1KQtBHgu7jUG5OIX yYrymjzxz/8CP1ljo4M2ir6MDG8rDwYKkM1CUhePxY6kZ7/2nyml+cvDiVjpvPltxV3i57xtf MwObNtk15bbg1JvoodVI1kg4pcwh4087M1UdgGQAZZ86CriO2rCv+0BwQQtbOIIUutGd4CAtU S4Cr8gIJP0Yrjp5NGMGQvU7I4f2ptJ4X2wEHGAbW2vPbdkQB6J8i2jBnAywDIQCFakf2N025y J9bKGgaw7cHNjrahmgMs/YGaM5bkMxL5ARFyCw3UAxmILffbstpydBSxA59GIcrXfcVqXUSsV aeSps+XOjZdMxAf1k2Ux1/dfUPpvahXqKBzyRNch2ba6jcnrfXj3VVXepzYs3PkeS2WYJfCpE JwdTqFVu70Kg+hSXb+WMcBmLaE5f1BJmx32IC4LGnoyU40ntIBsLSOx7WwrE4AE/Gbl9nWuua 872nIExyrINEmGIwEYIIUKp9iB4R+Yc54e944MElgNVo/7hEQJLrZMaGu1F/1zuZrTOk= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If extcon is a loadable module and rockchip-inno-usb2 is built-in, we get a link failure: drivers/phy/phy-rockchip-inno-usb2.o: In function `rockchip_usb2phy_probe': phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x1ec): undefined reference to `extcon_get_edev_by_phandle' phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x25c): undefined reference to `devm_extcon_dev_allocate' phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x2a8): undefined reference to `devm_extcon_dev_register' phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0xa28): undefined reference to `extcon_register_notifier' Adding a hard dependency avoids the problem. Alternatively we could use "depends on EXTCON || !EXTCON" to allow building with extcon disabled completely, but the other PHY drivers with extcon support also just have a dependency, so this is more consistent. Fixes: 0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399") Signed-off-by: Arnd Bergmann --- drivers/phy/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 53cab9f3323b..b135ff1ab12d 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -366,6 +366,7 @@ config PHY_ROCKCHIP_INNO_USB2 depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF depends on COMMON_CLK depends on USB_SUPPORT + depends on EXTCON select GENERIC_PHY select USB_COMMON help