From patchwork Wed Jun 28 09:18:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fathi Boudra X-Patchwork-Id: 106501 Delivered-To: patch@linaro.org Received: by 10.182.135.102 with SMTP id pr6csp3322806obb; Wed, 28 Jun 2017 02:18:45 -0700 (PDT) X-Received: by 10.98.236.67 with SMTP id k64mr9593406pfh.236.1498641524896; Wed, 28 Jun 2017 02:18:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1498641524; cv=none; d=google.com; s=arc-20160816; b=H/NMJNRHYbp+ZqLdNnTnvYZR9sF0pul2wzO2HXXqOvUunYt1nkjeUl9qOykPLVe2Yb KNH0C8a5TUCN4HyXq6Tet1/qmAd99P8shxKyIQhQCswsQc+Fcf5WIbQJOY6hzzPq2SBf epjpR/T3lOpuC3tDEt/OkWDMTGA4u1U8wDws4D4jVK+dqHQfe6zMqWCiY9FLFa9Qw6Ug AcuTQF5kNNT+c0LOktf58oPpsDkiyYMH+/A7/4kbVsz8qMPdVXXK/Q+1i+ppyEKXBiDc vZqUo7s03RzUXpbVsLc/JWPwjGyH7UHcnqd6yB8cLmOtQcvOko33lbb7z+a/VSJ3WhvY E7qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=wQDoTiM8S2DkeXjbQQyEbs3b5k6900JdHYLRTipUjCc=; b=B2oLnbQ/1hA/JqoJnqX3PHsX7ISHKyXl+8hQ/SvszqEx/Q1BcRhN65X68rfXtx8lfd bYEzC/bIzMKrPj0E1hNFUw5XxXYMVp3dV/Picg2OyP5ETtCtv+EmakKYCFGxFK6VyExS 1lJSelH4988TO0pSzryfMNCjtBV5dEDu59CPi2tHeLB1BoAqf9pwi7HnW4miKEo+hD1E MR++KQcv6FLubclqLy3iIl/8bZE4J/YPB2w6beaum3hLAPgrzms4nUwANgVxzT2R9Lq4 xlYukwXN3YUfDkJRhz2FeorEmXZlEQjIofHwAxa2qCrx/2LP/UlKR6lZWfF0wrNuV2VS ZJOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.b=iNF7UiOh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z2si1159550pge.55.2017.06.28.02.18.44; Wed, 28 Jun 2017 02:18:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.b=iNF7UiOh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751888AbdF1JSW (ORCPT + 25 others); Wed, 28 Jun 2017 05:18:22 -0400 Received: from mail-lf0-f41.google.com ([209.85.215.41]:33189 "EHLO mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751520AbdF1JSO (ORCPT ); Wed, 28 Jun 2017 05:18:14 -0400 Received: by mail-lf0-f41.google.com with SMTP id m77so31252627lfe.0 for ; Wed, 28 Jun 2017 02:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=wQDoTiM8S2DkeXjbQQyEbs3b5k6900JdHYLRTipUjCc=; b=iNF7UiOhzaNS6porGUtd36SugVLO8g5Grv8o6w8MSmIBZF1Oxxs88iTXONdYnrVPx0 onswOnGLRGXh55GCDoiEkhWKRc7N849bwAjyWSR3qu5g9slpwORfHZLS64NRps47D9ZC dTjjcLJ6nktdLkWD06PbM6CtLvo8VLrRAXYv0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=wQDoTiM8S2DkeXjbQQyEbs3b5k6900JdHYLRTipUjCc=; b=FdpwTjmKRIT/LxGmXDsjPPuuSEFLwjP9C/7Sd2JT8pryr7ZOqeeinhpbh+PPTFZOkg /6s3AzDmgUKzCGKXBWj6kyJf/1M8StmJhebSYFtXvOxWp/vmYmRGxmYR0kSqUdV5TUHX sfdq6177XxEPBpMCpVd+zUBYliWM6/1HuA3gncexi0jW/WzL6FKwQoaFM2imuW7GN6Lf 3dkBsn2NmtaTCkklXrdx4TE7A97gJu73e7Ba7CXLK0wKWSDiH+T55ZtNXMOCLZlvLOJz bU87pBBV8HQOTE9/IcXY9NSFHlSIM1V78tKyyWk2to12L9OaCsCd4HYTZVQlM8pAypVn 5s0A== X-Gm-Message-State: AKS2vOys4AE1HszvmickCUFS5kWEgWWnWShKPXisg/l2ulupbIAmI8Aa XLqGmT9JWR5U0igzlZUdSA== X-Received: by 10.25.210.133 with SMTP id j127mr3142559lfg.21.1498641493136; Wed, 28 Jun 2017 02:18:13 -0700 (PDT) Received: from localhost.localdomain (a91-156-68-101.elisa-laajakaista.fi. [91.156.68.101]) by smtp.gmail.com with ESMTPSA id i13sm346424ljb.55.2017.06.28.02.18.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 28 Jun 2017 02:18:12 -0700 (PDT) From: Fathi Boudra To: linux-kselftest@vger.kernel.org, Shuah Khan Cc: linux-kernel@vger.kernel.org, John Stultz , Denys Dmytriyenko , Fathi Boudra Subject: [PATCH 1/1] selftests: timers: use LDLIBS instead of LDFLAGS to link against libpthread Date: Wed, 28 Jun 2017 12:18:10 +0300 Message-Id: <20170628091810.30484-1-fathi.boudra@linaro.org> X-Mailer: git-send-email 2.13.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org timers test fails to build due to undefined reference: aarch64-linaro-linux-gcc --sysroot=/build/tmp-rpb-glibc/sysroots/hikey -O2 -pipe -g -feliminate-unused-debug-types -O3 -Wl,-no-as-needed -Wall -DKTEST -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -lrt -lpthread posix_timers.c -o /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/timers/posix_timers /tmp/cc1FTZzT.o: In function `check_timer_create': /usr/src/debug/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/timers/posix_timers.c:157: undefined reference to `timer_create' /usr/src/debug/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/timers/posix_timers.c:170: undefined reference to `timer_settime' collect2: error: ld returned 1 exit status Use LDLIBS instead of LDFLAGS to properly link against libpthread and fix this build issue. Signed-off-by: Denys Dmytriyenko Signed-off-by: Fathi Boudra --- tools/testing/selftests/timers/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.13.0 diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile index 5fa1d7e9a915..f48d7ca9d9b1 100644 --- a/tools/testing/selftests/timers/Makefile +++ b/tools/testing/selftests/timers/Makefile @@ -1,6 +1,6 @@ BUILD_FLAGS = -DKTEST CFLAGS += -O3 -Wl,-no-as-needed -Wall $(BUILD_FLAGS) -LDFLAGS += -lrt -lpthread +LDLIBS += -lrt -lpthread # these are all "safe" tests that don't modify # system time or require escalated privileges