| Message ID | 20170717095307.15986-3-quentin.schulz@free-electrons.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] Input: axp20x-pek: add support for AXP221 PEK | expand |
On Tue, 18 Jul 2017, Quentin Schulz wrote: > Hi Lee, > > On 18/07/2017 09:19, Lee Jones wrote: > > On Mon, 17 Jul 2017, Quentin Schulz wrote: > > > >> According to their datasheets, the AXP221, AXP223, AXP288, AXP803, > >> AXP809 and AXP813 PEK have different values for startup time bits from > >> the AXP20X, let's use the platform device id with the correct values. > >> > >> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com> > >> --- > >> drivers/mfd/axp20x.c | 12 ++++++------ > >> 1 file changed, 6 insertions(+), 6 deletions(-) > > > > Patch is find, but are these names reference from platform data > > anywhere i.e. are we going to break anything by applying it? > > > > I don't really understand what you're asking. Yes, I guess that was a little Fringlish, apologies for my haste. > We need the first patch of this patch series to be applied before the > second patch or axp20x-pek driver wouldn't be probed anymore. > > There is no Device Tree declaring axp20x-pek and there is no support for > Device Tree probing in the driver. > > I don't see how I could break anything with these patches. Could you > explain with an abstract example, please? I might not break anything > here but it's better to know now what I could have broken in another > situation/with another patch series so I won't make that mistake in the > future. > > Oh, but this patch series would change the name of the directory exposed > in sysfs (/sys/bus/platform/devices/axp221-pek/*). Is that what you were > afraid of? I'm worried about any breakage in terms of name referencing. If this driver is DT only, then the concern is less, but in the olden days, we used to conduct device/driver binding using the name. Ergo, if you change the name in the driver without updating the device registration, we would not bind and .probe() would not be called. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
On Mon, 17 Jul 2017, Quentin Schulz wrote: > According to their datasheets, the AXP221, AXP223, AXP288, AXP803, > AXP809 and AXP813 PEK have different values for startup time bits from > the AXP20X, let's use the platform device id with the correct values. > > Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com> > --- > drivers/mfd/axp20x.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c index ec4271ca065c..336de66ca408 100644 --- a/drivers/mfd/axp20x.c +++ b/drivers/mfd/axp20x.c @@ -677,7 +677,7 @@ static struct mfd_cell axp20x_cells[] = { static struct mfd_cell axp221_cells[] = { { - .name = "axp20x-pek", + .name = "axp221-pek", .num_resources = ARRAY_SIZE(axp22x_pek_resources), .resources = axp22x_pek_resources, }, { @@ -702,7 +702,7 @@ static struct mfd_cell axp221_cells[] = { static struct mfd_cell axp223_cells[] = { { - .name = "axp20x-pek", + .name = "axp221-pek", .num_resources = ARRAY_SIZE(axp22x_pek_resources), .resources = axp22x_pek_resources, }, { @@ -835,7 +835,7 @@ static struct mfd_cell axp288_cells[] = { .resources = axp288_fuel_gauge_resources, }, { - .name = "axp20x-pek", + .name = "axp221-pek", .num_resources = ARRAY_SIZE(axp288_power_button_resources), .resources = axp288_power_button_resources, }, @@ -846,7 +846,7 @@ static struct mfd_cell axp288_cells[] = { static struct mfd_cell axp803_cells[] = { { - .name = "axp20x-pek", + .name = "axp221-pek", .num_resources = ARRAY_SIZE(axp803_pek_resources), .resources = axp803_pek_resources, }, @@ -862,7 +862,7 @@ static struct mfd_cell axp806_cells[] = { static struct mfd_cell axp809_cells[] = { { - .name = "axp20x-pek", + .name = "axp221-pek", .num_resources = ARRAY_SIZE(axp809_pek_resources), .resources = axp809_pek_resources, }, { @@ -873,7 +873,7 @@ static struct mfd_cell axp809_cells[] = { static struct mfd_cell axp813_cells[] = { { - .name = "axp20x-pek", + .name = "axp221-pek", .num_resources = ARRAY_SIZE(axp803_pek_resources), .resources = axp803_pek_resources, }
According to their datasheets, the AXP221, AXP223, AXP288, AXP803, AXP809 and AXP813 PEK have different values for startup time bits from the AXP20X, let's use the platform device id with the correct values. Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com> --- drivers/mfd/axp20x.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.11.0