From patchwork Sun Sep 24 20:00:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 114154 Delivered-To: patch@linaro.org Received: by 10.140.106.117 with SMTP id d108csp1855619qgf; Sun, 24 Sep 2017 13:02:43 -0700 (PDT) X-Received: by 10.99.161.17 with SMTP id b17mr5461933pgf.292.1506283363868; Sun, 24 Sep 2017 13:02:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1506283363; cv=none; d=google.com; s=arc-20160816; b=LXfjEfGYAgytSWGa/pLLZRz32LpdENg9XGYX+zrKvLi+FXapFP8ndPZKgUGzvduWRc slxMSzY1GdkmviIOmTy60SVVAF7y0okaJ/NBpwNLNpoMk2tyis1lOgJimb/ixyiNv5Z8 y6PpSji1eigW9vx7Nf9f7JFt4Eo9W+FPLaRbSsM2Gdu41xpooyTwk956LmDEyZ/3EGmG lBQRdi5VOG8MoZcE/SwKR04BYr867B9uHzI7vhmV/bUAAP26EGAu5Sll1e6wo3BdqQmC S72PI5rbjVaNGFJiYPO0T8YR9VQiOSryJRjhiy+xR5sb51FvXFK+u0+jmncQfKbMLwZ/ Q59Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=3P7JlM6POjK64UT8NYdIWaw2weeZcXFr/vritVB4nPA=; b=rAbUdIZCq2V1yWMrWfbl4KTsRhQxY8Gb4TJvSUsIw3FtiZdLh2fC96I1ut9e8dbLCB 3BpcCJhAW6ZPq3iqHg+QuVqlsvVVUO86+rU7sHuR0oJrP9vnzznd29G9aqb0NHr2k/pm SzXk3zxxhpPG3UW6zqXHRNfCFzFEVx/hQ8fMJoD+ympC2KJWWr4R+FWL9Mij0XXlaXQv yiBnEBbGOaCHCM0uD/pgzRk4X00xgEdB4TyPcPqdtn1Is45KPCFil9/CbKLP/tq0D+xn 4pvVR/MXO5cpytbIdKKSrlp1/UQJaxZKNFe6EZi0tO6DCFhq/JN5qI+6fuqTxSigYB1y UvEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=hljpkgRF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h17si2908350pfk.531.2017.09.24.13.02.43; Sun, 24 Sep 2017 13:02:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=hljpkgRF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753189AbdIXUCl (ORCPT + 26 others); Sun, 24 Sep 2017 16:02:41 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:46582 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752872AbdIXUAi (ORCPT ); Sun, 24 Sep 2017 16:00:38 -0400 Received: by mail-wm0-f44.google.com with SMTP id m72so14326771wmc.1 for ; Sun, 24 Sep 2017 13:00:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3P7JlM6POjK64UT8NYdIWaw2weeZcXFr/vritVB4nPA=; b=hljpkgRFLitMHmPk9qXDrCU2RxcbzKedIg4n6QUKtYaiLUJjo0SHaWur4eCtg3906L 1KemCfTNQwu4JeepAQuF8E6PZH9LlW0dXQsxYm3g7AlQEh4Lghx4o0lJtSMZZ92XVshd Og/tQ/LHd3KLQYrnjpyIOt85pd4qBfB71weA4gEcdGthWu7+WiC3mq0JALVq9oUF8if2 FHSBK7PadFzAF+gOL0//bxji7rv3nLK8FQdy00FWngQgZuvuXGVgtitXt6VQ3A259ZgE 5+hvYu82fRRZgRuuBSIjnourLwsr1YgxP2sMPWTRWsVTNfEl3jQf4RpN9wlT9ISjGjLC d+mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3P7JlM6POjK64UT8NYdIWaw2weeZcXFr/vritVB4nPA=; b=EivzcRhd6RTI7VsuFf2gSySlE/G8HLEuHAztI/E3lddNFpxGD1IjPoQBikr+S/WHfP Ee1j5q9Wk2jZWWvFJt8A9/WzTHbpst/lQrZtVpqO0h7HW9tcdWMz0CzYEnFYiOg4o0cu KPzturL1OgGAwrG2uk5RZWab+rEge13QQ3TqGF4Z5sMPCTWicKz1XCjlY42nBXHKpUGw lRddGS1R/OlQv/ldjdzLVDsp8GW/3J4t4OUheDXC4qKWApf3Kv7sKcBn3ezw5Ux4h4BC OhdPKYSoOw7p7F+88AB2ySuRyFL/Gijqut2TX3srSVbw9MRWWLG4Gl1Nrw2Qmky42vv/ 0XZA== X-Gm-Message-State: AHPjjUiiLir2MjH+S7gzSrxkjgm0MXdBaFI6VHOxNB8066jZVg8UUJli 3coHX1aEbK8hBpIutbhA9sRKAA== X-Google-Smtp-Source: AOwi7QCBUTBQDULfoLqpOEHhcSY3wIgA5dAkhQz1C6l6n+d9WozkWCB00ZRW3V9Zbt14oq/rw3H9sA== X-Received: by 10.28.153.85 with SMTP id b82mr7524117wme.121.1506283237746; Sun, 24 Sep 2017 13:00:37 -0700 (PDT) Received: from localhost.localdomain (cag06-3-82-243-161-21.fbx.proxad.net. [82.243.161.21]) by smtp.googlemail.com with ESMTPSA id j5sm6786144wmg.8.2017.09.24.13.00.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Sep 2017 13:00:37 -0700 (PDT) From: Jerome Brunet To: Stephen Boyd , Michael Turquette Cc: Jerome Brunet , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , Linus Walleij , Quentin Schulz , Kevin Hilman Subject: [PATCH v4 01/10] clk: fix incorrect usage of ENOSYS Date: Sun, 24 Sep 2017 22:00:21 +0200 Message-Id: <20170924200030.6227-2-jbrunet@baylibre.com> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20170924200030.6227-1-jbrunet@baylibre.com> References: <20170924200030.6227-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ENOSYS is special and should only be used for incorrect syscall number. It does not seem to be the case here. Reported by checkpatch.pl while working on clock protection. Acked-by: Linus Walleij Tested-by: Quentin Schulz Signed-off-by: Jerome Brunet --- drivers/clk/clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.13.5 diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index c8d83acda006..b31e56b09e25 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -1804,7 +1804,7 @@ static int clk_core_set_parent(struct clk_core *core, struct clk_core *parent) /* verify ops for for multi-parent clks */ if ((core->num_parents > 1) && (!core->ops->set_parent)) { - ret = -ENOSYS; + ret = -EPERM; goto out; }