From patchwork Wed Oct 11 06:45:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 115511 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp410171qgn; Tue, 10 Oct 2017 23:47:39 -0700 (PDT) X-Received: by 10.98.103.93 with SMTP id b90mr15719687pfc.2.1507704459304; Tue, 10 Oct 2017 23:47:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507704459; cv=none; d=google.com; s=arc-20160816; b=PI8aOJAWSKO6Bem8+iUwiD7hocUuw/VlI0QX0x0PaJFV0bkxUt2ol06KlmRNftRmJe 9zndYcRScUbsbXEQZDIfEQyEWKdqNJmI3a/ZlwPbopSbObf4SLoPiIHpgTq9jBCj87PB /uW2GCMtiD/QHKjxeyzgQBLZg4ueBEuiDQwz8RkZKWCQQGuc8m0RKXrwHBWwSRSnJT2D QztGCGQ6bA8vW95FUOS/BpvRze6cbLSWPqH4c8tLHkd0Jdf59Ac9nvCp0uqoQZpmfQGm 01IyEO6dg73EmbXJjIahUOLGTxbEsoK3mAL1ITcl3GDpplbWsKrcYEf1r5su6gZPraiP JcYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=tom3zK/GFw6uChMa7PbJyymdKgx1ATdTjjhFDCuYEuU=; b=AJlIb9VAvJesy9+uq64H8DmW9uAi/iVtgDsuTRyt39HiJj/nzjQ4muid43DJF5+jH1 YwKgQhdl3afCaSleSpz4R7tvR+zKq9xSNRyduX5mX3TaS/w7Ha8DnEcSS3uRywZSWSOv BgLad5c6BLAGeeJY0V2hz6+/LkTAHV3XsRxuQFIzy/WMnWCppsjSmXfpaLNJDQ6LZr8E fwxliHJsK2r3zeKPtivajBk8JI4QhhwAMAz53jU0TpEosm/7hztqShBqkzOV8pHD38c+ Lhf8f4gm4MfLBri4SoI/5LtUdVjpjKC5BFRRKMBdXXkGcZEGipRzM2drtkyr0UssgIlk Cypw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JksIELn6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k190si10496067pfc.298.2017.10.10.23.47.39; Tue, 10 Oct 2017 23:47:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JksIELn6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757199AbdJKGri (ORCPT + 26 others); Wed, 11 Oct 2017 02:47:38 -0400 Received: from mail-pf0-f182.google.com ([209.85.192.182]:43297 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754255AbdJKGp2 (ORCPT ); Wed, 11 Oct 2017 02:45:28 -0400 Received: by mail-pf0-f182.google.com with SMTP id a8so198363pfc.0 for ; Tue, 10 Oct 2017 23:45:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tom3zK/GFw6uChMa7PbJyymdKgx1ATdTjjhFDCuYEuU=; b=JksIELn6lNP5XLtRV+AYHsEtkzK5RQmLdzp1B6bZuv6mydUd9hsM6Ix4j9Txi6uZsu e6rDvjoFmqumc8Y9tkS2YQQr5UjB9Z+OQGoW2ggSPiKFioJ1RWA3Tquf+2VmFDhqCTw2 /78ymiYCHqci7Ae/bXVrQEi6TNtnt7TnZtJiI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tom3zK/GFw6uChMa7PbJyymdKgx1ATdTjjhFDCuYEuU=; b=RKI1EZT/EEQkIsozKKs5KP5sNlIr/Bg6f6P8IBXqZB9sjQgdIrqO7RyTHsol5bVbcl 68F4a0ILjCasFogd4b+tADqVKT8/DbYR2/4X4kra8vZ4v+GOhpsemy6nLvZJ1a/bkkVQ KKeF/UA/M+TuENDAMptHRBgWJIEE3g97g8AL2wlgATNUw4iLpeyY5rX3XpXOnwl6duCi 6Jz4X+aGXE40NprRnimx/wEglP8YWOGtQew5lZejFnW+og2GqUdLuACoMP+9Zrg8wSCk nl8cat90yu/f94f4evBQyd4w5T9KltxFTaVk9rRCR8VrKMUTiqK7Ol9qCjAK/oCY/pk+ 4M8w== X-Gm-Message-State: AMCzsaX6WFwgfFzGJpun0J4wBbLLkiIcN+3D1qB0cw7iBG/XPNfX7nop DEOpSPMsYeJqwBKlVEyhk9edSw== X-Google-Smtp-Source: AOwi7QDL6mk4t0dsTf5de1FDG2B+OE+27V0xVxoGzltoW509FqK61RpBaZH4Zk+pP9eF1QwiDR50Zg== X-Received: by 10.84.192.3 with SMTP id b3mr14664066pld.118.1507704328263; Tue, 10 Oct 2017 23:45:28 -0700 (PDT) Received: from localhost.localdomain (ip68-111-217-79.sd.sd.cox.net. [68.111.217.79]) by smtp.gmail.com with ESMTPSA id l79sm411779pfb.33.2017.10.10.23.45.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Oct 2017 23:45:27 -0700 (PDT) From: Bjorn Andersson To: "David S. Miller" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Chris Lew Subject: [PATCH v2 1/7] net: qrtr: Invoke sk_error_report() after setting sk_err Date: Tue, 10 Oct 2017 23:45:17 -0700 Message-Id: <20171011064523.7902-2-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20171011064523.7902-1-bjorn.andersson@linaro.org> References: <20171011064523.7902-1-bjorn.andersson@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rather than manually waking up any context sleeping on the sock to signal an error we should call sk_error_report(). This has the added benefit that in-kernel consumers can override this notification with its own callback. Signed-off-by: Bjorn Andersson --- Changes since v1: - None net/qrtr/qrtr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.12.0 diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index c2f5c13550c0..7e4b49a8349e 100644 --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c @@ -541,7 +541,7 @@ static void qrtr_reset_ports(void) sock_hold(&ipc->sk); ipc->sk.sk_err = ENETRESET; - wake_up_interruptible(sk_sleep(&ipc->sk)); + ipc->sk.sk_error_report(&ipc->sk); sock_put(&ipc->sk); } mutex_unlock(&qrtr_port_lock);