From patchwork Tue Jan 2 17:54:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 123190 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp9237974qgn; Tue, 2 Jan 2018 09:56:59 -0800 (PST) X-Google-Smtp-Source: ACJfBou7iZ15/87W6cWzQGN6GIyuPSHh1o2DFH867/7QJUD68fK27UcasGIqundtlDoEGg+kI2xY X-Received: by 10.99.127.29 with SMTP id a29mr39440023pgd.3.1514915819603; Tue, 02 Jan 2018 09:56:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1514915819; cv=none; d=google.com; s=arc-20160816; b=eJKHGgw2X8AinLc0RedeGT8Ah0Jtias0fL7DtRc0lqElqtYncHFiD8pREdhp+SfPou fF/MgqVBG75ACxvfDwlxOakz8aqxWFJmJhS4HoWovn/J6e2smpbFc1xkcOK8dao4W5Sn ZWXmMWgd0RydK8EKklA9+xARbKTjxTgHZO+o/qyEoWqJqqjO2YTa8DeiKf4rfqUdUBac z/SA1Fzdc4T2z2ggSLhGnDhY2pIYv+WWiz2048YU+/rxiZLJGfwdXqGeU6Nh0wjEA/JD 33F05k8Bmd5Tq4azs92KFdZIRzJxKiKW5//0yY5RXR4AwSTmOda+Mye1G5u9HUiDWO4y iZkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=sgoBP8nCXf6MzED4mB9DqU7pHqDhM7VbkAjm17OCSkw=; b=eAmNq8ZP7VKsbGfCW9w69OqlFxMT+zNkWo5fsZ46kgjBocIQulAEGPLOFEkN9JnyBd hlJAG32k0UGuhaB1grHQvEXdVZd63sQG6L6m/7n+jkq/J1rz9rMqgW+1uvCAKJolrCmu qlqmfUkFuMY76sS9roS3X04SRGw/kvS76f+bzWyRTrJF8P0SJyE4tZk49RcCj8jaVwRY 6q5vhmySfHZuDlftSFu0d/Dwbp2iJP3chXmq7UMRX2YfW0xgicVDo7fB141MB6bXFk+Q X2UrD7tP8G2OD/CGIsWVEQKWZ/AY4uoGg/R8dSp2TT2H/2UvXU5xbfS0v6/j28m9nQyv eJzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aEWM6qad; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o20si34656789pli.279.2018.01.02.09.56.59; Tue, 02 Jan 2018 09:56:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aEWM6qad; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751355AbeABR4m (ORCPT + 28 others); Tue, 2 Jan 2018 12:56:42 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:39872 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751156AbeABR4j (ORCPT ); Tue, 2 Jan 2018 12:56:39 -0500 Received: by mail-wr0-f196.google.com with SMTP id o101so20619144wrb.6 for ; Tue, 02 Jan 2018 09:56:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sgoBP8nCXf6MzED4mB9DqU7pHqDhM7VbkAjm17OCSkw=; b=aEWM6qadGvm3LAcxrwG/E3dBjwaYI406hvOmHztttYU5jyexx5lxCG2wane9KKdbm+ aI6RJIZiaE4+ezfd2lH6+QWPDaerzsbVkJj4VTi6xRGArONfqEs6bH4pZDDZkwBN9X8Q eBCRwzdGtLLQtZDX2L0VicSsTxiGOlOFZ6SOQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sgoBP8nCXf6MzED4mB9DqU7pHqDhM7VbkAjm17OCSkw=; b=GlK5U7ZveIQISbk6IZ6/tUhEfMohmu+lMm2TYacyXzoyjo11K8LIcDT8mNbv36a6Pd obkjrM3ujgxKTvqlfG3S93RLEcHM3wPbCdRcNYjRCfrrDJfj0Xh0m4K8SIDNFqql9oFf XyHQ3dOfhetjI7N7V4/PBnULNvqpNVBhlGFMxJBntkXEOKKm/CbQH1TZhMAhHBt9W402 c/VRUKfRtEcT8ykmelXcQC1tNDmWjxo7e8x5TOd3Tvhr1JVatylAPstITTklfTHAEJ0t O0bHambykDQwKawK6cyU0oB4oKi0Kjn7stw4rgx7WDRMkQG53Elnr5QnbTSfHR2pnida AzTw== X-Gm-Message-State: AKGB3mK1sGun3taKIhGebhqrZ77+hLxqYDFNClBOMt1oNG/F79+mos6M DE2/Qvagjx6IdsiL+XSfb3b86aLt9ko= X-Received: by 10.223.154.112 with SMTP id z103mr48129031wrb.210.1514915798573; Tue, 02 Jan 2018 09:56:38 -0800 (PST) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id u54sm21895240wrf.77.2018.01.02.09.56.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 02 Jan 2018 09:56:38 -0800 (PST) From: srinivas.kandagatla@linaro.org To: Greg Kroah-Hartman Cc: sdharia@codeaurora.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Wei Yongjun , Srinivas Kandagatla Subject: [PATCH 5/6] slimbus: Fix missing unlock on error in slim_msg_response() Date: Tue, 2 Jan 2018 17:54:23 +0000 Message-Id: <20180102175424.14391-6-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.15.0 In-Reply-To: <20180102175424.14391-1-srinivas.kandagatla@linaro.org> References: <20180102175424.14391-1-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun Add the missing unlock before return from function slim_msg_response() in the error handling case. Signed-off-by: Wei Yongjun Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 1 + 1 file changed, 1 insertion(+) -- 2.15.0 diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c index a9a6dc4af0da..884419c37e84 100644 --- a/drivers/slimbus/messaging.c +++ b/drivers/slimbus/messaging.c @@ -38,6 +38,7 @@ void slim_msg_response(struct slim_controller *ctrl, u8 *reply, u8 tid, u8 len) if (msg == NULL || msg->rbuf == NULL) { dev_err(ctrl->dev, "Got response to invalid TID:%d, len:%d\n", tid, len); + spin_unlock_irqrestore(&ctrl->txn_lock, flags); return; }