From patchwork Sat Jan 13 00:59:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeremy Linton X-Patchwork-Id: 124404 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp73852qgn; Fri, 12 Jan 2018 17:03:28 -0800 (PST) X-Google-Smtp-Source: ACJfBot0pH112X1xS3sDO2En8anePCevcBfCceY/a/pE9C+j01Yi3Zf/j8AFXh1qCF3hx1jPRKJu X-Received: by 10.99.65.70 with SMTP id o67mr22390080pga.125.1515805408590; Fri, 12 Jan 2018 17:03:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515805408; cv=none; d=google.com; s=arc-20160816; b=JqghgPSNKbbbouTkAptcsjA7V1lzkSWM+h1o0W+vWBbBWC+xkA6VjFUv2KgaZ8PVYx JkbQeaKCLN4bH7OC2atCq2A6l1QQghze5oFMQEOx94rlT3Il3JDFd/Ur4JItRZGO2KGs Kgt3aHIiR8z3fdUix2EkNjAtYOua0skn/b8JZisjkd5XnUVO4yADCoga1lHeFwU3tXVe 2037mRotVeFi0gsMSztnhTPxageV70jaotrQhzHjk1ZeSzp6fErUKuyaI8PoCxXDWrGq NsVRMkaHo1L05shHZ/xPY6qVw2Bk6ai0kIXEu8PtasWd4emL2zuj7aFXq2q2SCydw/gI PueA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=8+bzGIZtcm6V7acbG5m/s/wolRltK4eGTjZdYcX8JF8=; b=ZttGxB31mxlD8ecb6uIr5fsmqkgAtVYlnq1GrGU2lJojJGAVhKxsSFdxohtpVMh/5V o+vEgqWAuqjm/YBN1Pz7OgPiC4MSODhjk5ZpXIZWTw0fPj19swQvGSDtEWoxS89DJzsm oEmLzpFLb7ZViH+YRLZ8dAMLoBESm5Vs6QNMWjnHmmQtqYvCwkeBQBSYmbT5CjGfgxm3 kGOKzCNCoSxpvj4xO0WMhB81JZOOUNdZZdGfORKTEHr9pW3vvRZaZlcRXiA8vhuPckm3 xT7jEUujR9Z2/wxA9v1oc8qwMF1d3yr8NlppjMZ6/JvmWssiKKUx3FYYcRcOZmdPQQTT dZDw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q4si16543388plb.249.2018.01.12.17.03.28; Fri, 12 Jan 2018 17:03:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965658AbeAMBD1 (ORCPT + 28 others); Fri, 12 Jan 2018 20:03:27 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:53798 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965450AbeAMBAo (ORCPT ); Fri, 12 Jan 2018 20:00:44 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AB49E1610; Fri, 12 Jan 2018 17:00:43 -0800 (PST) Received: from beelzebub.austin.arm.com (beelzebub.austin.arm.com [10.118.12.119]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A21863F487; Fri, 12 Jan 2018 17:00:42 -0800 (PST) From: Jeremy Linton To: linux-acpi@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com, hanjun.guo@linaro.org, lorenzo.pieralisi@arm.com, rjw@rjwysocki.net, will.deacon@arm.com, catalin.marinas@arm.com, gregkh@linuxfoundation.org, viresh.kumar@linaro.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, jhugo@codeaurora.org, wangxiongfeng2@huawei.com, Jonathan.Zhang@cavium.com, ahs3@redhat.com, Jayachandran.Nair@cavium.com, austinwc@codeaurora.org, lenb@kernel.org, vkilari@codeaurora.org, morten.rasmussen@arm.com, Jeremy Linton , Palmer Dabbelt , Albert Ou Subject: [PATCH v6 03/12] cacheinfo: rename of_node to fw_unique Date: Fri, 12 Jan 2018 18:59:11 -0600 Message-Id: <20180113005920.28658-4-jeremy.linton@arm.com> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20180113005920.28658-1-jeremy.linton@arm.com> References: <20180113005920.28658-1-jeremy.linton@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rename and change the type of of_node to indicate it is a generic pointer which is generally only used for comparison purposes. In a later patch we will apply an ACPI/PPTT "token" pointer in fw_unique so that the code which builds the shared cpu masks can be reused. Cc: Palmer Dabbelt Cc: Albert Ou Signed-off-by: Jeremy Linton --- arch/riscv/kernel/cacheinfo.c | 2 +- drivers/base/cacheinfo.c | 16 +++++++++------- include/linux/cacheinfo.h | 8 +++----- 3 files changed, 13 insertions(+), 13 deletions(-) -- 2.13.5 Acked-by: Sudeep Holla diff --git a/arch/riscv/kernel/cacheinfo.c b/arch/riscv/kernel/cacheinfo.c index 6f4500233cf8..6b0219af88d4 100644 --- a/arch/riscv/kernel/cacheinfo.c +++ b/arch/riscv/kernel/cacheinfo.c @@ -20,7 +20,7 @@ static void ci_leaf_init(struct cacheinfo *this_leaf, struct device_node *node, enum cache_type type, unsigned int level) { - this_leaf->of_node = node; + this_leaf->fw_unique = node; this_leaf->level = level; this_leaf->type = type; /* not a sector cache */ diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c index fc0d42bbd9eb..217aa90fb036 100644 --- a/drivers/base/cacheinfo.c +++ b/drivers/base/cacheinfo.c @@ -47,7 +47,7 @@ struct cpu_cacheinfo *get_cpu_cacheinfo(unsigned int cpu) static inline bool cache_leaves_are_shared(struct cacheinfo *this_leaf, struct cacheinfo *sib_leaf) { - return sib_leaf->of_node == this_leaf->of_node; + return sib_leaf->fw_unique == this_leaf->fw_unique; } /* OF properties to query for a given cache type */ @@ -178,9 +178,10 @@ static int cache_setup_of_node(unsigned int cpu) struct cpu_cacheinfo *this_cpu_ci = get_cpu_cacheinfo(cpu); unsigned int index = 0; - /* skip if of_node is already populated */ - if (this_cpu_ci->info_list->of_node) + /* skip if fw_unique is already populated */ + if (this_cpu_ci->info_list->fw_unique) { return 0; + } if (!cpu_dev) { pr_err("No cpu device for CPU %d\n", cpu); @@ -201,7 +202,7 @@ static int cache_setup_of_node(unsigned int cpu) if (!np) break; cache_of_set_props(this_leaf, np); - this_leaf->of_node = np; + this_leaf->fw_unique = np; index++; } @@ -289,7 +290,7 @@ static void cache_shared_cpu_map_remove(unsigned int cpu) cpumask_clear_cpu(cpu, &sib_leaf->shared_cpu_map); cpumask_clear_cpu(sibling, &this_leaf->shared_cpu_map); } - of_node_put(this_leaf->of_node); + of_node_put(this_leaf->fw_unique); } } @@ -334,8 +335,9 @@ static int detect_cache_attributes(unsigned int cpu) if (ret) goto free_ci; /* - * For systems using DT for cache hierarchy, of_node and shared_cpu_map - * will be set up here only if they are not populated already + * For systems using DT for cache hierarchy, fw_unique + * and shared_cpu_map will be set up here only if they are + * not populated already */ ret = cache_shared_cpu_map_setup(cpu); if (ret) { diff --git a/include/linux/cacheinfo.h b/include/linux/cacheinfo.h index d35299a590a4..6f2e6c87b64c 100644 --- a/include/linux/cacheinfo.h +++ b/include/linux/cacheinfo.h @@ -34,9 +34,8 @@ enum cache_type { * @shared_cpu_map: logical cpumask representing all the cpus sharing * this cache node * @attributes: bitfield representing various cache attributes - * @of_node: if devicetree is used, this represents either the cpu node in - * case there's no explicit cache node or the cache node itself in the - * device tree + * @fw_unique: Unique value used to determine if different cacheinfo + * structures represent a single hardware cache instance. * @disable_sysfs: indicates whether this node is visible to the user via * sysfs or not * @priv: pointer to any private data structure specific to particular @@ -65,8 +64,7 @@ struct cacheinfo { #define CACHE_ALLOCATE_POLICY_MASK \ (CACHE_READ_ALLOCATE | CACHE_WRITE_ALLOCATE) #define CACHE_ID BIT(4) - - struct device_node *of_node; + void *fw_unique; bool disable_sysfs; void *priv; };