From patchwork Wed Feb 14 13:43:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 128348 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp625396ljc; Wed, 14 Feb 2018 05:47:45 -0800 (PST) X-Google-Smtp-Source: AH8x2267fxH9QH+VoiYnzGFp+1wsy0hh5fX0XbCIWz0IWt+x7uD6ybO0psv6+G3e94mbVcEQOVWa X-Received: by 2002:a17:902:32a2:: with SMTP id z31-v6mr4659831plb.32.1518616065101; Wed, 14 Feb 2018 05:47:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518616065; cv=none; d=google.com; s=arc-20160816; b=SrYVZvVA4tSRdVM7xYGdR4xBxaga7iwtN9oqgNIekl0EJ7/Cu2oxpN5QwdWfingl3f tSTFGyTCgFIh01xcVoCk47ZN+wHyW4uCWs91cj84ljvNiFqY8a96rfOdu/UwvCwBIVCc ea7FoscbAClz753LjYbDtMsg7eswGL4cK1TxZ2lZ26YWLgJXlwqH504a7A/gG1Wdbetg 4Zjx8NKkHnSrdUZO1KX9ItxdxUis828dHnMhiNmepOXqRlKgN1AFCywSEgCsbO0yYen9 +6jVs4rQZMEDyU5GYHRI8LzFfplZqasQHbTxTP87/N9oBG7+5cjwu+4RSkTfpAnYvGPx lGeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=xvmHmSrapQovZQJzIEqIpaecKemQ2ijAcfwElQXzau4=; b=zUhSavON1usUWvFTnScuFYPhlqmc6fM+sdqNHXKKk7UeaO3CTHqm1nRakRTv1FqcBf QsUzuhRNfOpYwagamKGXGaTKuu7jfsI7jwB6OYg03P9QsgXLVZz88LtObZ4aEMBMAvR9 7/fPgFs/MdsOJ2Y9XGBMofTiyAX/ZFXciCT2DZg7CtRczH+Z4Mm2GZQ+SzAn2IfkIQmQ 05nZzrPBP7CCyU2LSxpwscE2w47nXyjaaXhiiFnAImpVobWcLGoU1Gck+MvpwByVuBKR 85hn3UkzaPacZM0PN1xnmaWcW0RwMSAV4HaSGr7VuDF+BmEn7ll1ThXd2iNl/Ef9YUMz sxXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=ABxgKet5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y38-v6si1619230plh.448.2018.02.14.05.47.44; Wed, 14 Feb 2018 05:47:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=ABxgKet5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030452AbeBNNrj (ORCPT + 28 others); Wed, 14 Feb 2018 08:47:39 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:44877 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030393AbeBNNnv (ORCPT ); Wed, 14 Feb 2018 08:43:51 -0500 Received: by mail-wr0-f194.google.com with SMTP id v65so15403116wrc.11 for ; Wed, 14 Feb 2018 05:43:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xvmHmSrapQovZQJzIEqIpaecKemQ2ijAcfwElQXzau4=; b=ABxgKet5nBv2/vg7rp8LvTcff4QNqml63fBDzyx5svMZ2YRJZkDOUHiI8hewy0OwM2 rFfsB1niIj6rB19dXUK6v3aCvxpoe9KQrX7xNVISnL9f8vyj/7uEwdvp8bu2ld5MdFNB 263KSfwv07thCGbWjP6nzzTlMr+00YWAA1nidIyhNnXThh5UoJq5bI/YIrbTrvt+Klw1 zku0Z2kS3r7b9eqi5ixsL4ZMj7OM/fIGbmCtAwyvoPc1geNa+erISee1qut0i9Cs4p2S wesGtZi/56mcDnKgEi1/8NpRhjVnmTOMnx4tc8rVYunn33TKKbwWsBahtOSKfz8NyT4j zaXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xvmHmSrapQovZQJzIEqIpaecKemQ2ijAcfwElQXzau4=; b=WlroQt4F/cryweFq8urc2vWu11xWJiG9fT9/cG1nrjsYSfsZNa9Wg6ILAkLtUghsgi KWmVr1BUyjyhVqXg/PQiBLiGLlWhKNUaKkcuqvusmXS2CVJlRuCXRFJAF/jPkjEdjs6t zuLz/wajn92yunQ9T8v35SZVSyB26wfvkd24sb0QFJvBYhhJ+gOahivSx3SEs98Hnq3m z6J6XjrT4Wg8OOktQDFzmQ24sg9UMWT44yPVJIZYkHUWayKS+++dnc1JbjXgaAN2aaTb UIIairFEYtnKiCq2J8dshKMjeMz9kM3vZf9iIzI2bqB/SpFl3BqHjCvisockaQCGZLqL q/vw== X-Gm-Message-State: APf1xPAGMOodzAPBhzJTbU0j4YxV2B7wIsXnN4dLuuLfJckeAEReAmFT SeUbB8uTK2AvsjqhW00JJAhvcA== X-Received: by 10.223.209.3 with SMTP id a3mr4363219wri.27.1518615830357; Wed, 14 Feb 2018 05:43:50 -0800 (PST) Received: from boomer.lan (cag06-3-82-243-161-21.fbx.proxad.net. [82.243.161.21]) by smtp.googlemail.com with ESMTPSA id k5sm6337694wmg.47.2018.02.14.05.43.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Feb 2018 05:43:49 -0800 (PST) From: Jerome Brunet To: Michael Turquette , Stephen Boyd Cc: Jerome Brunet , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/8] clk: call the clock init() callback before any other ops callback Date: Wed, 14 Feb 2018 14:43:37 +0100 Message-Id: <20180214134340.17242-6-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180214134340.17242-1-jbrunet@baylibre.com> References: <20180214134340.17242-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some clocks may need to initialize things, whatever it is, before being able to properly operate. Move the .init() call before any other callback, such recalc_rate() or get_phase(), so the clock is properly setup before being used. Signed-off-by: Jerome Brunet --- Stephen, Mike, This change is addressing a problem I have with clock driver I'm working on. This driver needs the .init() callback to run first is order to answer correctly .get_phase(). It does not address an existing issue, not one that I'm aware of at least. This is why I did not put a Fixes tag. In any case, it makes sense to run init before running anything else. drivers/clk/clk.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) -- 2.14.3 diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index cca05ea2c058..9d56be6ead39 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -2929,6 +2929,17 @@ static int __clk_core_init(struct clk_core *core) core->orphan = true; } + /* + * optional platform-specific magic + * + * The .init callback is not used by any of the basic clock types, but + * exists for weird hardware that must perform initialization magic. + * Please consider other ways of solving initialization problems before + * using this callback, as its use is discouraged. + */ + if (core->ops->init) + core->ops->init(core->hw); + /* * Set clk's accuracy. The preferred method is to use * .recalc_accuracy. For simple clocks and lazy developers the default @@ -3006,17 +3017,6 @@ static int __clk_core_init(struct clk_core *core) } } - /* - * optional platform-specific magic - * - * The .init callback is not used by any of the basic clock types, but - * exists for weird hardware that must perform initialization magic. - * Please consider other ways of solving initialization problems before - * using this callback, as its use is discouraged. - */ - if (core->ops->init) - core->ops->init(core->hw); - kref_init(&core->ref); out: clk_pm_runtime_put(core);