From patchwork Wed Feb 14 13:43:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 128347 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp622740ljc; Wed, 14 Feb 2018 05:44:39 -0800 (PST) X-Google-Smtp-Source: AH8x225ruOy67C75hh8E3LuUCLsvIbnnjOvdoQ9G1ZIPAxTikdjMWw79agg/s/2UXRBN0NGNq4b7 X-Received: by 10.98.202.2 with SMTP id n2mr4807094pfg.13.1518615879058; Wed, 14 Feb 2018 05:44:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518615879; cv=none; d=google.com; s=arc-20160816; b=Pzs7xQeIC1JkQlZOeXHqyXIpLBb9M460UN0OVgk1epRzbRHJlSFQ/th3fHIU4p2doq qCOIaI0qsu0ZBZT9UBMdo/PCHzpVq7lPTCTxaUY8D7blxK3r3RbuMnM29T9u9wK0hn6W hk232klGuveantjU7GvMz2xANC0JelaRQ7t/9F5tIC3TwLWYQhl6jAxFxmgysC72Dn4H ZJMzQ3kXBsequA7CiSN/caCIodRAh8rVAOsS8AhjYdsgLBpdulNTkl8life0l868eWoC Si6hjj7r42S9tVDbCwxDUvrBtYJX4hBERRgw5HSiQPU4PONTjaWBeZRWBUnfPK7rHhjW EMhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=xpoPJpSjmefP/eaP3ikiVrqO/x/qS2dsetdWYBOL7/A=; b=GVgh0o+AAhdlJ5Fa5zUwp5g9B+Eof19G/yq2kYTdu7oPj0rONvXF1pj/j6n2JDoj9D ZcdFh/gIk5tx1f7FWyvJTaUj8rvfsyVa30jlRv3+quQGm25qSwYZzqholFEM9PUwE0u7 PyoxNo9Up+I1GP7JN4FShh+xZVANKGZ9oVBrt4rjTIT3Ub65WTmES8me3VcOBO4rb2cj nfPc2PqZWoWNrudrycLRGj6t3yeK16Mz2wBgos2V0sB8WOIhHoG/DyRD/J/4kgco2LKp 67AAVqVb14FgGfh/VfQ40PJ0ZxQ1lcEA+p0xca/5EfuuxXrZG7ciVFzvMftG/T0ug95O E3wQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=Woyjf2hy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n11si2763430pgq.230.2018.02.14.05.44.38; Wed, 14 Feb 2018 05:44:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=Woyjf2hy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030441AbeBNNoW (ORCPT + 28 others); Wed, 14 Feb 2018 08:44:22 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:46788 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030398AbeBNNnx (ORCPT ); Wed, 14 Feb 2018 08:43:53 -0500 Received: by mail-wr0-f194.google.com with SMTP id 34so11930126wre.13 for ; Wed, 14 Feb 2018 05:43:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xpoPJpSjmefP/eaP3ikiVrqO/x/qS2dsetdWYBOL7/A=; b=Woyjf2hyrBLeryTnWdKQH1XPJNksSZtGntWrSwKEbI4oplGxntR9R/6iSAz1z6rcEH eQPtpWRE05libxYLfRqrqE5oSyOF44dQasmD9agj9JSux/cONYnbuBZIr9kv+z+Gnn71 UYt25cOENH6xn8on3ZCUHOEdmBasrKunZ93z0MeqW1yknZiuhjRiFtSPOshHcSTSziHv bz2bs/qtMv+leTrgBaM454iJD46qPkuLJXvtghXhqJfRra2dUGsIk1ObydLfTnRXSs21 qbQgPOlRAtr/HQubh8Fmw30sSRPOMABXNtf/mC6WseqJlzjR3pgeJd6BB9TolV7I35mO 49KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xpoPJpSjmefP/eaP3ikiVrqO/x/qS2dsetdWYBOL7/A=; b=LADTOYSLnGKuJMcBRVhPXs3DTY3aTxmbiwIg3n435pzKBCzMMDClG0+E+9YD4feltX +8ZPgiDuu5ZbEehv0M/3E+LJclc04SGmFaG7S8/K9WWqXQ16qnB9k51yXY4Yy57k9ycQ 44DeN7mK/NnmH0bMj4UFkNNwh8nrI/6NDem197QOeSI/4mmlEm1m6/jkHU2DS5Gig2iZ MrIj8DoLE5N3OlmgDBTo1h+wzax91b7mgkM4aDUq7lz034pgmlyHSmjnNWb6RoHYapdH ptAS5GgppHSL733rX/PI+YjrcWmg8PsZynGlxHz8Y/n0V84XGQ4TB1ndEnDYnOld2eeW 1dyA== X-Gm-Message-State: APf1xPDKIPVKIiBDGiu0XG06vb/+WvGJF7QsQ/h5tY4svludUaz7t2QY 6eMZAvnQP0jO2h4nOdf3xmpasg== X-Received: by 10.223.159.77 with SMTP id f13mr4521216wrg.196.1518615832402; Wed, 14 Feb 2018 05:43:52 -0800 (PST) Received: from boomer.lan (cag06-3-82-243-161-21.fbx.proxad.net. [82.243.161.21]) by smtp.googlemail.com with ESMTPSA id k5sm6337694wmg.47.2018.02.14.05.43.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Feb 2018 05:43:51 -0800 (PST) From: Jerome Brunet To: Michael Turquette , Stephen Boyd Cc: Jerome Brunet , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 7/8] clk: divider: read-only divider can propagate rate change Date: Wed, 14 Feb 2018 14:43:39 +0100 Message-Id: <20180214134340.17242-8-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180214134340.17242-1-jbrunet@baylibre.com> References: <20180214134340.17242-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When a divider clock has CLK_DIVIDER_READ_ONLY set, it means that the register shall be left un-touched, but it does not mean the clock should stop rate propagation if CLK_SET_RATE_PARENT is set This is properly handled in qcom clk-regmap-divider but it was not in the generic divider To fix this situation, introduce a new helper function divider_ro_round_rate, on the same model as divider_round_rate. Fixes: e6d5e7d90be9 ("clk-divider: Fix READ_ONLY when divider > 1") Signed-off-by: Jerome Brunet --- drivers/clk/clk-divider.c | 36 ++++++++++++++++++++++++++++++------ include/linux/clk-provider.h | 15 +++++++++++++++ 2 files changed, 45 insertions(+), 6 deletions(-) -- 2.14.3 Tested-By: David Lechner diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c index 3c98d2650fa3..b6234a5da12d 100644 --- a/drivers/clk/clk-divider.c +++ b/drivers/clk/clk-divider.c @@ -342,19 +342,43 @@ long divider_round_rate_parent(struct clk_hw *hw, struct clk_hw *parent, } EXPORT_SYMBOL_GPL(divider_round_rate_parent); +long divider_ro_round_rate_parent(struct clk_hw *hw, struct clk_hw *parent, + unsigned long rate, unsigned long *prate, + const struct clk_div_table *table, u8 width, + unsigned long flags, unsigned int val) +{ + int div; + + div = _get_div(table, val, flags, width); + + /* Even a read-only clock can propagate a rate change */ + if (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) { + if (!parent) + return -EINVAL; + + *prate = clk_hw_round_rate(parent, rate * div); + } + + return DIV_ROUND_UP_ULL((u64)*prate, div); +} +EXPORT_SYMBOL_GPL(divider_ro_round_rate_parent); + + static long clk_divider_round_rate(struct clk_hw *hw, unsigned long rate, unsigned long *prate) { struct clk_divider *divider = to_clk_divider(hw); - int bestdiv; /* if read only, just return current value */ if (divider->flags & CLK_DIVIDER_READ_ONLY) { - bestdiv = clk_readl(divider->reg) >> divider->shift; - bestdiv &= clk_div_mask(divider->width); - bestdiv = _get_div(divider->table, bestdiv, divider->flags, - divider->width); - return DIV_ROUND_UP_ULL((u64)*prate, bestdiv); + u32 val; + + val = clk_readl(divider->reg) >> divider->shift; + val &= clk_div_mask(divider->width); + + return divider_ro_round_rate(hw, rate, prate, divider->table, + divider->width, divider->flags, + val); } return divider_round_rate(hw, rate, prate, divider->table, diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h index cb18526d69cb..210a890008f9 100644 --- a/include/linux/clk-provider.h +++ b/include/linux/clk-provider.h @@ -420,6 +420,10 @@ long divider_round_rate_parent(struct clk_hw *hw, struct clk_hw *parent, unsigned long rate, unsigned long *prate, const struct clk_div_table *table, u8 width, unsigned long flags); +long divider_ro_round_rate_parent(struct clk_hw *hw, struct clk_hw *parent, + unsigned long rate, unsigned long *prate, + const struct clk_div_table *table, u8 width, + unsigned long flags, unsigned int val); int divider_get_val(unsigned long rate, unsigned long parent_rate, const struct clk_div_table *table, u8 width, unsigned long flags); @@ -780,6 +784,17 @@ static inline long divider_round_rate(struct clk_hw *hw, unsigned long rate, rate, prate, table, width, flags); } +static inline long divider_ro_round_rate(struct clk_hw *hw, unsigned long rate, + unsigned long *prate, + const struct clk_div_table *table, + u8 width, unsigned long flags, + unsigned int val) +{ + return divider_ro_round_rate_parent(hw, clk_hw_get_parent(hw), + rate, prate, table, width, flags, + val); +} + /* * FIXME clock api without lock protection */