From patchwork Mon Mar 19 15:55:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 132093 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp101907ljb; Mon, 19 Mar 2018 15:05:12 -0700 (PDT) X-Google-Smtp-Source: AG47ELugZ4ZM6Zw8Obtz833YdDYj+Vs9/aJIyUlVDUIomVm9pFncuhQc9cE4SvOR0cSIzFUaMyTZ X-Received: by 10.99.121.131 with SMTP id u125mr10299894pgc.263.1521497112106; Mon, 19 Mar 2018 15:05:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521497112; cv=none; d=google.com; s=arc-20160816; b=KNeb0Hu9anaNL2lRp7WX6haLgEvEsCyJDvYyp8lDc0BzKq1UWR1vr+83Pew7IlnRI0 dnI5yOjFCuCdiC9j9QMg4CdLnIBYDp0e2ZaDvFxJiVcRy6xgdHYG0vYsqlhTz1AADGNA 2GopfOTyv3AeBmcsN8Kc9LLzZtjfRwiuItyPdkFyjmPMrx4cGX1dw5aITeYDYMwzAkBO HJtSLJhVXvUQuUEx5NW8jKcHPITUxNOdG9jf5UfeqwmTVbPhLOL0XpJIMzYfQutTC2ph I5iaIQGDUjsqMf49xAVh1o+VSzsT3+VLvOhfvAbBe8irE55v6Izk/fjJQTTuQdETQ/Xb S4tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=98Eu7yEWcyxNDBxcz6PwfJ8/H4xrNu7mYMwFZo8uayo=; b=roI3Fym7ma/Muu38osCsEiHnRiPLsxbKUXm9nklEk2+xRGP3GNNoTn9h9ZftJd/wkR lnEGTmJmTJbKMzZIC70fI6nfTBdUXo/Hp9vqfHYB0tLGfkmE083+7jVFG9WZiize6eLx 18rpXNqfCyJhhFuUhcSRMOF5WZKaAyfnN7CDGBiJnFazW94zqXaTs92TQOKF2KSNMN31 6TnjGivnAc3lj2ELU4Y7BxFOalrsPpMKRqNclVrWmZoPPCNvAhNljRuqsbwev6tt7p1Q IiCjUYa8ahT7Skq4A/iObb6HGpeH9YLZ0WbIwlRFW+eh0VLayjbyhPbF2eXa8Nogs1uN 2UBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=nMavLIuM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c27si147876pgn.223.2018.03.19.15.05.11; Mon, 19 Mar 2018 15:05:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=nMavLIuM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936260AbeCSWFI (ORCPT + 28 others); Mon, 19 Mar 2018 18:05:08 -0400 Received: from mail-by2nam03on0129.outbound.protection.outlook.com ([104.47.42.129]:43956 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933827AbeCSPzq (ORCPT ); Mon, 19 Mar 2018 11:55:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=98Eu7yEWcyxNDBxcz6PwfJ8/H4xrNu7mYMwFZo8uayo=; b=nMavLIuM+l6dqtMDymfVNIo+D0AFEASs4SyiwBMdkwla3zieJX4ZaU+o3DR0KS+UqtPvfbk/j1W5pfrC4NsY8r5SyZf1ZWN2vTkVTLbORxOpf8v9EV8e6mGZO4lRmZd5QUk4RL4LwjMW9wRXeU3wFh089ArqyfInvEJeUbKVhS0= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB0967.namprd21.prod.outlook.com (52.132.133.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.631.0; Mon, 19 Mar 2018 15:55:43 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::3d9b:79e7:94eb:5d62]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::3d9b:79e7:94eb:5d62%5]) with mapi id 15.20.0631.004; Mon, 19 Mar 2018 15:55:43 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Linus Walleij , "Reported-by : Jason Kridner" , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 39/97] gpio: label descriptors using the device name Thread-Topic: [PATCH AUTOSEL for 4.14 39/97] gpio: label descriptors using the device name Thread-Index: AQHTv5qsAN2EbUV2qUyg6Fm0yT2hNQ== Date: Mon, 19 Mar 2018 15:55:15 +0000 Message-ID: <20180319155411.12348-39-alexander.levin@microsoft.com> References: <20180319155411.12348-1-alexander.levin@microsoft.com> In-Reply-To: <20180319155411.12348-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB0967; 7:aDoYkd8Y2ZNbaq6gBIDRpCdoy4n0Dkcsk9bjCwjJxa+1x6Uz7TnzAcpNVZkVsONOW35onlBV4X7HfZeuA+KQ/1DSx/Yen9OdinLsevq/d1PhTws9vZlgx7kyYAzTTzUK+I2d2P2QdO8zMzYsl/UQJAfZqu9G3xExOrsjoneo+4r4ukgc+VTer9q7ilkrcKNOQwr1UxNK/Bzhs3BrOpdjaR+z54/PutDcNjWR+fS48q5pbLxsiepv0mUy6aEUIYKW; 20:oFLgT5/VR1VuWEV/nQl24bgNzMU+M5Fa8VhMM6Cejxz9IAEx5tf7obRDTXwQXyghQ4jQ6cO1uBKooMMJJqcB66IDUd6O+EYsNehAt8F6sQ6Ga1nonFH21NBd9XZvHePmwjnLQZAAitbTWs8ANNIXoNY5M7nrmUOJa0MJHGa2lnw= x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: bd3a3c16-2c44-4b20-5a99-08d58db1df48 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020); SRVR:DM5PR2101MB0967; x-ms-traffictypediagnostic: DM5PR2101MB0967: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501300)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(61426038)(61427038)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:DM5PR2101MB0967; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB0967; x-forefront-prvs: 06167FAD59 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(39380400002)(376002)(39860400002)(366004)(346002)(189003)(199004)(54906003)(59450400001)(10090500001)(110136005)(5250100002)(2501003)(1076002)(6116002)(3846002)(2900100001)(99286004)(22452003)(3280700002)(186003)(2906002)(76176011)(86612001)(26005)(6486002)(10290500003)(102836004)(14454004)(36756003)(68736007)(3660700001)(72206003)(478600001)(107886003)(106356001)(53936002)(6506007)(6512007)(6436002)(86362001)(105586002)(316002)(7736002)(4326008)(305945005)(66066001)(81156014)(81166006)(5660300001)(97736004)(8936002)(25786009)(8676002)(2950100002)(6666003)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB0967; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 54QvOL5u4xLWEZEllP2rC/OqyfY07Yjm3RwxYlznmoYm28AYAOR6g9WkR1nO2uuXN+JXMx5ZSBRKO2zk6oMG/92h0bPrMnEQwbconv4wca2yudZGQzyd9ul188juM0SF9VicgojD5LSXkRaqUfpm+J+qkaavZZTuuUcmEkaYwXvJlvigVBnwk92FFTbNCUWsLnVmhO7oqxt107R1k2SnQQ1i/DfIDOM3LdtY0hY+QJi2enR465GBHVATkaraca7MxX5qq0uP5483jsnUOaiG6TMPUdel7v/iG4iPuz+OZeGd12PLNGakv8YVdrjUmhQgymIu+/NpAskaHiHExLScvw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd3a3c16-2c44-4b20-5a99-08d58db1df48 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2018 15:55:15.9653 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0967 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linus Walleij [ Upstream commit 24e78079bf2250874e33da2e7cfbb6db72d3caf4 ] Some GPIO lines appear named "?" in the lsgpio dump due to their requesting drivers not passing a reasonable label. Most typically this happens if a device tree node just defines gpios = <...> and not foo-gpios = <...>, the former gets named "foo" and the latter gets named "?". However the struct device passed in is always valid so let's just label the GPIO with dev_name() on the device if no proper label was passed. Cc: Reported-by: Jason Kridner Reported-by: Jason Kridner Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/gpio/gpiolib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.14.1 diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index bdd68ff197dc..b4c8b25453a6 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -3340,7 +3340,8 @@ struct gpio_desc *__must_check gpiod_get_index(struct device *dev, return desc; } - status = gpiod_request(desc, con_id); + /* If a connection label was passed use that, else use the device name as label */ + status = gpiod_request(desc, con_id ? con_id : dev_name(dev)); if (status < 0) return ERR_PTR(status);