From patchwork Wed Mar 28 09:51:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Escande X-Patchwork-Id: 132517 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp254147ljb; Wed, 28 Mar 2018 02:52:17 -0700 (PDT) X-Google-Smtp-Source: AIpwx48EhFgjW22/FaGD6bI2Ij6y0Um6fYI/uypld5SnDrEBu4oVcm6j3j7d/n+T5IsyhJQb7oUu X-Received: by 10.101.81.75 with SMTP id g11mr2066607pgq.143.1522230737080; Wed, 28 Mar 2018 02:52:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522230737; cv=none; d=google.com; s=arc-20160816; b=QkUUFyYyuFZf4zr9u7RcDSJuc4XfmjxxxjSG/3d8YYt13f1eEw7hfIHW7Muc9lbsSw cFCUSNTjb7IAVcUN27vbjSfUNDvc/mU7WqEojjS9uGrDvkYtPJzq/kdpnxLy1Aibg/bf Z+LfXp5QxKbAUpD2abqI4XmVOFv2nz5tmRNmds58nSMYU7BBznfeQqPkz/QiJt2+eTWV 4I0BIRqyie1beAX9BtLM1ZN2mmdT3p7pU7OPqTyjxVCWDgWcTXi5pV8X+Jsv+sXZIajw lCxxO2njgRMh19b3oRk6cXa2IuR3jZCFddTlGdwaMHW8OInJBrxj536M831uG/GvSzzJ wJKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfert-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=EbTg1kjwC8/UrdHMhnBc7OfvRhjZouqhKnJ+9hkddP4=; b=btkRVXVhRP78KqozjcOvxEtaODLyjtgmnxdx+Jb/LM1JnhrrkfIa/c9NPsxTxf1QeL LLwxx3ELiQysiBHiyrwcGg07mG6WxptDpN8W1o0stN/P5ppiWUcv8DJwN4knE34pLikw PBIbfeQa9tY/hpaepR+AXmST9dTVat6MJRwumm9XWGy5QGwucBCuNyiuYAzIWAcuY5hH Uv5engYHv1tPE/R12hJw+YHBTOoFOQOcQ09Vssircm3aZtdokzAW8SskTNkq2dBXH31N 4s0SvN/wT92G59GenIbiaaG9QYytAQxL5Ex2CB27Vy+FTkd4XMc1OR5ImZOSBIaIjO12 cmlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fidzgl/k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e6si2204460pgt.442.2018.03.28.02.52.16; Wed, 28 Mar 2018 02:52:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fidzgl/k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752753AbeC1JwP (ORCPT + 28 others); Wed, 28 Mar 2018 05:52:15 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33338 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752689AbeC1JwA (ORCPT ); Wed, 28 Mar 2018 05:52:00 -0400 Received: by mail-wm0-f68.google.com with SMTP id o23so13326790wmf.0 for ; Wed, 28 Mar 2018 02:51:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfert-encoding; bh=EbTg1kjwC8/UrdHMhnBc7OfvRhjZouqhKnJ+9hkddP4=; b=fidzgl/khxmhTXbf+ocqxb2hWmLv3Q6i7723ay5KLnT5CrjKM6Ue26okUjB+WqoONb WLFMGnvwp3zw/FJMAjG8158caQbmrALYLSMSn3eDZHk/l5W9pkWMdP1DkW6Ip/aoqQNU zO8yX7vERKmG6pXOt0bhRRyyvnilFQLQ8aLQQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfert-encoding; bh=EbTg1kjwC8/UrdHMhnBc7OfvRhjZouqhKnJ+9hkddP4=; b=Oa4nA2OgCnCDTPpIpZ37I84fjeQU8syY5lyUdEUVvH2TfgpUIh//YBbUsxg5GDkcZL s8dyeAXosjCxDSuYlJ2eFBAGC76m9yOUYiqdabKAEXgGh8oL9oM8K9UyL55QpmKiUT8K n5riVldsFllSCaweK4eoxyQnT4ohe08UND/MNi9+ni+ewX513t0rvsHza/15xXiah7jc PyiBgqi2CYS/+u0KdKssoP9glEQVVgbMW5xPN0JKrqMYe8KRNAVB/NJeMkTrYGiW8691 er59ORkmB6+gpzCcRWVP8HX7rQ7uAIZccStRBmxxLIOpB1RuzDj8jHZE7OJreKcvBqze xm3w== X-Gm-Message-State: AElRT7GfZ8Io034vVNR1N+1mJwUzG3VlOeHk02FidGfYflK+ATnV1a38 2pYVvqvKNNEvYfmmPwJHELGijA== X-Received: by 10.28.109.131 with SMTP id b3mr1883191wmi.145.1522230718996; Wed, 28 Mar 2018 02:51:58 -0700 (PDT) Received: from localhost.localdomain (aig34-1-88-167-228-121.fbx.proxad.net. [88.167.228.121]) by smtp.gmail.com with ESMTPSA id d9sm7285992wmh.38.2018.03.28.02.51.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Mar 2018 02:51:58 -0700 (PDT) From: Thierry Escande To: Rob Herring , Andy Gross , Marcel Holtmann , Johan Hedberg , David Brown , Mark Rutland Cc: Andy Shevchenko , Loic Poulain , Bjorn Andersson , Srinivas Kandagatla , linux-bluetooth@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 3/3] Bluetooth: hci_qca: Add serdev support Date: Wed, 28 Mar 2018 11:51:33 +0200 Message-Id: <20180328095133.14343-4-thierry.escande@linaro.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180328095133.14343-1-thierry.escande@linaro.org> References: <20180328095133.14343-1-thierry.escande@linaro.org> MIME-Version: 1.0 Content-Transfert-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add support for Qualcomm serial slave devices. Probe the serial device, retrieve its maximum speed and register a new hci uart device. Signed-off-by: Thierry Escande Reviewed-by: Andy Shevchenko --- v6: - Fix gpio name in error message v5: - Use gpio new name 'enable' v4: - Rename divclk4 as susclk (its name in the bt chip) - Use gpiod_set_value_cansleep() - Replace #include with - Restore dependency on BT_HCIUART v3: - Remove redundant call to gpiod_set_value() after devm_gpiod_get() - Check returned values for clk_set_rate() and clk_prepare_enable() - Use clk_disable_unprepare() v2: - Fix author email drivers/bluetooth/Kconfig | 1 + drivers/bluetooth/hci_qca.c | 109 +++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 108 insertions(+), 2 deletions(-) -- 2.14.1 diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig index 07e55cd8f8c8..e0f1a6609b68 100644 --- a/drivers/bluetooth/Kconfig +++ b/drivers/bluetooth/Kconfig @@ -196,6 +196,7 @@ config BT_HCIUART_BCM config BT_HCIUART_QCA bool "Qualcomm Atheros protocol support" depends on BT_HCIUART + depends on BT_HCIUART_SERDEV select BT_HCIUART_H4 select BT_QCA help diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 05ec530b8a3a..1c4475d0707c 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -29,7 +29,11 @@ */ #include +#include #include +#include +#include +#include #include #include @@ -50,6 +54,9 @@ #define IBS_TX_IDLE_TIMEOUT_MS 2000 #define BAUDRATE_SETTLE_TIMEOUT_MS 300 +/* susclk rate */ +#define SUSCLK_RATE_32KHZ 32768 + /* HCI_IBS transmit side sleep protocol states */ enum tx_ibs_states { HCI_IBS_TX_ASLEEP, @@ -111,6 +118,12 @@ struct qca_data { u64 votes_off; }; +struct qca_serdev { + struct hci_uart serdev_hu; + struct gpio_desc *bt_en; + struct clk *susclk; +}; + static void __serial_clock_on(struct tty_struct *tty) { /* TODO: Some chipset requires to enable UART clock on client @@ -386,6 +399,7 @@ static void hci_ibs_wake_retrans_timeout(struct timer_list *t) /* Initialize protocol */ static int qca_open(struct hci_uart *hu) { + struct qca_serdev *qcadev; struct qca_data *qca; BT_DBG("hu %p qca_open", hu); @@ -444,6 +458,13 @@ static int qca_open(struct hci_uart *hu) timer_setup(&qca->tx_idle_timer, hci_ibs_tx_idle_timeout, 0); qca->tx_idle_delay = IBS_TX_IDLE_TIMEOUT_MS; + if (hu->serdev) { + serdev_device_open(hu->serdev); + + qcadev = serdev_device_get_drvdata(hu->serdev); + gpiod_set_value_cansleep(qcadev->bt_en, 1); + } + BT_DBG("HCI_UART_QCA open, tx_idle_delay=%u, wake_retrans=%u", qca->tx_idle_delay, qca->wake_retrans); @@ -512,6 +533,7 @@ static int qca_flush(struct hci_uart *hu) /* Close protocol */ static int qca_close(struct hci_uart *hu) { + struct qca_serdev *qcadev; struct qca_data *qca = hu->priv; BT_DBG("hu %p qca close", hu); @@ -525,6 +547,13 @@ static int qca_close(struct hci_uart *hu) destroy_workqueue(qca->workqueue); qca->hu = NULL; + if (hu->serdev) { + serdev_device_close(hu->serdev); + + qcadev = serdev_device_get_drvdata(hu->serdev); + gpiod_set_value_cansleep(qcadev->bt_en, 0); + } + kfree_skb(qca->rx_skb); hu->priv = NULL; @@ -885,6 +914,14 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate) return 0; } +static inline void host_set_baudrate(struct hci_uart *hu, unsigned int speed) +{ + if (hu->serdev) + serdev_device_set_baudrate(hu->serdev, speed); + else + hci_uart_set_baudrate(hu, speed); +} + static int qca_setup(struct hci_uart *hu) { struct hci_dev *hdev = hu->hdev; @@ -905,7 +942,7 @@ static int qca_setup(struct hci_uart *hu) speed = hu->proto->init_speed; if (speed) - hci_uart_set_baudrate(hu, speed); + host_set_baudrate(hu, speed); /* Setup user speed if needed */ speed = 0; @@ -924,7 +961,7 @@ static int qca_setup(struct hci_uart *hu) ret); return ret; } - hci_uart_set_baudrate(hu, speed); + host_set_baudrate(hu, speed); } /* Setup patch / NVM configurations */ @@ -958,12 +995,80 @@ static struct hci_uart_proto qca_proto = { .dequeue = qca_dequeue, }; +static int qca_serdev_probe(struct serdev_device *serdev) +{ + struct qca_serdev *qcadev; + int err; + + qcadev = devm_kzalloc(&serdev->dev, sizeof(*qcadev), GFP_KERNEL); + if (!qcadev) + return -ENOMEM; + + qcadev->serdev_hu.serdev = serdev; + serdev_device_set_drvdata(serdev, qcadev); + + qcadev->bt_en = devm_gpiod_get(&serdev->dev, "enable", + GPIOD_OUT_LOW); + if (IS_ERR(qcadev->bt_en)) { + dev_err(&serdev->dev, "failed to acquire enable gpio\n"); + return PTR_ERR(qcadev->bt_en); + } + + qcadev->susclk = devm_clk_get(&serdev->dev, NULL); + if (IS_ERR(qcadev->susclk)) { + dev_err(&serdev->dev, "failed to acquire clk\n"); + return PTR_ERR(qcadev->susclk); + } + + err = clk_set_rate(qcadev->susclk, SUSCLK_RATE_32KHZ); + if (err) + return err; + + err = clk_prepare_enable(qcadev->susclk); + if (err) + return err; + + err = hci_uart_register_device(&qcadev->serdev_hu, &qca_proto); + if (err) + clk_disable_unprepare(qcadev->susclk); + + return err; +} + +static void qca_serdev_remove(struct serdev_device *serdev) +{ + struct qca_serdev *qcadev = serdev_device_get_drvdata(serdev); + + hci_uart_unregister_device(&qcadev->serdev_hu); + + clk_disable_unprepare(qcadev->susclk); +} + +static const struct of_device_id qca_bluetooth_of_match[] = { + { .compatible = "qcom,qca6174-bt" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, qca_bluetooth_of_match); + +static struct serdev_device_driver qca_serdev_driver = { + .probe = qca_serdev_probe, + .remove = qca_serdev_remove, + .driver = { + .name = "hci_uart_qca", + .of_match_table = qca_bluetooth_of_match, + }, +}; + int __init qca_init(void) { + serdev_device_driver_register(&qca_serdev_driver); + return hci_uart_register_proto(&qca_proto); } int __exit qca_deinit(void) { + serdev_device_driver_unregister(&qca_serdev_driver); + return hci_uart_unregister_proto(&qca_proto); }