From patchwork Tue May 29 09:41:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 137130 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp3826905lji; Tue, 29 May 2018 02:42:37 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLg/fhb5bE744ofAXsdxJTC6eP25zDLxojS7vueXlC/F/2luDL0YJNuSKonsieIl0jdVyBc X-Received: by 2002:a17:902:b483:: with SMTP id y3-v6mr12202379plr.66.1527586957094; Tue, 29 May 2018 02:42:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527586957; cv=none; d=google.com; s=arc-20160816; b=ZBiWh0B7n4ijoVeEPBZLPxTXhE8ISUYnDCVM4F3dJJSMpWuOUMV+devQn+puyOLhj0 cTfJn8SJo/3t+UY1jy4Yof/HE4CYEslMex7F85ZE5G/FYXJkSMTxEA7YBdVn/vHmmGgY FvN42Wb//19Bd+uq8mQogBmX1M0Sdjw6YYw1FTpyQWEfUriyQrBYvPn205AstohEXGXy 9q8WriR4n31gm3Pi9ZwD9vezM5QdtAdWSSOehyElqljSYq1euX8zUQtlVRvBtExE8WZK uCbwcLO3boKNXw43X0bH2drlWOLKa+/saxKDGEm7F9+kqm0n4IQ8T1nTFXuvrsjd5Wxn YW0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=WRv30aMfZzvQpX5KyCXX1FujFxTHI3whluZA4GXDL58=; b=a+F5NFCWA2yvBbvLWcxZUTn1/gqwchcur5PkBNGp38NQa+f2VL/mhhitvT+t/KSQ/1 FDTk+U4w2rUYj3zg0zUuQWYqFkGBDNsvFV2xE3m2ZF0RHMGhH9Nc/qEA9DdWiaLD/VBu WEn5W9/irB63CphYYYbaDeOwcqYKdeESxQ3O6gOG0rXY/2T+w9ckz9M8zZ0T1YOJacCg YDat8n5BY6ruXE4/Oqs0RNCvtJlQpNA0rRJikvkzC/sDCt3/ccUgVTvBl0Ua6bzRHLQE r8BGlXYNVs7cwGelE89z19UPv3XzG6fl5ijlnaTGfuzaTNwKAeVWPhFFoASJ04DWarb8 v0rA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g12-v6si33051966pfm.258.2018.05.29.02.42.36; Tue, 29 May 2018 02:42:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932563AbeE2Jme (ORCPT + 30 others); Tue, 29 May 2018 05:42:34 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:43221 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932354AbeE2Jma (ORCPT ); Tue, 29 May 2018 05:42:30 -0400 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue007 [212.227.15.129]) with ESMTPA (Nemesis) id 0MGsxZ-1faVQf16XZ-00DboJ; Tue, 29 May 2018 11:42:08 +0200 From: Arnd Bergmann To: Lorenzo Pieralisi , Bjorn Helgaas Cc: Arnd Bergmann , Ryder Lee , Cyrille Pitchen , Shawn Lin , Rob Herring , Marc Gonzalez , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pci: mvebu: add MVEBU_MBUS dependency Date: Tue, 29 May 2018 11:41:51 +0200 Message-Id: <20180529094204.3945660-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:sR3iNluZSWEI52q+/OiRhj9MGoP3MUR5Zx0BiGB7p+MgiaUra4d cPb4IafqASGm2cnqwMmPOnGS7XOtMJrForIo+8OhC7wRMXo6m8HbJEtb5Ktfu01qhnL/HiA dSmrCWD2l7PDFtlesyZCC51eXmOgexE7V6uvjbvMLZOQt9AYs/w5knTvitfC4fNqBx0vj1o jVOCVnaJmrdizMfbuzq6g== X-UI-Out-Filterresults: notjunk:1; V01:K0:/ucZw6WphFw=:4rGQA28B3ltN0YIYNzKwrI ZHwOi+dci0T5NF967NUMKszuuxhkCEXIUXu97tQ6j5i2/bHFabtO6FkOc2MRozO8WFUSffqcG jvAsRe4L8hjmTEYUVBuTYD8pRA8EpKoDGUO9djZVjbM2C9U5Prqr4g78rXOrTUGiwVBuxZp7H iBpEyAIwiP9ex3P/imzDFjEKHses51wvSxj/sAv0V/iFEcdR13HwceFEhKG0cSFbOGJINnabD CaaPBlD1Bzn4RGIO/U5UXayc5jYj1TZFOnX5UnCODT67lelWlVnEzw+8jm+aVIkfvTrE4G+C0 2QPSzU4ciRizQzqF9UL2QYUBb8KExVXl60pC1jH1jS+73/97FZccAYUWHwUmIkzqDBy+OGH4p rL0nx2wFCOLk5rWs37BG7f3WdJaSWAbQBErVMUyT8IWSpLNQQwxxJoL1zooTAcxMDw/D3zy+U YOtdPurVi0M+PQd7lyo9CQSlGpZtQsYgwaaP14RTeNR7stgzqXELo++i0eG3pcgr4qglM4PPC McOmwuyiw7HTAAtuMK96bUPzpti7xibrM3dOX/8Fg38FctmEMXn8TwWAyshKh493BghiWXixz SD/9xu4ca8xRXgkN780O5X5r3sXsWMYR/8eDYWuc1JpvEwKdGMaPbL2Pn/r7LmPForO0pPshb hCqoiBiz8rH13D4bsF3pNutiPZCxD+KSxSQVbGGm+7AED5brgIYeemYXUAFndlNIBK/k= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Enabling the PCI_MVEBU driver for compile testing caused a build failure on ARM randconfig builds: drivers/pci/host/pci-mvebu.c: In function 'mvebu_pcie_del_windows': drivers/pci/host/pci-mvebu.c:341:3: error: implicit declaration of function 'mvebu_mbus_del_window'; did you mean 'mvebu_pcie_del_windows'? [-Werror=implicit-function-declaration] mvebu_mbus_del_window(base, sz); ^~~~~~~~~~~~~~~~~~~~~ mvebu_pcie_del_windows drivers/pci/host/pci-mvebu.c: In function 'mvebu_pcie_add_windows': drivers/pci/host/pci-mvebu.c:364:9: error: implicit declaration of function 'mvebu_mbus_add_window_remap_by_id'; did you mean 'mvebu_pcie_add_windows'? [-Werror=implicit-function-declaration] ret = mvebu_mbus_add_window_remap_by_id(target, attribute, base, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ mvebu_pcie_add_windows drivers/pci/host/pci-mvebu.c: In function 'mvebu_pcie_probe': drivers/pci/host/pci-mvebu.c:1209:2: error: implicit declaration of function 'mvebu_mbus_get_pcie_mem_aperture'; did you mean 'mvebu_mbus_get_io_win_info'? [-Werror=implicit-function-declaration] drivers/pci/host/pci-mvebu.c:1215:2: error: implicit declaration of function 'mvebu_mbus_get_pcie_io_aperture'; did you mean 'mvebu_mbus_get_io_win_info'? [-Werror=implicit-function-declaration] The problem is that the mbus helper functions are not declared in the header. There are two ways of solving this: we can change the header to provide empty stub functions for CONFIG_MVEBU_MBUS=n, or we can add back the dependency here. I picked the second option since that is simpler, but it somewhat defeats the purpose of the original patch because we still cannot compile test on other platforms this way. Fixes: 51bc085d6454 ("PCI: Improve host drivers compile test coverage") Signed-off-by: Arnd Bergmann --- drivers/pci/host/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 Acked-by: Rob Herring diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig index fa51d0893384..5340950f4b98 100644 --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig @@ -6,6 +6,7 @@ menu "PCI host controller drivers" config PCI_MVEBU bool "Marvell EBU PCIe controller" depends on ARCH_MVEBU || ARCH_DOVE || COMPILE_TEST + depends on MVEBU_MBUS depends on ARM depends on OF