From patchwork Wed Jun 13 12:17:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juri Lelli X-Patchwork-Id: 138448 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp645939lji; Wed, 13 Jun 2018 05:18:35 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJUgpOg7LLxaSECUs7zueOVdMjHcBWOMWuduGN2DEjRBqEToU1QY8PrUaxpN3wsJ9meekJN X-Received: by 2002:a17:902:74cc:: with SMTP id f12-v6mr5024524plt.7.1528892315358; Wed, 13 Jun 2018 05:18:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528892315; cv=none; d=google.com; s=arc-20160816; b=XTDW3MUrUNkpMYPOhX1ld6E+Ern24V0/BvEKaFeWtgZ7xwwZRif49ELL5q04k5xpor gmwFv4JodnSUmSdAppPx7LZJIdqFmky58hXmrhrftP4PEB2wpwvvv+v0AuAMDeAkOVUz b5Yiw90uhWmy2STgC16M0rYVKl4T6C8/LUhD658BlOJjRjv3rwpoVqOYgHRjPPp7eSab 8PWYpSmr34bhokiIGz82YRpomYCYXLsDd7+C68Aayj/o6J6f6qjxvnF51OKJr2KomXE/ Uq5LCXwNOYYLHF4G8XdmfQUQfFIumemnvWH2LaGmH8G/r9QhZd2boeOIw8JhW4eXY9kV yyZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=XRYvMb4AaSuggbLT60uXuONVk/kchUT0e/4Fx3rF52E=; b=r/FAszSkdg1Ms9wOARam5tKnXdjP7zGnA/nQFuAvNnb9U97BHtm7VgN/JJK4ImpGjt owfn9uDSLnKdL2KrJxWaVgoxrXmxmnBYWzZmbrLWNL19n2yUSpr0FPYqYzmNBvgloQ2b a+NbMdsDDZZbbBWo7XAFLd68rWJ37wv1RBkarXcA20BNaMA4vsSpRRKEWXkOtJa5MPQq AoOVcWBXJqwttekVV6LqVrWt9mIJu0e8BAYgPdWRLoQ/CP5T2hz2qKgk2oqV+k71zmCe 0bqTdXT2STonxHODjUyO/ONFSmyWmpvfK+z/l8CKYpnvtoIO3vhJPtRKsEQHW411l6Iq JWEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o5-v6si2306751pgs.303.2018.06.13.05.18.35; Wed, 13 Jun 2018 05:18:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964816AbeFMMSc (ORCPT + 30 others); Wed, 13 Jun 2018 08:18:32 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:39431 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935273AbeFMMR2 (ORCPT ); Wed, 13 Jun 2018 08:17:28 -0400 Received: by mail-wr0-f193.google.com with SMTP id w7-v6so2522688wrn.6 for ; Wed, 13 Jun 2018 05:17:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XRYvMb4AaSuggbLT60uXuONVk/kchUT0e/4Fx3rF52E=; b=aGhFfo57Xc34bVxrE5pg0Y0o3yltYbF1uu5wbEFuWOGvbHYQU8Z8MzgVTDGQs9ofrM rCA8MUCM9gbhxE6JJwCZzkySEqSvXBtoDGkSzw8pCswR+ITa78VUAyDQdxC9UyeyHmpM 9Fuf/BH+vle3KXNEPFTpFcKoHe+lgw994tDcsEuNW+k4AczFYjZ4LrDBd1jdju6rvuBh Q/4q6NaV0etYgxDESjBF41Pl8KUVvUXCKfPBNXxlDAWXjYOL4udwWK2yQ30uFsssGqZG SK/ojpTpCI9rxEYScC+b59fp8tx9VFbrkDYKqAsedgqfTcuuGIR5b2xpRaSiaVWjJT2q xCHQ== X-Gm-Message-State: APt69E0VXekRBpqv1eDj1LoesdxeOBaUe/03FZqIR+LhkeSkehuZ1Rz+ Yl7E8tWFZ6m0xON5AHHK3bqaLA== X-Received: by 2002:adf:9405:: with SMTP id 5-v6mr4351936wrq.283.1528892247561; Wed, 13 Jun 2018 05:17:27 -0700 (PDT) Received: from localhost.localdomain.com ([151.15.207.242]) by smtp.gmail.com with ESMTPSA id 137-v6sm4943673wmv.28.2018.06.13.05.17.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Jun 2018 05:17:26 -0700 (PDT) From: Juri Lelli To: peterz@infradead.org, mingo@redhat.com, rostedt@goodmis.org Cc: linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it, claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it, bristot@redhat.com, mathieu.poirier@linaro.org, lizefan@huawei.com, cgroups@vger.kernel.org, Juri Lelli Subject: [PATCH v4 1/5] sched/topology: Add check to backup comment about hotplug lock Date: Wed, 13 Jun 2018 14:17:07 +0200 Message-Id: <20180613121711.5018-2-juri.lelli@redhat.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180613121711.5018-1-juri.lelli@redhat.com> References: <20180613121711.5018-1-juri.lelli@redhat.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mathieu Poirier The comment above function partition_sched_domains() clearly state that the cpu_hotplug_lock should be held but doesn't mandate one to abide to it. Add an explicit check backing that comment, so to make it impossible for anyone to miss the requirement. Suggested-by: Juri Lelli Signed-off-by: Mathieu Poirier [modified changelog] Signed-off-by: Juri Lelli --- kernel/sched/topology.c | 1 + 1 file changed, 1 insertion(+) -- 2.14.3 Reviewed-by: Steven Rostedt (VMware) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 61a1125c1ae4..96eee22fafe8 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -1858,6 +1858,7 @@ void partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[], int i, j, n; int new_topology; + lockdep_assert_cpus_held(); mutex_lock(&sched_domains_mutex); /* Always unregister in case we don't destroy any domains: */