From patchwork Mon Jun 18 10:05:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 138867 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp3757388lji; Mon, 18 Jun 2018 03:05:47 -0700 (PDT) X-Google-Smtp-Source: ADUXVKI9OWPCLaoc4uC1csmsH+9pQQM24CBKUaLjf80mUbJXqgO9VxUmj+1GDEjHpJKUHOXhSa4U X-Received: by 2002:a17:902:bc4a:: with SMTP id t10-v6mr13260055plz.133.1529316347570; Mon, 18 Jun 2018 03:05:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529316347; cv=none; d=google.com; s=arc-20160816; b=sAfQk+1woAE6hP+csFYDtEDq4F791s+dEkRxY31714y1VGu0PkZX9RM28UY6K/CwuC DD8yAnNDsezMnoESLsOgeN/TC3q6WHQoJaDP5DVr80IGSRtySh/ncqzJT5NMvVi3kLJc R6Df6DSDOX+GEa3uCVCgEzFBS6BIsg7WFNf7BWZe6YxPaBNQneRqWyjzxhkppAwVG2fE PDQ8sZneTsXtVvzlN6gg2J0pIqAEPz9ViBgGTxrwk0/OLGaNtWdC04tSg6AXMXEVSnIz X/0LhpTOKtzKeXRs3UhAHT576QMh6cjLUVOS2HUYnLlN7NnOhA/hsWb964sqxIJSuXmo vkxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=AE7VDyO0VjsKTWsPfbRXO6NOE5GJ/GLVN7+fpn+vgLw=; b=V0xSrea/85Csnym2wJuO0K67M+8K6KdTngGiKGInepdqADO9V7WUz7eSI2Th6qG9v6 dfjrUcxb34xIbbLncXhUfQsETg/lPsf3ysiJvUOQHZdxEGPIGmuvIXMVa5W+FLtJxw2q Z4rsXyylqvpCb4eDmzjsK9XkvgU4iMMzp1YD+tcOvEljUWOE7tnuWc2WyJKMsh9Ok4k+ 9Yk6ZvuNu9yXLEoo5lddUw5VhnvUl1ysToS4f0Q3GspFc7qULQ2hB8EAybRUzLbcH5aD bJKyQ2BnJzGJAqfvPudqxLfBDBDXaOef8ppZcO09LI4EqW+73Q7swN8kgazrFVdozuFs 5blg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q6-v6si14998203plr.134.2018.06.18.03.05.47; Mon, 18 Jun 2018 03:05:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935403AbeFRKFp (ORCPT + 30 others); Mon, 18 Jun 2018 06:05:45 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:60451 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934927AbeFRKFm (ORCPT ); Mon, 18 Jun 2018 06:05:42 -0400 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue006 [212.227.15.129]) with ESMTPA (Nemesis) id 0MKxUa-1fUr2X3oDg-0007HR; Mon, 18 Jun 2018 12:05:38 +0200 From: Arnd Bergmann To: Martin Schwidefsky , Heiko Carstens Cc: y2038@lists.linaro.org, Arnd Bergmann , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] s390: hypfs: use ktime_get_seconds() instead of get_seconds() Date: Mon, 18 Jun 2018 12:05:00 +0200 Message-Id: <20180618100534.1857997-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:KGgJLfdQ/HqP0GR5FYdAvj8PBrlFjxGx/cKaP/jfBz5gcsyed1F aBdrUxBAihrcQrL/XXeO/ubrBycB91ETX1oF5UYpXajvwZTClHWShal8QvdDhumvnQ1spvy 1kjYufZ26n4x79up1YpZQX55q0tNgLuMMnrk/vgpvSkNCIz5krsYKFew2d3F+uFxzjqp4n5 dF3xf3QcD+57vLIjy3WKw== X-UI-Out-Filterresults: notjunk:1; V01:K0:o6vKrHjPPUA=:ZqPtTzNRlRqPFrQLa2vxMA 0GsJy9YVse4mLA0RA0Y814wUbd7RuszeTioMFWdmGU/PygdpaNqEvRv8fwY0SRexI5B92XOc4 T+BhwQpt8i4EC5C1f57R9oeFPLvHUTnMOzqjrtH8aG1SW8iOnW6fvNRMy2UYlyN0ZBsUhU6BD 8TVzJxuhXPMq6oh0wyQM3CZ7dvEUdUL9MkyxJSlhw7SYQ6gGiWgxa5kXZrNhRHxR6ZIT/PSp6 w2MT2Ty7rAtvJSGF+kH876ykEv+G5Ts+vkMeX/D6tJvFHt6i0K6vJhVUIKe/82LmMOZ+DTBzi L9nENxNGkPd5MueVKmDELrr6ALcN2VoKg6LeQDgXhQ1UjaAjkqSI93kCLAFXsFO1QbiYILxHX e0UVFb1UigQi44HDIJdpE7pDTZYJs51uDBIuUws4jIIg18gELi27DJgtqCaY53VG5V5jgSQAA jNnLyj73lZ7p3dqe4POC0J1Z01FabltV1ruOoD7YPLxqYE3NTL1pWRaN0RfyaUEvsBiUfnlRl 0aBZDeftoYHMlxfeS4lEbQqsHwFv+k54zcGnazxUBri5PN7O484ztmebVF6qjuRn0y8tfgmn4 utlJ0nnomX/vYQ657TwWqFGbqI29iMnMj3QJ1+lHGNKEoO88F0DwfnjSiTeifiH9PgmExxU9Z y10yOo2JbNBNoHvasJXZe/hM9t5yErOrv2wWQDX4kmA3FQSt2buJrIwPoMTuWdrZNJxE= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org time_t and get_seconds() are deprecated because they will overflow on 32-bit architectures in the future. This is not a problem on 64-bit s390, but we should use proper interfaces anyway. Besides moving to the time64_t based interface, the CLOCK_MONOTONIC based ktime_get_seconds() is preferred for kernel internal timekeeping because it does not behave in unexpected ways during leap second changes or settimeofday() calls. Signed-off-by: Arnd Bergmann --- arch/s390/hypfs/inode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.9.0 diff --git a/arch/s390/hypfs/inode.c b/arch/s390/hypfs/inode.c index 06b513d192b9..c681329fdeec 100644 --- a/arch/s390/hypfs/inode.c +++ b/arch/s390/hypfs/inode.c @@ -36,7 +36,7 @@ struct hypfs_sb_info { kuid_t uid; /* uid used for files and dirs */ kgid_t gid; /* gid used for files and dirs */ struct dentry *update_file; /* file to trigger update */ - time_t last_update; /* last update time in secs since 1970 */ + time64_t last_update; /* last update, CLOCK_MONOTONIC time */ struct mutex lock; /* lock to protect update process */ }; @@ -52,7 +52,7 @@ static void hypfs_update_update(struct super_block *sb) struct hypfs_sb_info *sb_info = sb->s_fs_info; struct inode *inode = d_inode(sb_info->update_file); - sb_info->last_update = get_seconds(); + sb_info->last_update = ktime_get_seconds(); inode->i_atime = inode->i_mtime = inode->i_ctime = current_time(inode); } @@ -179,7 +179,7 @@ static ssize_t hypfs_write_iter(struct kiocb *iocb, struct iov_iter *from) * to restart data collection in this case. */ mutex_lock(&fs_info->lock); - if (fs_info->last_update == get_seconds()) { + if (fs_info->last_update == ktime_get_seconds()) { rc = -EBUSY; goto out; }