From patchwork Fri Jul 6 15:15:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 141337 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp3231593ljj; Fri, 6 Jul 2018 08:16:09 -0700 (PDT) X-Google-Smtp-Source: AAOMgpduneu+8vQ338TPKG6bwZrQVCnaTykiR8g9lYiCD8Ck4G3jVXCt9MV60cGdQuI850b+IAEE X-Received: by 2002:a63:b74a:: with SMTP id w10-v6mr9692474pgt.266.1530890169834; Fri, 06 Jul 2018 08:16:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530890169; cv=none; d=google.com; s=arc-20160816; b=P4dZLlT77zQ8gpqGG5YrHcrbC4EcQcwEYJ0ho7+YjwTMuEv2Yw8NWGxtLP4zt6yP0D zJkZm65vBSY3w0i+QnkvN5pW9kRWL/fPQ+TOuZaeWw0DX9deVexIgSE/8kyvMqe5vBxe RqzTzoCtTtEK7e2g1jxZSo6g/khezfCvXnzPgi4m2obFTrrPEGYqLUrb/3DyGzNSjlgH ruK39puwW+GGWPNTcdII5Km6+ANMpFB3ixtMZuuE59emXUEJM3UfQJh9tXYVy07X4qsQ y/wlIl6jdM48CiI7jY32RLSJ/Tk6Bua3bmq83ZFg/AW/cqqkZTzEtOBtviGhDfGpD3uo OG7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=3efursjmsgARFex/Svp3GGw//5P8Ge3Oj/oBG34nxNA=; b=XCX1CoIbfxwY2HMRA7jsMVQCLCCHx3Bvs7aUn7N+ICwseDn1BGGKAbvbtJAlVkJjae C+/IxdbIVw3RlR5kUwLJo/LUjfqpFD5uiyyOIsGI7pVxiM0fYz5bM510OHugzsTqzuj3 J4cn17AxzGVocXgk3X0eo67zqUWzt66zyWgRBpYpaGBwVR1Km8BWcddAiEJizq5rS72j nHDoTkCA39ittg7y1DsFm9N5VCYn0tVR+Hxs+XdhK5sYJe8Vwz13cf690hu/jbIV7/uJ +B6C3I+qqNribjnuXMAFQUnJ0AMmlWh7ds3cgd3dY/DergaC/uTYuW8k9qhYHDh35Ecw hI+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t70-v6si7947938pgc.481.2018.07.06.08.16.09; Fri, 06 Jul 2018 08:16:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933026AbeGFPQH (ORCPT + 31 others); Fri, 6 Jul 2018 11:16:07 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:46595 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932542AbeGFPQF (ORCPT ); Fri, 6 Jul 2018 11:16:05 -0400 Received: from wuerfel.lan ([46.223.138.35]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id 0Lx70L-1gCZRt2tg1-016eQb; Fri, 06 Jul 2018 17:15:32 +0200 From: Arnd Bergmann To: Simon Horman , Magnus Damm Cc: Arnd Bergmann , Geert Uytterhoeven , Wolfram Sang , Yoshihiro Shimoda , linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: shmobile: r8a7779: hide unused r8a7779_platform_cpu_kill Date: Fri, 6 Jul 2018 17:15:19 +0200 Message-Id: <20180706151528.3759312-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:H0IJLaOwxpSI1u+aeBkfsD1IXKxfuBvey2775URZ7tvMdSq3R+u 4zk4I4FtmoZePIlCO7iTwcNVG+p6mlT9V3kk4mN46ysuDvwab/JpRVfhHNQNPBtkvdqiIOt f+Ih4lpKl5xZtUwAn9cpE/gSxsi/Mc8us9izmVtXcEWWbFr6tprG9uMyPp6JkUFpyoS8raX sKu2N1Wm/3b+HCNTv1qnQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:2oBWXK5I0bc=:zO2GLzxp1vY/sfKs+i10X2 s69S1rw0tgWXZVArct66OUJqGL5+33h9o2FY+Rk5eq1I+T5WBJdphd3NighY/HTn3mkIo25z8 U80JYR2tdpIy4Vkq5Xxn22F1i2FhZgE4GauLubmQNhFxrkgI1rv+15RlKN669U2LOepSCrZYF LBFeyh3h22QxVBTjThV9V8BcLarN2lHGiJxYGWD4BXnaVIEGnfyQwh29Uin7LN3/Hmf93evlY 4sC5wGRy516OmEoNxNpK1E46EfWoCubcXo2fHkT5UCpgNpAxb8/y5W3bJ4PnE58CRBCBI8E3X +1ET8Eh4XHTK2p7kHQ5By9dzKImUVIAi0pz/1HwBmDdcDz2sxKTDz1gJYsEbzlKHiz3cVAC91 2J/9EYcz5O/gzRU8llmmaU7X9tZXC6ag/VXmB4dFYtJoGLCLKld1lYcbL4VNkJHO8AxDhmDBA azEnwiajV1vOh1QXzJhBeKTkc9Wdg5KZ0E4clU4SXqBAvKq1fHitbRoZk1qKPWBFy4MnLVIhb XPFd/gOaIJuhVZBNohMeQ58X8B/dG2+bQfYm3SabAzefnHx+MofF+jdhCBvGTK48zVdNWgmIv 8T3TcpJol2gia7NBTn+aVI6URPDJ2uuoAFjlI6ukhLume3b4PK/2T7q9BEjX3KY7ZcQoxEpPl TMnL4Zwjb3XUn8+jfAn2XBm5/i4iBchdBuNIvHJimUrs7u1I3ok0BHBSAzHP3BlENdfg= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After the cleanup in r8a7779_smp_prepare_cpus(), the only remaining caller of r8a7779_platform_cpu_kill() is in an ifdef, which leads to a build warning without CONFIG_HOTPLUG_CPU: arch/arm/mach-shmobile/smp-r8a7779.c:26:12: error: 'r8a7779_platform_cpu_kill' defined but not used [-Werror=unused-function] This moves the function inside of that #ifdef to avoid the warning. Fixes: 62f55ce683e3 ("ARM: shmobile: r8a7779: Stop powering down secondary CPUs during early boot") Signed-off-by: Arnd Bergmann --- arch/arm/mach-shmobile/smp-r8a7779.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) -- 2.9.0 Reviewed-by: Geert Uytterhoeven diff --git a/arch/arm/mach-shmobile/smp-r8a7779.c b/arch/arm/mach-shmobile/smp-r8a7779.c index b7fe1f489b08..0ed73b650c14 100644 --- a/arch/arm/mach-shmobile/smp-r8a7779.c +++ b/arch/arm/mach-shmobile/smp-r8a7779.c @@ -23,17 +23,6 @@ #define AVECR IOMEM(0xfe700040) #define R8A7779_SCU_BASE 0xf0000000 -static int r8a7779_platform_cpu_kill(unsigned int cpu) -{ - int ret = -EIO; - - cpu = cpu_logical_map(cpu); - if (cpu) - ret = rcar_sysc_power_down_cpu(cpu); - - return ret ? ret : 1; -} - static int r8a7779_boot_secondary(unsigned int cpu, struct task_struct *idle) { int ret = -EIO; @@ -55,6 +44,17 @@ static void __init r8a7779_smp_prepare_cpus(unsigned int max_cpus) } #ifdef CONFIG_HOTPLUG_CPU +static int r8a7779_platform_cpu_kill(unsigned int cpu) +{ + int ret = -EIO; + + cpu = cpu_logical_map(cpu); + if (cpu) + ret = rcar_sysc_power_down_cpu(cpu); + + return ret ? ret : 1; +} + static int r8a7779_cpu_kill(unsigned int cpu) { if (shmobile_smp_scu_cpu_kill(cpu))