From patchwork Fri Jul 6 20:19:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 141345 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp6328ljj; Fri, 6 Jul 2018 13:20:12 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeXsp+8WZL3AaXvyHka/j/982dQjJORLovwAdMQz5p2HE0NhKQqAsaEqPrgrQIXCCqZT+Aa X-Received: by 2002:a63:7558:: with SMTP id f24-v6mr10785766pgn.314.1530908412013; Fri, 06 Jul 2018 13:20:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530908412; cv=none; d=google.com; s=arc-20160816; b=cGcZcZ7HuUERd4GQzq/KqtDxo08sahEdizyMzlSfyvZ4Yrzgw05fCxTs2DziNHIbJA 437fJYRNZeWVWW01sLm/eREffVSzQc3nWNfkuveSQHKxMOlRF3U152KX+5tpv7MdSPhU HP+v/LoVY35ewIYFavF+xhKDQFPXV+7srZ4DmsODx/6tynIjBiklKmAY4mtGZlKY8onN cq2z+K33zKFzvuWJVa4GiNSZ1u1KMCQGCwLUkkVgecsGOpkz0Nn29omIslx0F0EPjO0n oXvHizj6Pr9L5dvRsxlMlQkGOkx1H+jkI/3TiIZ64b0NqhI7K5buWaovOQJj7qKmwlw/ vSBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=FvjjhOXWnf7auFYc7Ii77LchWXWjNsLPZe4lZbzQ9pA=; b=vS3lKDO7QpfsUOiVHJ4knXv5N6kZ4Zt5jzBqIzl4IBuYTm1RrfZNOiwXMZF3PFJcab INx7xNIPb2toU0kUGGKFK3i+By6Pn0rBoRYVKY289lqggcaFd3/+xTwequUhosNLlX7g Gv1RY66XWpx+lg0meOrkCs7U0h7v0JSl95G+L05ujg9KZI8qemCcS76qpmXeROWb5jf5 eqbQ3QpYw7lhmREUN/da7X06y/x+XJmpcsYkjnxSo0BGySBHPoeSISs2WhRyHtWCLRK1 4UX8KnhU5XvN5xh4/pxtre1RDVDwjEQys7S+YDe1M7ghHy1fuE9lgxVef6YN1BDybuIa 20Bw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v127-v6si8419898pgv.212.2018.07.06.13.20.11; Fri, 06 Jul 2018 13:20:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933908AbeGFUUK (ORCPT + 31 others); Fri, 6 Jul 2018 16:20:10 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:33093 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932328AbeGFUUI (ORCPT ); Fri, 6 Jul 2018 16:20:08 -0400 Received: from wuerfel.lan ([46.223.138.35]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id 0LqlM2-1g5exT1tRq-00eNrm; Fri, 06 Jul 2018 22:19:25 +0200 From: Arnd Bergmann To: "Martin K . Petersen" Cc: Jens Axboe , Felipe Balbi , Matthew Wilcox , linux-scsi@vger.kernel.org, "James E . J . Bottomley" , Arnd Bergmann , Omar Sandoval , Ming Lei , Paolo Valente , linux-kernel@vger.kernel.org Subject: [PATCH] [v2] sbitmap, scsi/target: add seq_file forward declaration Date: Fri, 6 Jul 2018 22:19:07 +0200 Message-Id: <20180706201920.2185565-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:gFLHbI4SRZKu7sStNHVecPi+UOtkhZ+hdXsQ2znEm66YVUlsntB ulVjcxVsbxzROTPA28V38wSS6Ntl7+3aXErFJUEm6W4xjZeU+mQgJhrxkhBf9StOoiHXou4 WKx3uudT2YK5KiJd8vf12IWGw80hbbxbxCb3s/MgyxzWAZbPTHU3hhRIiEgWP8Sp/0Dz3lz YGv8yEH4YiLXUdToLRdHQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:r3leehaQw6o=:nNNvtjeraBL8bHXSUymWNG UtkKfhslqlELGUHHtkvlxcQ7WvGT/D2g1X/qi/01M0RBoX+6GIKRn6a9N6pCvxlwha8l6h/N/ ut+12PfAs2OaSxhHlYropQgrfsEGFOlTgPoVxDAwMlT3IdSF5IUJNSR2Cf6Q7c3+SVskusrgP sim6cR/e01RqzSorj9krr4lO07mMcJqR7/XcylESQa94qYXIDFjiqMoxN4KbHOdwKG+683uV7 8jcRdGG0QuQMH1NsB3iS+jJP8WKA9Fx3qRhWPTXy561inz/ANoQFhMXnBv9Ok2/d5pohISMk3 U3Ak+bkw2Qr/SAZuhfV8ZWRn1mVnPqTziCs2Sgqx7M1so+ec14S468hJDUqB9FYkZI1oLqPKF EJEfTA3eEu1Fr1+rlxnE/P374XMrsO/y6okijH+UOuhGjH1YAIZnzJesjpdSfo++ubtxHIDG5 Pmh8JFyV84/vybvstmU6ABwdKWOJChdaCDQ57999Dv0vC9zwajmxnZpJ/VUT+gntn7CZrxrIc w2+L0UPmj6LLEeXPTitl5fjMmiUsQZtTc0aOGr2yqkjky0Oh0PX6D9ySbOLZHnECefIdgGd8F mnOo6qAkPb/yZy+pOtg+EjgRS9x/J7xu0OHQFuRspKqMp7U7yVFjDNcw026kCfNnIa9tHGXZi 5d/IOClYansyNu2UwlR8iI7K0wjieOZWLUGoKNYcIBdpOI4cv9O0AM4OwAWCMZe1LBc0= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The target core runs into a warning in the linux/sbitmap.h file in some configurations: In file included from include/target/target_core_base.h:7, from drivers/target/target_core_fabric_lib.c:41: include/linux/sbitmap.h:331:46: error: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] void sbitmap_show(struct sbitmap *sb, struct seq_file *m); ^~~~~~~~ In general, headers should not depend on others being included first, so this fixes it with a forward declaration for that struct name, but we probably want to merge the patch through the scsi tree to help bisection. Fixes: 10e9cbb6b531 ("scsi: target: Convert target drivers to use sbitmap") Signed-off-by: Arnd Bergmann --- v2: move declaration to the start of the header, as suggested by Bart --- include/linux/sbitmap.h | 2 ++ 1 file changed, 2 insertions(+) -- 2.9.0 Reviewed-by: Bart Van Assche Reviewed-by: Omar Sandoval diff --git a/include/linux/sbitmap.h b/include/linux/sbitmap.h index e6539536dea9..804a50983ec5 100644 --- a/include/linux/sbitmap.h +++ b/include/linux/sbitmap.h @@ -23,6 +23,8 @@ #include #include +struct seq_file; + /** * struct sbitmap_word - Word in a &struct sbitmap. */