From patchwork Mon Nov 19 10:34:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Valente X-Patchwork-Id: 151477 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp2490195ljp; Mon, 19 Nov 2018 02:35:10 -0800 (PST) X-Google-Smtp-Source: AFSGD/UNHtZ3NDho1TsnCldoe0PukPqNVfma6Sh7dBSikOnyc30QhYExKD3C2VkIk0DPSgZTD2G0 X-Received: by 2002:a17:902:4c08:: with SMTP id a8mr1190324ple.74.1542623709896; Mon, 19 Nov 2018 02:35:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542623709; cv=none; d=google.com; s=arc-20160816; b=ME0NUJmyX073exKUfrnsJMOnJWl1DCe5+9Hu4MdUteRNsjTtv7N7gFj53PKRDaawSN Gnno5GH29xRiB6N1URVSZPdGWBamcdvhqXaEhGCY9zInQtOVVMyJpy/0RAwK8WS+9+u1 AEGcN4oSQorQE89ntS7Kddl0EXzcfLW3PdRvxs4s+0Oa3fVJB+eN1qsmZXohaBMwj4TJ Dx9gB2xPmu3IzUJmZxdlPY02z6WI6agoWdySU/LP27wGKFhgz/wbF2VAq7vGpGGhb7ak 8iKk3Hd0Mapyqfd/AsmEdJ/Zr2X3/vwGyGN0cWNc97wm07xT13s+gbRYVJu4bsGxs9aE 0giw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=2PZH8WwXkvnGeOOTNTp/CB09k6USJvSSB6C0CaaMGjI=; b=fRwgABBMs9cEvxeXHDVZaKfI/36ckba0kc3pU7dHhtcU0QReQhm6kES6KkJrqNRn8/ q8j5fxBlMrp8cPj8kiIYOI47DxPWnxdLbaEBGdtDQ4XngIs6IV40dQjtuz9/FEshdjr6 lyY4aL4uvO9sz3AVy7Cqg1Vm11cS8Ld3t7zUTh/Kx/5jcAR7HuRHmmAm6QpByfmcKi35 DAKG7JGnFJEA9Y4/rwSdxTX4v3Tlpx0bBL5VkqJ5gHpS/Z/a8x+1Wgex0KeoyarCVIAK 3nDmSHX7Zn4NGp0EoTlKFiCyBPJsPBtWiRhrKuktAmWnge4laUch0EYwvVaS5LQ33X29 U7qQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="hcuU6/Vq"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f21si21573830pgv.111.2018.11.19.02.35.09; Mon, 19 Nov 2018 02:35:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="hcuU6/Vq"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728444AbeKSU6U (ORCPT + 32 others); Mon, 19 Nov 2018 15:58:20 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:33400 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727836AbeKSU6T (ORCPT ); Mon, 19 Nov 2018 15:58:19 -0500 Received: by mail-wm1-f66.google.com with SMTP id 79so2405024wmo.0 for ; Mon, 19 Nov 2018 02:35:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2PZH8WwXkvnGeOOTNTp/CB09k6USJvSSB6C0CaaMGjI=; b=hcuU6/VqTQwptGHjtIMvqO0p51x14o0CH8VynZz+6pAYFV8wdEQyx+ljlgfV6rV2w7 ITCCyWJsgcX5EmmWYweoyDAMoKM4kZS/0KIuLLINuDr3CFzBBAYSz+58G1YiRCRMTQrt ivc6Bbj1bt5nmThOu57faArw/3BCDnwjUELl8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2PZH8WwXkvnGeOOTNTp/CB09k6USJvSSB6C0CaaMGjI=; b=R7EPKxQUCxhRamez2jd93QBX8CPie6Z+w5uGXvf1X98+pT5zNGVMocftHXsTY3hfmB Ku5kefxs18lH8zi66OGRHU9Hwzy6tpTTXN3xFX9tqeuMJfMcf4CoDJ9FIEc2hIraSMZM uxRl4vHy54Di4p12zONAhoMI+0IMHKKuqJUDBGHRCK/y6x44jj2WX5W8wOImGHuCTJuU 4Pb28kJv+ihXnSfY+aC0VMQwXZG9Pz9C5rzqAOu53qJqeQDt7r9Y9oYXnoIfvpOssi2z hLtQzG03NXjnhq127gxyH0zA6zrLb6+wQe2g3IXXExXITSn9GoDUSCeNfeBt1ooPLbAl kNDw== X-Gm-Message-State: AGRZ1gKFDCWPhOLTklwxcOqnegsMsIQ6b7QJYT6B6WDotEH7nRHOn8WD mHGYceN7gvvaQwRFAxutcfFNVg== X-Received: by 2002:a1c:ddc3:: with SMTP id u186mr6436592wmg.110.1542623705169; Mon, 19 Nov 2018 02:35:05 -0800 (PST) Received: from localhost.localdomain ([37.162.18.180]) by smtp.gmail.com with ESMTPSA id e9sm14973298wro.16.2018.11.19.02.35.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Nov 2018 02:35:04 -0800 (PST) From: Paolo Valente To: Jens Axboe , Greg Kroah-Hartman , Tejun Heo , Li Zefan , Angelo Ruocco , Dennis Zhou , Josef Bacik , Liu Bo , Bart Van Assche , Johannes Weiner Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, linus.walleij@linaro.org, broonie@kernel.org, bfq-iosched@googlegroups.com, oleksandr@natalenko.name, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, Jonathan Corbet , Paolo Valente Subject: [PATCH V2 10/10] doc, bfq-iosched: make it consistent with the new cgroup interface Date: Mon, 19 Nov 2018 11:34:24 +0100 Message-Id: <20181119103424.3853-11-paolo.valente@linaro.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20181119103424.3853-1-paolo.valente@linaro.org> References: <20181119103424.3853-1-paolo.valente@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org BFQ now shares interface files with CFQ, for the proportional-share policy. Make documentation consistent with that. Signed-off-by: Paolo Valente --- Documentation/block/bfq-iosched.txt | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) -- 2.16.1 diff --git a/Documentation/block/bfq-iosched.txt b/Documentation/block/bfq-iosched.txt index 6d7dd5ab8554..3d7ef138ce6a 100644 --- a/Documentation/block/bfq-iosched.txt +++ b/Documentation/block/bfq-iosched.txt @@ -508,12 +508,14 @@ process. To get proportional sharing of bandwidth with BFQ for a given device, BFQ must of course be the active scheduler for that device. -Within each group directory, the names of the files associated with -BFQ-specific cgroup parameters and stats begin with the "bfq." -prefix. So, with cgroups-v1 or cgroups-v2, the full prefix for -BFQ-specific files is "blkio.bfq." or "io.bfq." For example, the group -parameter to set the weight of a group with BFQ is blkio.bfq.weight -or io.bfq.weight. +BFQ uses the standard interface files of the proportional-share +policy, previously used by CFQ. If one such file is read/written, then +the operation associated with the file is performed by BFQ for each +device where BFQ is the active scheduler. In addition, BFQ is +configured so as to share interface files with other entities (if some +of these files does happen to be shared, then its associated operation +is performed also by any of the other entities that is using the +file). As for cgroups-v1 (blkio controller), the exact set of stat files created, and kept up-to-date by bfq, depends on whether @@ -521,13 +523,13 @@ CONFIG_DEBUG_BLK_CGROUP is set. If it is set, then bfq creates all the stat files documented in Documentation/cgroup-v1/blkio-controller.txt. If, instead, CONFIG_DEBUG_BLK_CGROUP is not set, then bfq creates only the files -blkio.bfq.io_service_bytes -blkio.bfq.io_service_bytes_recursive -blkio.bfq.io_serviced -blkio.bfq.io_serviced_recursive +blkio.io_service_bytes +blkio.io_service_bytes_recursive +blkio.io_serviced +blkio.io_serviced_recursive The value of CONFIG_DEBUG_BLK_CGROUP greatly influences the maximum -throughput sustainable with bfq, because updating the blkio.bfq.* +throughput sustainable with BFQ, because updating the blkio.* stats is rather costly, especially for some of the stats enabled by CONFIG_DEBUG_BLK_CGROUP. @@ -536,8 +538,8 @@ Parameters to set For each group, there is only the following parameter to set. -weight (namely blkio.bfq.weight or io.bfq-weight): the weight of the -group inside its parent. Available values: 1..10000 (default 100). The +weight (namely blkio.weight or io.weight): the weight of the group +inside its parent. Available values: 1..10000 (default 100). The linear mapping between ioprio and weights, described at the beginning of the tunable section, is still valid, but all weights higher than IOPRIO_BE_NR*10 are mapped to ioprio 0.