From patchwork Fri Nov 30 11:53:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 152532 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp3562738ljp; Fri, 30 Nov 2018 03:53:48 -0800 (PST) X-Google-Smtp-Source: AFSGD/VUUJYsCGBMZOE7bKfO66o2+MnMHwDvWUHxI8r+0fZO7Zvd/nasCpQDDVpTfIOUZ4a0+cPz X-Received: by 2002:a63:d10:: with SMTP id c16mr4633835pgl.382.1543578828119; Fri, 30 Nov 2018 03:53:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543578828; cv=none; d=google.com; s=arc-20160816; b=uceIw+JaevVD+MW0niilUTDPcKv97qp7P37M+bnh5+PKI5iObGt6yrMPExinl3ACnt dJgJurjnw7coCJLMq5y0tXdSTgRPedUG4US4ieEPn+42Gy6JLtDo+B00/9zbbl1eVDl/ hE32dD2iyTlKUdM4lfqAx+yDby9uua+kM8e84Xd5oXiekpKFr2F8TxldEd3NQFfWZfye VOio3Z3jpTH4IiYFFAmoGCl2JLstmDOY7Mb6ozphJ1xlA26EbiO+V0IPwveh+SI2IfEz MSImIm1LjFYP1b1qajPA4Ik8aesh0dX1Cp+ksiowT9XakCE0pM375FZ4ZzcRZynlESx6 lDTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=S2XBbpoddUxn8L0Ic4aH0nP9i4f9kF4ywqyELelq9lw=; b=SMLUyerA94kYwPBeoscF8UbidN0ZWOXkSDugRRgR9603eKFzbQhrEAGfh5eaOsK49z SSg7n0ekfIvdkBDmasAJT3Ie4QC3u3nH4WoKM1wqK+huN5yn0+pycmJsOHaPjYThrWVZ 2ylrFg+q48nbYmcNv5XpQIWMQJLn8jBxLpPZxz6pLntRzKlKrgyjCrOjP6wB/5w902MP euvLdDmfbHjosZ/5Fw9el4UOxC9lDYS9YN135Hd8EgcmC2MNlQuqB5Qw+2Ovw7wmBgoX H6Ln1UTQl1sFU7yiYr/Bcl3CJ7oB8u+9XVbG1Ts1kZbSiSYVM4HSUlE0gZET2CTeZO/k BHTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Dvl/HPIx"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 69si4001010pgd.290.2018.11.30.03.53.47; Fri, 30 Nov 2018 03:53:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Dvl/HPIx"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727139AbeK3XCr (ORCPT + 32 others); Fri, 30 Nov 2018 18:02:47 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:43678 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726651AbeK3XCq (ORCPT ); Fri, 30 Nov 2018 18:02:46 -0500 Received: by mail-ed1-f66.google.com with SMTP id f4so4591401edq.10 for ; Fri, 30 Nov 2018 03:53:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=S2XBbpoddUxn8L0Ic4aH0nP9i4f9kF4ywqyELelq9lw=; b=Dvl/HPIxXglomNtTFiIuB3/vcmwltDNHsYyq2wT0HAf7NbL0u3FkwCajzVLbiCKM2i 1aYYZXp46RO81oTqw4nZWlSsG4t+SRAiRumx7zGI5OVSixx9CHXHskuCbSk967jkdtvD epFSWXDnjwHp6jRk27RAujEoWBw1spMpGsveA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=S2XBbpoddUxn8L0Ic4aH0nP9i4f9kF4ywqyELelq9lw=; b=oyQaFERvedIT6c9VwkKAFX3NUWcOwaV+JXz00K6YfrVy/naCHu320O/5HSGVMyvCQU S3rWGuq2SnfMhEXcTcG81XwnycXRMJO1NUJ9SAoy1AGeUQ6t1zPFDr96yWIO3CR+JtYH gpiM+UTIgGmtnils6zq00hcY1+qBwmQRdeJGOO/XUacFFKW1MbVeQ+oVAnjAPk2IPCTI 4rxhN6gzPwKwsBR6OaAxrsvAqdy3h7KeEcE/tSWHKzM3E+UJI66e/z4eNk3iingh+0UG cevcMjsUVWxRPByAisEnk380y8zqJEllxm4zt602uCisKwKZHkox4fE9shk9CHdd1ZUA f9DA== X-Gm-Message-State: AA+aEWaMJl9T8TB4NN8Hzn+QC2qaaF5AuFrMD2sxsmmaiFQN1rAXzDWG 86PlGflKZp1AGjGBMlNjzdMlNhWQH+k= X-Received: by 2002:aa7:dc51:: with SMTP id g17mr4882519edu.115.1543578822887; Fri, 30 Nov 2018 03:53:42 -0800 (PST) Received: from srini-hackbox.lan (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.gmail.com with ESMTPSA id t10-v6sm767932ejg.41.2018.11.30.03.53.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 30 Nov 2018 03:53:42 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Andy Shevchenko , Srinivas Kandagatla Subject: [PATCH 5/6] nvmem: Move nvmem_type_str array to its only user Date: Fri, 30 Nov 2018 11:53:24 +0000 Message-Id: <20181130115325.16539-6-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181130115325.16539-1-srinivas.kandagatla@linaro.org> References: <20181130115325.16539-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andy Shevchenko Since we put static variable to a header file it's copied to each module that includes the header. But not all of them are actually using it. Move nvmem_type_str array to its only user to make a compiler happy: In file included from include/linux/rtc.h:18, from drivers/rtc/rtc-proc.c:15: include/linux/nvmem-provider.h:29:27: warning: 'nvmem_type_str' defined but not used [-Wunused-const-variable=] static const char * const nvmem_type_str[] = { ^~~~~~~~~~~~~~ Suggested-by: Alexandre Belloni Suggested-by: Joe Perches Cc: Srinivas Kandagatla Signed-off-by: Andy Shevchenko Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 7 +++++++ include/linux/nvmem-provider.h | 7 ------- 2 files changed, 7 insertions(+), 7 deletions(-) -- 2.19.2 diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index d9fd11033c1c..22345e65a301 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -61,6 +61,13 @@ static LIST_HEAD(nvmem_lookup_list); static BLOCKING_NOTIFIER_HEAD(nvmem_notifier); +static const char * const nvmem_type_str[] = { + [NVMEM_TYPE_UNKNOWN] = "Unknown", + [NVMEM_TYPE_EEPROM] = "EEPROM", + [NVMEM_TYPE_OTP] = "OTP", + [NVMEM_TYPE_BATTERY_BACKED] = "Battery backed", +}; + #ifdef CONFIG_DEBUG_LOCK_ALLOC static struct lock_class_key eeprom_lock_key; #endif diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h index 00ff92571683..5b2dd0a987d2 100644 --- a/include/linux/nvmem-provider.h +++ b/include/linux/nvmem-provider.h @@ -26,13 +26,6 @@ enum nvmem_type { NVMEM_TYPE_BATTERY_BACKED, }; -static const char * const nvmem_type_str[] = { - [NVMEM_TYPE_UNKNOWN] = "Unknown", - [NVMEM_TYPE_EEPROM] = "EEPROM", - [NVMEM_TYPE_OTP] = "OTP", - [NVMEM_TYPE_BATTERY_BACKED] = "Battery backed", -}; - /** * struct nvmem_config - NVMEM device configuration *