From patchwork Sat Dec 1 15:41:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 152636 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4934499ljp; Sat, 1 Dec 2018 07:53:19 -0800 (PST) X-Google-Smtp-Source: AFSGD/VEANWwTP+aBloyeIzKBBYoGMPWbvmWnwKpbRToVoJ555OGL41A4+yylFLVPCXW5YuLXT+r X-Received: by 2002:a62:e044:: with SMTP id f65mr9612669pfh.208.1543679599304; Sat, 01 Dec 2018 07:53:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543679599; cv=none; d=google.com; s=arc-20160816; b=C3VW+STSYc1LZMCZE2Ldh1O7rYbVDu8jqay8APayduUycTcaF8WP3jBYaWOlLuLAFH JEUlPrSIpIZ6qH7E7Uzem4qQShPAX+eSuIuOMP0CNTIcgma5mUBPWS5hk3Dh4zIX8YRR Si6c6S4fU3Ie3jRra2POjx9YyDsIcHECE17MCImXl6CzLTs4H5NFUYeJS98Ez5xZo+ky mNNxfDuCXD9eq3tK8SE3GLQnFAel94MT5AUpXq6YaZoapNZu1nLeEjbVlrGqTz0fWl58 /mM7DK5W0FvBT2Ioyk41yCg858L0BoZd/PVf34Yy9RzB5e38sRzdLYRSLTWkMpK532df jeSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=pq6EvrtcoHql5+ikFxa5KOOUuE702pUaeiFm45YZFag=; b=jYRDO43FYhZYpSc69ZeUm0vsifK+AQ4h4Y90mIwU4bh/ZGK8BLO3G4J8uI1MLsNbWd 8SKT2j8m6vtZ/zhxjMtwrmxV4fPuN4IrUMDOB5Kjhpf7rTFZVgtV2hlnnc0hC7iAZHp0 GHTVqt+4wpGxRecfdhVfASFpHkl0jiiP+zjEyWXl1kqLnR8EOR0TQKlcyGOgF1DWCG/F ZI1HLm173p0i6f44WdqLyLf5ajd2C5tZsskQ63Ju25c4Nz5NyTW8MzmjHLIpWu5HI+B8 n5vYJhdXMcxAMX/vFXuC1wdx2dIqt1jbxZt2/HlGat2w5DPDtnXAB6lCAhB1+/FJFlOO tDIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=huONIq9x; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v3si7791322pgh.305.2018.12.01.07.53.19; Sat, 01 Dec 2018 07:53:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=huONIq9x; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727288AbeLBDGF (ORCPT + 32 others); Sat, 1 Dec 2018 22:06:05 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:39007 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727226AbeLBDGC (ORCPT ); Sat, 1 Dec 2018 22:06:02 -0500 Received: by mail-lj1-f193.google.com with SMTP id t9-v6so7622820ljh.6 for ; Sat, 01 Dec 2018 07:53:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pq6EvrtcoHql5+ikFxa5KOOUuE702pUaeiFm45YZFag=; b=huONIq9xiOiCPKdaxpYnglZ90lOJ54IJVNZpMR2kMhewCKA0wlqAs1IgE0stbSmHBN bbqEDhA+k2i7sumjFv/YdI9+qx5pF0ZhVf7kwgpnTuKr3uhniUKF/8mCUHcbE3YHYAWr 9rcbabr9OvsfpJHKEqichuGOFEBPG7otpaZ3A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pq6EvrtcoHql5+ikFxa5KOOUuE702pUaeiFm45YZFag=; b=tWtfhw5oHTsV4F2HJRx7oFT2PWMd4BPhQ7ihyXSdmD12Kphu8EJkq+cBBG5HA2zOzZ QrvFY9KKYA29+e3YfprYA9++0knCYj6A6XEZgRam+lopaMIkD28RZvsakKrec6gdR8Z2 gj1wx7joXY3hw3gNhjwE0cd75w7tRg18NSyTQfmUbC2k8Beryni3PBXyWXT0iTJn+ggV D+5uOHGbOzGvHiGyW7Dmm8gCQ2mIbXqk5wsdIRI7F4VuRRSr5GvfUo9EKnnr/X80japS ckO5oo3ge3RbTcJW4+I1g9HI5LWIQmoeT31pzWOSBXR2mE8TuLE8rRSk821syOX6ADJF iIFA== X-Gm-Message-State: AA+aEWYAC5mkkFLCXF97SllakuuZBvyNgoZBTKAoH6FUHvSvNhedQsoz 2iBjD22ZWy2sZwWhLfUTgGP7sQ== X-Received: by 2002:a2e:9f56:: with SMTP id v22-v6mr6173396ljk.114.1543679592216; Sat, 01 Dec 2018 07:53:12 -0800 (PST) Received: from localhost.localdomain (c-ae7b71d5.014-348-6c756e10.bbcust.telenor.se. [213.113.123.174]) by smtp.gmail.com with ESMTPSA id 13-v6sm1365426ljj.49.2018.12.01.07.53.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Dec 2018 07:53:11 -0800 (PST) From: Linus Walleij To: Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, Charles Keepax , Bartosz Golaszewski , Marek Szyprowski , Linus Walleij Subject: [PATCH 05/13 v2] regulator: max8952: Let core handle GPIO descriptor Date: Sat, 1 Dec 2018 16:41:43 +0100 Message-Id: <20181201154151.14890-6-linus.walleij@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181201154151.14890-1-linus.walleij@linaro.org> References: <20181201154151.14890-1-linus.walleij@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the gpiod_get() rather than the devm_* version so that the regulator core can handle the lifecycle of these descriptors. Fixes: d7a261c2d1f2 ("regulator: max8952: Pass descriptor instead of GPIO number") Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Drop the gpiod_put() on the errorpath after devm_regulator_register() as this will be handled by the regulator core. - Put a comment in the code so maintainers knows not to use managed resources (devm*) --- drivers/regulator/max8952.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- 2.19.1 diff --git a/drivers/regulator/max8952.c b/drivers/regulator/max8952.c index 6c39fff73b8a..cf2a2912cb1b 100644 --- a/drivers/regulator/max8952.c +++ b/drivers/regulator/max8952.c @@ -231,9 +231,13 @@ static int max8952_pmic_probe(struct i2c_client *client, else gflags = GPIOD_OUT_LOW; gflags |= GPIOD_FLAGS_BIT_NONEXCLUSIVE; - gpiod = devm_gpiod_get_optional(&client->dev, - "max8952,en", - gflags); + /* + * Do not use devm* here: the regulator core takes over the + * lifecycle management of the GPIO descriptor. + */ + gpiod = gpiod_get_optional(&client->dev, + "max8952,en", + gflags); if (IS_ERR(gpiod)) return PTR_ERR(gpiod); if (gpiod)