From patchwork Thu Dec 6 15:18:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 153039 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp10652588ljp; Thu, 6 Dec 2018 07:18:59 -0800 (PST) X-Google-Smtp-Source: AFSGD/VExze/RUt3w9BfDESLKrNzLDC+yGMN96Wb882lidQS7K0KvWFcRpH35hdbt2UEF1I+bViC X-Received: by 2002:a65:6491:: with SMTP id e17mr24190771pgv.418.1544109539122; Thu, 06 Dec 2018 07:18:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544109539; cv=none; d=google.com; s=arc-20160816; b=xFcSdpLPB4Qwp8YVlH74bqPKm3GKmIwiFem33+xGijZVmthwWaDgx9M5dxVEoyATXs ncrl7ypUt7bcfYVOLrXt7l82frLT6JGWug5VE9ksKjSMfl0N93ijZ4nnOR9FYoR2Qgyp T1eBiQQueAGYHGfsnrQgoAqYmDwKDrcK44nfY2LoiWc7oB00wev0GtYNKgZvxepItG1M nyCpEH5mlFraVu8jnlczI+YprhsTe8esPcS+u9qif0YFxBZmnMiRCQUuTm7xd7GAtLVn Lam4W+tlnPNNTg8Zh3kYyiVyVE2z1D1kVtN/5EKRl4OAx5L1BR4KPlF4xVoloD5O2HYP V+5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Y7CGHPuU0cKd8uxanXCkssfy7HoOVVH2fzqpoBO3MJk=; b=xF+VEBoq0B4lpaZdkKzPCpE5OAsjqUpmVv9RlWo/a5hFo5BP7zLFWp1IHWnP4aH8zQ RKzYFOeDApF4JRuNx4uaSA4tt7wMA8wAQWT/MtrhbT6y+91wO4dpC3c0wZOtUiBofZin AHVaw073LGQMXBxhmfL+dkYHlr/+lVBhBcTkdZ7C+oD2IiROLi1ZMqEhVu6+VMeAyI8O OjhjDo1Pn9NcBDdx9ApxF6r+1lVHh/KvQZM89p/k6lWbu0a9eZJ32MGB/IJ/pjwGi4BG CZ3Rm/DcyD/N+wUN893fF0qQi9Jw87j4fBdcyfG+NIYprhbtzG2rR3nkENkSPGt8pnFu AKSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=c+bM7IaW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u9si518469plk.61.2018.12.06.07.18.58; Thu, 06 Dec 2018 07:18:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=c+bM7IaW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726087AbeLFPSm (ORCPT + 31 others); Thu, 6 Dec 2018 10:18:42 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:40950 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726045AbeLFPSk (ORCPT ); Thu, 6 Dec 2018 10:18:40 -0500 Received: by mail-wm1-f66.google.com with SMTP id q26so1412690wmf.5 for ; Thu, 06 Dec 2018 07:18:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y7CGHPuU0cKd8uxanXCkssfy7HoOVVH2fzqpoBO3MJk=; b=c+bM7IaWZi1H/3FYMQILbAyq3SkhW7Uih01O/P0gAfzhOuiZ5bnjA7L7I8NlwiHI/h H3OzC5LtUaJ3Tt+AqTqgP6zvsv3H3STi6sCHOoc3iiUkw9VJrjD4nw/ljk7rlFdYfZPZ n9lPPlK5rN0Rt2KtNVt7DMayET1i97tQKB+A5OnowPY5mN2MIKF5C1RarI4cDEb+fwkb IkTZ+bGtP7E5G0DsA5fVu/lPbzIQ+6aL4I1rL7Nn9MWo8aAK30cScv/o+rlOFACB4wVa 8Gbqh2mm58L1zsQhs1IgVCxGbY17DH2CUdB7UUG5H4rwVYbzRKmnjuPV8alx7YokJN9m wi+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y7CGHPuU0cKd8uxanXCkssfy7HoOVVH2fzqpoBO3MJk=; b=Wc2eG/vTsMT/ye1QIwZm1T2uFH90OGRsF8GxSMSlVHSAWw8reS7DWhDIYx0aggCWdK iEoxlFkgyhpGnGB6d2EGFoiiQj5jpqBfjy6j2mYSh5sy/prn1l1mmyteEwJ7AhGZYccJ c4DjzBYltf5KLbvEK1XaNXLt3D2SEq3Zrr/U7/do29XdQIgIbIXQQU96fIl40bGTS+1R TcmmElM5Z9iWeMYuoEEXqvVi3fSB5m5cYuRWRBWR5KQirAdS5xnhCdGfELRKiPv9bXg5 pmDSRIwLwriwf4wZf0mobbOifhe5zSgPCrdU5qB84zWgmnCzkOAqaysmMMRm14EvauMD SOFQ== X-Gm-Message-State: AA+aEWb6+Iasws1ThTakpU1NkR83zZNGyJKdITxWIARTFdwuEO6ytLgI Hx2HGBTIsuEwL056KfAF1/p4uw== X-Received: by 2002:a7b:c1d7:: with SMTP id a23mr19076799wmj.48.1544109519103; Thu, 06 Dec 2018 07:18:39 -0800 (PST) Received: from boomer.local ([2a01:e34:eeb6:4690:106b:bae3:31ed:7561]) by smtp.googlemail.com with ESMTPSA id j33sm939652wre.91.2018.12.06.07.18.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 06 Dec 2018 07:18:38 -0800 (PST) From: Jerome Brunet To: Ulf Hansson , Carlo Caione , Kevin Hilman Cc: Jerome Brunet , linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] mmc: meson-gx: remove useless lock Date: Thu, 6 Dec 2018 16:18:26 +0100 Message-Id: <20181206151828.24417-3-jbrunet@baylibre.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181206151828.24417-1-jbrunet@baylibre.com> References: <20181206151828.24417-1-jbrunet@baylibre.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The spinlock is only used within the irq handler so it does not seem very useful. Signed-off-by: Jerome Brunet --- drivers/mmc/host/meson-gx-mmc.c | 7 ------- 1 file changed, 7 deletions(-) -- 2.19.2 diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index fcb5d693c897..5cc31e434ca1 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -26,7 +26,6 @@ #include #include #include -#include #include #include #include @@ -159,7 +158,6 @@ struct meson_host { struct mmc_host *mmc; struct mmc_command *cmd; - spinlock_t lock; void __iomem *regs; struct clk *core_clk; struct clk *mmc_clk; @@ -1040,8 +1038,6 @@ static irqreturn_t meson_mmc_irq(int irq, void *dev_id) if (WARN_ON(!host) || WARN_ON(!host->cmd)) return IRQ_NONE; - spin_lock(&host->lock); - cmd = host->cmd; data = cmd->data; cmd->error = 0; @@ -1091,7 +1087,6 @@ static irqreturn_t meson_mmc_irq(int irq, void *dev_id) if (ret == IRQ_HANDLED) meson_mmc_request_done(host->mmc, cmd->mrq); - spin_unlock(&host->lock); return ret; } @@ -1244,8 +1239,6 @@ static int meson_mmc_probe(struct platform_device *pdev) host->dev = &pdev->dev; dev_set_drvdata(&pdev->dev, host); - spin_lock_init(&host->lock); - /* Get regulators and the supported OCR mask */ host->vqmmc_enabled = false; ret = mmc_regulator_get_supply(mmc);