From patchwork Mon Dec 10 20:39:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 153338 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp3988390ljp; Mon, 10 Dec 2018 12:40:02 -0800 (PST) X-Google-Smtp-Source: AFSGD/UqP/YaBz30oNzLc+ItOYPj1/+SBl1srhVxqO17dKegDa9yze1+nDbxPFsK+ad+oZXkaaux X-Received: by 2002:a17:902:b707:: with SMTP id d7mr12803392pls.29.1544474402081; Mon, 10 Dec 2018 12:40:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544474402; cv=none; d=google.com; s=arc-20160816; b=FM4RsEQTd3c/FvbXP5NBFdlh+KHu5BKnann9IIXd8Q3ayRTrQrc+rLxnQ/FxY2hDu4 9S5gO593hCqZC23QrYDfYrTTzaFG+UmH9eVUshDBZMiUB7BmtboevxdbqxzPUPm035D9 esa32sKB8CZqcGfrDNLvNLi3lP+mKS24ZAwWauLkIXgrQDssruKbOXEGl0I0VWGTWioc Mc34IwHNOxCrXHwzfpaaEYBgbIQL/aAoDLGuFGPUAIbGF20rUukgF/XGXL7JEsvCWj8X H2KCuaMYUqCQQ73lHo9zoknGVd8IAF+RPyho99NSNrHzIGNWSx/Wp92us13uBo2zq0WX Cneg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=oDaUdJwGaxfD1Li91QJORSpLj6FI2oL6Y1/L5HWOorE=; b=Ri47ERyr0gy/UbIPa6CECBAf1RSYv1QMRRzELVMQumtKFZK/k7Grv+ri7YH6som1dS pvb0cPIr3vnT205Kc2TItL5YFEz0QA0jGNWAdCc/v5y7GmcSq/mbbuPvUake//VswySq PD6rehmb5/Ng2sCg1WNkgKG/atLR2yfohkeoduFI8ergaPiii+9peGfOvekXvRA867kG 3a9ScvwziFqjASALXgvYCjltuF7SETPUkqRbW8E7AxXUCTpB6Ilc1OrgEKg9+ApfdJ3C CJJHpLZ92PdYeHsgmeeKpXBTPqBouRJdGYK7N/6s46dQd0/IJtfxANWIpSXliipdtow6 VZfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d1si10510763pgg.301.2018.12.10.12.40.01; Mon, 10 Dec 2018 12:40:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729468AbeLJUkA (ORCPT + 31 others); Mon, 10 Dec 2018 15:40:00 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:54873 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727598AbeLJUkA (ORCPT ); Mon, 10 Dec 2018 15:40:00 -0500 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPA (Nemesis) id 1MiMIY-1h8HGH1VCw-00fWBg; Mon, 10 Dec 2018 21:39:47 +0100 From: Arnd Bergmann To: Johannes Berg , Emmanuel Grumbach , Luca Coelho Cc: Arnd Bergmann , Intel Linux Wireless , Kalle Valo , "David S. Miller" , Sara Sharon , Shahar S Matityahu , Lior Cohen , Shaul Triebitz , Haim Dreyfuss , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] iwlwifi: fix false-positive maybe-uninitialized warning Date: Mon, 10 Dec 2018 21:39:06 +0100 Message-Id: <20181210203945.2147135-1-arnd@arndb.de> X-Mailer: git-send-email 2.18.0 X-Provags-ID: V03:K1:O/jKqBh1BL1p5TCwdbxUlYQTDOi/eGS8hsSGhgVOJ3Hb2mqCxtZ sDu/MKNTk2oKcaWhF/gOxcQtpTJ0wIq2If56JTi1mxXA8j5APMt59ZrDWlTga4NYUAT4+3W 8IfjbckCL1/Le77pS4a1h+et4r8BKUK0ZQDbEbrvrCRKbHJedZEJOT4X8wSMsyW+fhWFlqz 22f8lgD9TCv0iI7NqNJJQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:gm+OUDBcYAo=:xHdWXU3ZePBqCxTGkWAdpy huhsvYIqIuzHqGxzKKN+2hCDNJ3/VTEJ3S0ELXH++umaoSo9oTHbaEKwBBrlW69EpeCHxAjZY +/wwhsGC4yLpqVGs/nJH2dqXyQl4flPLQNyF3AWhnoSjxBZamtCKCKtfpl771k0ojn4Vdz2+l XLhknLrmtbzHJBPj5fUzYtGUun1QBwqwKrQ0nxc6R9TFyUV1BuADzvF9CYiy/MJmfwjKIPxPf yMjeKkwiF403jcZDknkGFaxDlsAQIdGYqYx4h9LjkediBiMhJfPe3zh50BUnY0ItKbA6OYe0O EzIVVE1cTFM/ejHo4l/NK9Av5w4N3Uk2ekH/0AGBXiRHXIQgwDb6GJiNdaZpynXcRKSW5Pm1o zcUIBUFyXugMXBIEavfKAyF95TvRucznTI79nG4uI5m03F3u2waVgVyEnUpI0JVzBawElp9WT XUgBm2fHTvOkm0+d/cBhICun9XixekYBC7cX286XFo2LJMCI3xBOzdLwcNdqeCrVXyQ6JuWbT A2bFsKw/ZOAnAiZc0hHA6STJHW0XBnnEtE3O0Ixz3kEkCKgsEjRjPOxcyHSCZvlYmQWCRWlOJ 8125dGvr33F+giiASqNVojTb6y8/2tlGU4DWjiSvF7+4eBMriZcJb3nY4H79GRzSl2C1mUAt/ 40XsLDUilVdFSkt7RZ2iMoZjQpa2pXWIAplokTHVaU3VO9HywxU623G2ohYo1f8Du93cFk6/B Lv4y9tAH4aQiVeACfD5ErZY4WMOxFtONj2FMew== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With CONFIG_NO_AUTO_INLINE, we run into a silly warning when gcc fails to remember that n_profiles is constant across the function call to iwl_mvm_sar_set_profile: drivers/net/wireless/intel/iwlwifi/mvm/fw.c: In function 'iwl_mvm_sar_get_ewrd_table': drivers/net/wireless/intel/iwlwifi/mvm/fw.c:746:9: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] Marking that function 'inline' avoids the warning. Signed-off-by: Arnd Bergmann --- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.18.0 diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c index c5168abe107c..07676408146b 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c @@ -629,10 +629,10 @@ static int iwl_mvm_config_ltr(struct iwl_mvm *mvm) } #ifdef CONFIG_ACPI -static int iwl_mvm_sar_set_profile(struct iwl_mvm *mvm, - union acpi_object *table, - struct iwl_mvm_sar_profile *profile, - bool enabled) +static inline int iwl_mvm_sar_set_profile(struct iwl_mvm *mvm, + union acpi_object *table, + struct iwl_mvm_sar_profile *profile, + bool enabled) { int i;