From patchwork Fri Jan 18 14:03:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 155937 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3291071jaa; Fri, 18 Jan 2019 06:04:02 -0800 (PST) X-Google-Smtp-Source: ALg8bN7P24yKgc+VuQuwbn3fJIeKgKkRJhanpstJYOxLKz8fWh/1+oscijLlNRfIWYu9hhyJGzqq X-Received: by 2002:a17:902:6683:: with SMTP id e3mr18553907plk.93.1547820242130; Fri, 18 Jan 2019 06:04:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547820242; cv=none; d=google.com; s=arc-20160816; b=xvz/7x5MXEwUa48kKQVGowkMBdfGStG1yW3x51fEuuKA1ArRGdwDI6QkcT8ivHjBae jhMxgv3vdWolIXHmKLykjtXtQsns17g92aGDER2qEo+5R9maLE/lfJWAzcydwP1La3BD 0+JchYZyTa9RIKrZDUADubREw4hT5FFyFfRhjziS2hz5gaqzHeF8q03CSaaLlWQZ1qHC sEKLHK6ecJ1emIqCmKXTq9jwRmHhfQnZejK455N7COlGNDBgoCf4lFmy9eU0JfSyg19a Oxi7WGLtnMAbDGhlDKs7rpsoBpFy9l2PyBoIehj4bxA4Ocm2q8q0SpMBD9jcHv2kkC+8 T/ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vCzxSPy+FzZRjZn8HTA+OyQdWgf2KeAGuCfMKZTF/eE=; b=sdYSZxYq9yfNzBKDDiMAgjQ4m0OKbVUdw3RlHtc5I0/YhUqZ3O0+VVxbMr8FhoAxUc itHsFHpxsvfElyxwg+UZJ5rHCX0uBtoYpClDa3O+kpCHWjCcKp5pRDYIK8IjfPw+rCxp rjzCBnepNPVMzbOtiY1/fph02q+JxgocUw3QHPmd95YtyoEq56BbfKx7cY1YquoeGm/k WXYaCx4ppuRGqjB4KBAAl+DBskujjvWD76PWMToDo5kbZLHrp/nejpLiOMG3uoGF2TfM KnqlSqCqQ+Iu0EEb1hfcQKdmEMMzyfqalIcQTRqhHMJbx99F54pJQ3ZJWq+7v7y8Xs23 2qFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Dn5D22rd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m4si4770429pgj.61.2019.01.18.06.04.01; Fri, 18 Jan 2019 06:04:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Dn5D22rd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727588AbfARODp (ORCPT + 12 others); Fri, 18 Jan 2019 09:03:45 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:41876 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727524AbfARODm (ORCPT ); Fri, 18 Jan 2019 09:03:42 -0500 Received: by mail-wr1-f65.google.com with SMTP id x10so15157635wrs.8; Fri, 18 Jan 2019 06:03:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vCzxSPy+FzZRjZn8HTA+OyQdWgf2KeAGuCfMKZTF/eE=; b=Dn5D22rdXlUC6LOdZ47CDE0REV4rkFHQYoewqEmLB5+xhG3c/URKIKSJeBu2IrTuhZ uWGsEmlBX/4jOxv/GYapduBe89+uM5VBcoGsr+icLa91eG9bxHq2Kt0WqazBmNkKZG3a NpeoGd4cycMby8azEw0+RWujKsZlXSo/YGyv4JOHV4SdyT32hJBRoc8Vk0wASWPWjyEv 0c8eyWfVuVgX+Twq5CltUZ3D3ztJ1aclyxYiKos7VTCbm/9+vQ2agPQHf22nwtCFxkg4 DZdSuJn9/W9OBEOKXbsGPlnDCqHM2+nUS1XTMOTE8zW5tOEHHSgl7zUy5GDXFlR8QivK PoVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vCzxSPy+FzZRjZn8HTA+OyQdWgf2KeAGuCfMKZTF/eE=; b=oi6ClTGrucA08grSGXY9Kq7nMklHcjKGkQPQcV/VxaIgkmJQPys8+9Z9946gPghBMr ld4T/3NFDABqBFmCs3zyFq88fyWt0sAfc6jsqWEgNpOnYk9heVGnlL77AwB6VokVK8K/ iDRv0FZDWL5M0ToTV5/UhoWlyxVl5etcxQQMXRwSPv3a0wMsNR1iRT90z1zYykAB20S2 xvtS1I2muxZ9Ay+KKDPHyMfrOj/h9Hob3jngP9ihEQHuIUAGbfTC+HaUghssjoOYID6/ 25tU1OLG53A51hIfNsnuYAUTsa8Cs8VxTK4RO1DnODlm3qQ64lVx2Xb2BBQLaN0ESFej DCCQ== X-Gm-Message-State: AJcUukfPfMtkgigThelCLRpKjhjYrhaVVSiJJ4cG8Nv14OwEaSkR6Gz0 20PA7S46SOuUea62nrEE900= X-Received: by 2002:a5d:6152:: with SMTP id y18mr17624308wrt.141.1547820220427; Fri, 18 Jan 2019 06:03:40 -0800 (PST) Received: from Red.local ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id g197sm8464676wmd.29.2019.01.18.06.03.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 06:03:39 -0800 (PST) From: Corentin Labbe To: jdelvare@suse.com, linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Corentin Labbe Subject: [PATCH 4/7] hwmon: adm1029: Add blank line after declarations Date: Fri, 18 Jan 2019 15:03:26 +0100 Message-Id: <20190118140329.18970-5-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190118140329.18970-1-clabbe.montjoie@gmail.com> References: <20190118140329.18970-1-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As requested by checkpatch, this patch adds a blank line after declarations Signed-off-by: Corentin Labbe --- drivers/hwmon/adm1029.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.19.2 diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c index 092f16ad774f..f9f4f1f4a4c7 100644 --- a/drivers/hwmon/adm1029.c +++ b/drivers/hwmon/adm1029.c @@ -171,6 +171,7 @@ show_temp(struct device *dev, struct device_attribute *devattr, char *buf) { struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); struct adm1029_data *data = adm1029_update_device(dev); + return sprintf(buf, "%d\n", TEMP_FROM_REG(data->temp[attr->index])); } @@ -180,6 +181,7 @@ show_fan(struct device *dev, struct device_attribute *devattr, char *buf) struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); struct adm1029_data *data = adm1029_update_device(dev); u16 val; + if (data->fan[attr->index] == 0 || (data->fan_div[attr->index] & 0xC0) == 0 || data->fan[attr->index] == 255) { @@ -196,6 +198,7 @@ show_fan_div(struct device *dev, struct device_attribute *devattr, char *buf) { struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); struct adm1029_data *data = adm1029_update_device(dev); + if ((data->fan_div[attr->index] & 0xC0) == 0) return sprintf(buf, "0\n"); return sprintf(buf, "%d\n", DIV_FROM_REG(data->fan_div[attr->index])); @@ -210,6 +213,7 @@ static ssize_t set_fan_div(struct device *dev, u8 reg; long val; int ret = kstrtol(buf, 10, &val); + if (ret < 0) return ret;