From patchwork Thu Jan 24 13:00:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 156476 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp1922190jaa; Thu, 24 Jan 2019 05:01:20 -0800 (PST) X-Google-Smtp-Source: ALg8bN41bI6141Wk/Ho0XHwsjnlPIgWRDDzjIy/uX3QeuNNd1mP2ugMnTNTmC3nzLc0SLMfU/qF/ X-Received: by 2002:a62:1a91:: with SMTP id a139mr6620861pfa.64.1548334880409; Thu, 24 Jan 2019 05:01:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548334880; cv=none; d=google.com; s=arc-20160816; b=mlT63ZS20Rbdf2SbVH8mtq3dDccgh4+F2Vzc5VQ0lywP/EU/l/10gGyCSKFvXWfi+g swKjkUpMK7GRwsryl7dOHY34vJxniaeueiUHzUHY9eXsva9H8EKP4C77XsGLiDpJ447L WYEhEXjnwpJ6GZic66cbLtJNKbIN8LLgOsj0EdgEOKvd+T7hfRgmzz5HnoqOh1PBZUFh vr3JaxhcP52ENWhKdkTfAEXgUBRcgJx/7WdJX6PRESq8Otar/VTwhpeQP5cHSdAYwgG6 1x5l+BjnLLSr4HFX+JiDbWHcC58m6SuCVyQrqHUxx7tpYThqXWQcDzojWRJMDC6TbcgH I5Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=g+TtSy60AE5xODphXFL+46GqeLVir41c6n923ZIZoIg=; b=WCxFbcftBP5Hk6XA6vdjIRXLtQWiupcqR0+uZwOE7F1eCKVh4fa6lmjPkHhmCP0sfZ d1RadnFSTa99dhIoRhGA41uaC4klhAlrPV02HOnxF8sAfvVZQrcmP2dBiqfXSO/M1myz t+AoMTzctMeXxD1Edv4rbS2oy+o/OVA1NfFzII5ob4lWCR4oEVJvq9yWpHpTx/z/kgJa BXAYm5i48DXnF6dfFup9Bk1l35dZSIa0f4NdMGEkwjXTrwT3WF+vMWMQqR8xw9Ys/CaK 5/gh+bosaUcoWb9aRrxttoNFql+rQFrcttAXOutqr3FndSf/U3Lsh12X145tVxR7rekH qwNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LU7rIQ0n; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k5si20904681pfj.153.2019.01.24.05.01.19; Thu, 24 Jan 2019 05:01:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LU7rIQ0n; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728268AbfAXNBN (ORCPT + 31 others); Thu, 24 Jan 2019 08:01:13 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:37164 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728040AbfAXNBL (ORCPT ); Thu, 24 Jan 2019 08:01:11 -0500 Received: by mail-lj1-f194.google.com with SMTP id t18-v6so5148545ljd.4 for ; Thu, 24 Jan 2019 05:01:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g+TtSy60AE5xODphXFL+46GqeLVir41c6n923ZIZoIg=; b=LU7rIQ0nMKaAs0DboQfj/1yr260XzcrEkZ16XvOWXQJ/4LbZwOy6yQi8x6Nz4MvM2M Hp+RK2+bGbjx2sw6/Fce9yUI017KU6dboVacGvoLQMof1hXsIf1XjAIKlGsEU8aGcOvf DyqX7s8d6vnfXfQYnSK4vrfop4944Z8PFLO74= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g+TtSy60AE5xODphXFL+46GqeLVir41c6n923ZIZoIg=; b=k/47nJhOdYE0XKs1zFxPW6VrjoaZFwK0aWA/92tpMosvt3hpWzMsUE59UmklVSsMTm 7eSfoJg0SVI4ib2wSobzSHB2vgrTzega/hHf55ioG/MuwN+JpJzcfRUEvgBM5MKAe9fF tfBNYGwYIsIekZAie/VyCGQGOcCKCngc/NdNqJTThdIICoqJv/FHQ5MvmT3GwJnFnwvA rcPabBxp6o9rgS2vQla4u413jF0BliII3LRZLVK9tj56P7b4zCFZw5wLM62Dwc0/CxVF 5ecgYPBHb0p171eytgVUNcFJuiuyvv4HEPnISOKUNmwrJS1L+CZ938Gi7DllxjCuzPop cMqg== X-Gm-Message-State: AJcUukeD3tBF/E7/W34NIkZDfPUmmqAJ7XCs8/INdWGR7mtESke3TlZn JcRXh7zTbOzB/ZWMpm4jo9pBcA== X-Received: by 2002:a2e:9e95:: with SMTP id f21-v6mr5394238ljk.128.1548334869471; Thu, 24 Jan 2019 05:01:09 -0800 (PST) Received: from centauri.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id 12-v6sm967803ljf.96.2019.01.24.05.01.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 24 Jan 2019 05:01:08 -0800 (PST) From: Niklas Cassel To: Andy Gross , David Brown , Rob Herring , Mark Rutland Cc: Niklas Cassel , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: dts: qcom: ipq4019: Fix MSI IRQ type Date: Thu, 24 Jan 2019 14:00:47 +0100 Message-Id: <20190124130047.8071-1-niklas.cassel@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The databook clearly states that the MSI IRQ (msi_ctrl_int) is a level triggered interrupt. The msi_ctrl_int will be high for as long as any MSI status bit is set, thus the IRQ type should be set to IRQ_TYPE_LEVEL_HIGH, causing the IRQ handler to keep getting called, as long as any MSI status bit is set. A git grep shows that ipq4019 is the only SoC using snps,dw-pcie that has configured this IRQ incorrectly. Not having the correct IRQ type defined will cause us to lose interrupts, which in turn causes timeouts in the PCIe endpoint drivers. Signed-off-by: Niklas Cassel --- arch/arm/boot/dts/qcom-ipq4019.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi index 19635f91e2c4..48b3cb474ba0 100644 --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi @@ -398,7 +398,7 @@ ranges = <0x81000000 0 0x40200000 0x40200000 0 0x00100000 0x82000000 0 0x40300000 0x40300000 0 0x400000>; - interrupts = ; + interrupts = ; interrupt-names = "msi"; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0x7>;