From patchwork Fri Feb 22 18:50:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 159070 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp2070988jaa; Fri, 22 Feb 2019 10:51:56 -0800 (PST) X-Google-Smtp-Source: AHgI3Ib1Nxsgw/HW6dcPoRM/63wNyvRL1DokzesR1dXGzyK1Hfljw1Z5xIOwqXQjKjEp589az+W9 X-Received: by 2002:a17:902:708b:: with SMTP id z11mr5587188plk.203.1550861516161; Fri, 22 Feb 2019 10:51:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550861516; cv=none; d=google.com; s=arc-20160816; b=oiMioIZPzsWXwdkly36+Wd21kiwjCKo0SJQCiPZhQFGb8mSbH9yQJJj8QrRv7+VNZa Z4HG3EhKWIBct0HqYrEiO4lu2LRizTQq68aJj748BInWP4+pn+zZ8WGV4BRT/PT7nQzf I2FAjQxe8e80HlaUPmZupvFZi5nczSHHQtJH9FAh3+J+O8ZQLeIYaWBICuE56SU7LJZr UGycXoz0C/LF4Cq6iwkI73ibu+mazuixp6U4mn5FXOO1gOjQ6oWDrDqZinojMy1WpiJ5 xTxkJ8HmRsEVmM0W7JwkHt3aVo9Fgvmx1r39w5BR35ytg/2UWWVbrZLA2qdyA9mB6bUz 0Psw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=mSWn8cyR9XjMSMJQTXk6ljMTsISghCN0n3Ou6TyqRFw=; b=DDnYVxFZcfgTH6t3QPN7ASv3vxh048HTf749XJwDS3UxgD/DBMVEmEpGSjBf61CJyS 7OHJGRKEg7eaaia6eUaeZPHJL+wmlTowCaTScbtqeYIVozPO/hbYyyek2RFmCXTUB/ac wNG3VDK0kw9U+Gkf6QNhzwr3+MXNKbHJxCojKVxogHy2eNSdUMwFVdrXxfusc+48Mznr AuS++X3oewXu+cCsc14+sY4Hlmgo/oya0wZT9mFLlF4Lrist9m5wRa22wZAUxMub45Ds Qrx6ZzxVekErdvXTJaAg9leBwB6doOP3JrM3JWHuB/6wqKm7/w+5Vyq5hfjOfXzg4+03 1K1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g2si2075739pfd.200.2019.02.22.10.51.55; Fri, 22 Feb 2019 10:51:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727742AbfBVSvy (ORCPT + 32 others); Fri, 22 Feb 2019 13:51:54 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:39688 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726400AbfBVSvf (ORCPT ); Fri, 22 Feb 2019 13:51:35 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2CE4119BF; Fri, 22 Feb 2019 10:51:35 -0800 (PST) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DD2AF3F5C1; Fri, 22 Feb 2019 10:51:31 -0800 (PST) From: Will Deacon To: linux-arch@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Will Deacon , "Paul E. McKenney" , Benjamin Herrenschmidt , Michael Ellerman , Arnd Bergmann , Peter Zijlstra , Andrea Parri , Palmer Dabbelt , Daniel Lustig , David Howells , Alan Stern , Linus Torvalds , "Maciej W. Rozycki" , Paul Burton , Ingo Molnar , Yoshinori Sato , Rich Felker , Tony Luck Subject: [RFC PATCH 17/20] scsi: qla1280: Remove stale comment about mmiowb() Date: Fri, 22 Feb 2019 18:50:23 +0000 Message-Id: <20190222185026.10973-18-will.deacon@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190222185026.10973-1-will.deacon@arm.com> References: <20190222185026.10973-1-will.deacon@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All mmiowb() invocations have been removed, so there's no need to keep banging on about it. Signed-off-by: Will Deacon --- drivers/scsi/qla1280.c | 10 ---------- 1 file changed, 10 deletions(-) -- 2.11.0 diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c index 93acbc5094f0..327eff67a1ee 100644 --- a/drivers/scsi/qla1280.c +++ b/drivers/scsi/qla1280.c @@ -3363,16 +3363,6 @@ qla1280_isp_cmd(struct scsi_qla_host *ha) /* * Update request index to mailbox4 (Request Queue In). - * The mmiowb() ensures that this write is ordered with writes by other - * CPUs. Without the mmiowb(), it is possible for the following: - * CPUA posts write of index 5 to mailbox4 - * CPUA releases host lock - * CPUB acquires host lock - * CPUB posts write of index 6 to mailbox4 - * On PCI bus, order reverses and write of 6 posts, then index 5, - * causing chip to issue full queue of stale commands - * The mmiowb() prevents future writes from crossing the barrier. - * See Documentation/driver-api/device-io.rst for more information. */ WRT_REG_WORD(®->mailbox4, ha->req_ring_index);