From patchwork Fri Mar 1 14:03:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 159495 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp770475jad; Fri, 1 Mar 2019 06:05:10 -0800 (PST) X-Google-Smtp-Source: APXvYqzxFLqZn/TUzFfwUEV/ZPi1OCikEDx8tR30SAjJV6vzSNuLRwfQn6IatFnGEOQPm8bcWS7o X-Received: by 2002:a17:902:284b:: with SMTP id e69mr5462125plb.11.1551449110251; Fri, 01 Mar 2019 06:05:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551449110; cv=none; d=google.com; s=arc-20160816; b=RlI22nfM5BZTlNnOkkL/0IjwNNq08qHDUTAkt8WlIHRlL2uXHiDGcijyWe9fUo/7RX +Ws5fmcpqhVKDE+gc0qF+2vOBK+lr28tWnmT4iRjBiA4Cbch+hcC8Np1pSF+nIS9WmuC LzExBeqSjjbhveodLwwlt/Xz70fU4NU0CAIsp2QWO32tz6WryRANjFKuw7bfGz9MOe/6 OzIv3Dm7CjW1/D8FG8gWppMG6eyllw8MWltmZ/M6a8oeac2JEqkWoBSQtb52nf0v/AkJ JyzoGWrtbYrxEBzQHBhSNqMJtQ3xF4uXHi2zpwkjo4mNA0tXKPI7lX0MHTj+kg0EvkA1 +LRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=mSWn8cyR9XjMSMJQTXk6ljMTsISghCN0n3Ou6TyqRFw=; b=NcG+EYIJOsgeQ77PVBRqamUSw5wFwhS4yK8lE8Y4sRbmGwyL0rgPfsZiF3EUURp6Ff UvBsorh67MH06Xg+n1kPBKHXgQVsVJymvYYm+n0vhoKwb6yeVuj+IqJ0SiOz+eA37+sI xhl66zwMt2o2Vf+EejSLKq5suv8EfxPZuSVg/COIHotGk+bNb5pq0fRHWdd7DfExPl+9 vdUAuWDz5gYwma2xjHksSrAxITuPNhO+vkyYcRJqETMwvRJwtd1UZ4qiEPaUgB5Jy++a Im8+9iQOc6/aytPGA6im9bBLJPoacX8/EHn8cr82nf5NFa2cHnh8a9P2vn3vY+utaXNL 3vaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e9si2694568pgs.450.2019.03.01.06.05.09; Fri, 01 Mar 2019 06:05:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388648AbfCAOFH (ORCPT + 31 others); Fri, 1 Mar 2019 09:05:07 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:36142 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387833AbfCAOFC (ORCPT ); Fri, 1 Mar 2019 09:05:02 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0DCB31C14; Fri, 1 Mar 2019 06:05:02 -0800 (PST) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B3FD23F720; Fri, 1 Mar 2019 06:04:58 -0800 (PST) From: Will Deacon To: linux-arch@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Will Deacon , "Paul E. McKenney" , Benjamin Herrenschmidt , Michael Ellerman , Arnd Bergmann , Peter Zijlstra , Andrea Parri , Palmer Dabbelt , Daniel Lustig , David Howells , Alan Stern , Linus Torvalds , "Maciej W. Rozycki" , Paul Burton , Ingo Molnar , Yoshinori Sato , Rich Felker , Tony Luck Subject: [PATCH 17/20] scsi/qla1280: Remove stale comment about mmiowb() Date: Fri, 1 Mar 2019 14:03:45 +0000 Message-Id: <20190301140348.25175-18-will.deacon@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190301140348.25175-1-will.deacon@arm.com> References: <20190301140348.25175-1-will.deacon@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All mmiowb() invocations have been removed, so there's no need to keep banging on about it. Signed-off-by: Will Deacon --- drivers/scsi/qla1280.c | 10 ---------- 1 file changed, 10 deletions(-) -- 2.11.0 diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c index 93acbc5094f0..327eff67a1ee 100644 --- a/drivers/scsi/qla1280.c +++ b/drivers/scsi/qla1280.c @@ -3363,16 +3363,6 @@ qla1280_isp_cmd(struct scsi_qla_host *ha) /* * Update request index to mailbox4 (Request Queue In). - * The mmiowb() ensures that this write is ordered with writes by other - * CPUs. Without the mmiowb(), it is possible for the following: - * CPUA posts write of index 5 to mailbox4 - * CPUA releases host lock - * CPUB acquires host lock - * CPUB posts write of index 6 to mailbox4 - * On PCI bus, order reverses and write of 6 posts, then index 5, - * causing chip to issue full queue of stale commands - * The mmiowb() prevents future writes from crossing the barrier. - * See Documentation/driver-api/device-io.rst for more information. */ WRT_REG_WORD(®->mailbox4, ha->req_ring_index);