From patchwork Thu Mar 7 10:11:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 159820 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp7250440jad; Thu, 7 Mar 2019 02:12:39 -0800 (PST) X-Google-Smtp-Source: APXvYqwgpWUzI8QVnaUllJ/mIIeSxohpkqOiexRVHWjBOMJZLEBY1CIgDznNwD2Xv9fQRtNP4ail X-Received: by 2002:a17:902:9683:: with SMTP id n3mr12186886plp.333.1551953559655; Thu, 07 Mar 2019 02:12:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551953559; cv=none; d=google.com; s=arc-20160816; b=K7NvYhTnE1rsRYSFgujkwvSqsQkpkl7RMQi8tDpjEPXVbsUx5+Qa5ngQH460TG088y sgTLmwEzy0Kl2uXvFmfXGc997o2RwVGbMtHdnW9VIulyOIlx6AP4s1djHsgInkCHzCRo m5vQxZBApLB5ONHdOSGilmzMXR/9M/y/GJFvb4MqyC8eCeqFAhNtV+M9kkAkwJkTaoc+ jjrA/U0eolZ6059cqXIMo1nZSU16iNBTA0OwhsFYUij1r8o0vQs9BBTTbUpPuoozcUyl JlBcpqDMbHOutW9XYCKAjkb8nKz/rQDvav4SCNrtcGL2ogZbyI6vzD7+hRF7WGDrtVSv Vinw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=+uq3WkzugcI3QFD+4n+Z1IR7bPjuxrCkWv1MrLVgbM4=; b=Ypmv9f1F61Bp1pIHdwPa/kTl9earPCp/N2DFYnnJHyQF+WDPDF3XlwZzpdszVPpvUJ EOWwhYoWWVVTW1LSqFsZTPLvaq4zHTDvxdfROm1s7wxkRjZIaKiHqYvEqTHHILU67IpF SXDtYFfKb5mzDoup6vX+0UjNYhmdoY3dMZ38rMFhkyceVuvWDk0cAqq5hIPgKzRDj/ov fpXc+pM459AbnEtFqe08pMrz1ga5cjimYWRXN6J843ZNmJvB45jjwTS1hfJ3lOloIvTE Vjxs8qbDyY4yAwzUnmsfTVdjqJEA1OJiZvzqi7F0mNycYnP3orPvBrXd3Sy5oh4aAWjf kH7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p25si3957312pff.77.2019.03.07.02.12.39; Thu, 07 Mar 2019 02:12:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726388AbfCGKMh (ORCPT + 31 others); Thu, 7 Mar 2019 05:12:37 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:50225 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726131AbfCGKMh (ORCPT ); Thu, 7 Mar 2019 05:12:37 -0500 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.129]) with ESMTPA (Nemesis) id 1MpDRv-1gjnOl0S9X-00qi2m; Thu, 07 Mar 2019 11:11:48 +0100 From: Arnd Bergmann To: Peter Ujfalusi , Mark Brown Cc: Nick Desaulniers , Arnd Bergmann , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Tony Lindgren , Kees Cook , Vishal Thanki , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: davinci-mcasp: Fix clang warning without CONFIG_PM Date: Thu, 7 Mar 2019 11:11:30 +0100 Message-Id: <20190307101145.636705-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:k4DDxjibd8u11zOsPD7lZAVg/Zeo4oJO0PYetGd3gbXntL9v0Hc AYtFbBGvYEPhSGEF457096RqdOSZCEXJSDK9RIET+JNa1sOOrp1M/Ai9XyzwTqSEhx0mhKR 7Qpt40zFtoHG0j1rIpitct4VODtmyMd2xy5FChig9UsOOf0e62GXl7TsyuFHDtIWDBTST6A 7Ym+9KSwolmfdC7krcf0w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:aUhG0xnewKU=:uMK/tCaRRGiBWJ22FZMROg mUaoGPAR2iN9yXx0MVBRtC7A3d8qiEgyCY4chbEok1tZrhqgt38+94ydS1uRsTmfM9TKR3a+8 CE90Pr42BbHOzx3RngXMighOOetzJcA+l3oHqnFP0O6sKQwyn3kVUFmE48OlapO59DOYEEfA+ IFn2cNK/UbrrE/iltMMfzpszLUlJRgXCFPIBrtGKgybzhScpwQ+SWDtvWAJXSY+x0SXPJgksk d6u9L6QrWdH0vL9GujyHbM5HCpeEP/4mfE6zvmb4KF3JmSM1jYjNC3RWmdeOHwir7xuWPhZNR 0azzbsFMJg+QSlzF9JPkRxy6YZc/6cP8BimW+PMAmkBuh37s9R4OVw9XvqeLMnIcOXCbGLJ8g rpsEMOMxxkzIn46wJt+2v7xYAPuYZ8EVl4PzNLOnE3RUGFEieIN2CLI0CTv+7R2Fp26P9uxaI 5DoXMe1pTkxPYeDr3nDANmfNDnIc3ea27i1KhVpYLAyCDoUx2GiYwlPt+UscNvFs5ybCFFqCW mpg9y9j1GZeybeygtK+N1tq69JSpkH8o+ff6dDJPOaXrKb1DrHoUAdtvy4V5F4RaEYwrd0cvL EU1tIDpwyXKC1bHyGnaxB6WC2z7sdkDwgRUQy5pjp126kXaNqP/I9BwjNr5WCvgVLTeSYo3i0 M+CPXekxc5aBbB/uPZed50KW0UhcJjdZl9pKngxqJ3Q2+qDRUZAO1QM/E9DmQwS590S7DV9wL A9aVHX9iVYOKXodCV6+lJudSK8cI66xkTWkn7A== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Building with clang shows a variable that is only used by the suspend/resume functions but defined outside of their #ifdef block: sound/soc/ti/davinci-mcasp.c:48:12: error: variable 'context_regs' is not needed and will not be emitted We commonly fix these by marking the PM functions as __maybe_unused, but here that would grow the davinci_mcasp structure, so instead add another #ifdef here. Fixes: 1cc0c054f380 ("ASoC: davinci-mcasp: Convert the context save/restore to use array") Signed-off-by: Arnd Bergmann --- sound/soc/ti/davinci-mcasp.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.20.0 Acked-by: Peter Ujfalusi Reviewed-by: Nathan Chancellor diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c index a3a67a8f0f54..9fbc759fdefe 100644 --- a/sound/soc/ti/davinci-mcasp.c +++ b/sound/soc/ti/davinci-mcasp.c @@ -45,6 +45,7 @@ #define MCASP_MAX_AFIFO_DEPTH 64 +#ifdef CONFIG_PM static u32 context_regs[] = { DAVINCI_MCASP_TXFMCTL_REG, DAVINCI_MCASP_RXFMCTL_REG, @@ -68,6 +69,7 @@ struct davinci_mcasp_context { u32 *xrsr_regs; /* for serializer configuration */ bool pm_state; }; +#endif struct davinci_mcasp_ruledata { struct davinci_mcasp *mcasp;