From patchwork Tue Apr 23 09:02:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 162671 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp3541327jan; Tue, 23 Apr 2019 02:03:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqxSKynzCWcSoMbBIpdD+sKZyM0lNtDNQLi7a0xN00TgbpxmYo3EMw+MbD0oMoQYzGoNC4ao X-Received: by 2002:a63:180a:: with SMTP id y10mr23340362pgl.450.1556010198406; Tue, 23 Apr 2019 02:03:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556010198; cv=none; d=google.com; s=arc-20160816; b=nl05ANbGQioG3YKBy5nk3AchjBtKkGkgVdHFUBcuRvs1rhLspcG9hAbvNFNTv3QhhO OVErZ2OVNjBHy46Zg0OD5i0qOWMpyG9z8cZpLO4EaL1r2iyiLpXZYp1Ouo393rz/De9s 8LVzSaz0iJjRJIWfBj+XjWUZUeqspaLxo2SuVWCK9K675alUx8uuXVKrXd17If2WsQB2 pFMmFzLxBh26UaUc5w2eImxqoteiRaGobzjIDMLrKH46UV2a+dOe0GbhpZ7ReqNVQ4sD M2VGjvftAAYqN6RdCKpRIejiSv1IHTaQCzy8xHwAmwjHvlHca4+gYisANZ2D4aIf7GJm wjBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=w1pW48pbPFvZbhJkwoKxPVapl0Fl2yGEGKo5zLNjkdw=; b=SfGDZgPkeKoQyqB6heqse5WILsQTYYJFoNB51hZHPmBqMelth+61tRwII+gVojv/+I Qmy3lb3W5lb2XEI6B53k/raheSSvRH1SwWUuNx3vsIaQr4qtfUUXiKdXWODCuBnJXhVk 33jhGkSwJX0dzEwk73tC5DWXYfW/nAT4fRV3Uz4XBuQAwmhh9y/K1YSO/MpiaGTsoB7B sIL/CBBxPciw5WXUc3/Wypo6nLDh0pDtGoP93LWaVVshinXCWxlERPi82R4nzo2HNAbR aTZ7FyNflCpE4FwpCd56Z+V1vktVbrz+QrSyRevMx7/FYPTwggVZbPcX8ROcUEw10nCs +Eag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=0CRtXmBu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i9si2022200pgl.571.2019.04.23.02.03.18; Tue, 23 Apr 2019 02:03:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=0CRtXmBu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727114AbfDWJCv (ORCPT + 30 others); Tue, 23 Apr 2019 05:02:51 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:35028 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726608AbfDWJCs (ORCPT ); Tue, 23 Apr 2019 05:02:48 -0400 Received: by mail-wm1-f67.google.com with SMTP id y197so17794582wmd.0 for ; Tue, 23 Apr 2019 02:02:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w1pW48pbPFvZbhJkwoKxPVapl0Fl2yGEGKo5zLNjkdw=; b=0CRtXmBu8o8LrKmAYE/sKRtheqjZAWj3UgypeINdpuSrpGNjH3EQKerJ+HyxR/+FTG Zp5uBMcs29yn/DaNQUqyYDg/IkVtX4U/o7gddZfA9w/7rS6uCFRnJ2s2ubM8u30AGIi2 clgE2Gwb8zHddinILtYdLIce/IiGEU68JPc2mZVYXnsPx1kwuNJDWDfDmWdh9Qqy/hdV F3617T0lI1T+MlUHawgS2qHBdqSYcIX8t9GSHuQNXtmDqF1dp328G+t/YcxMGZ1pDlvG Ac4kyDTTAugznAgDZXTKGRnVqxV1RPTHDaxU4CK5ZCNg6LPpLcxISp8yVsyv//Dz+hYE RRfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w1pW48pbPFvZbhJkwoKxPVapl0Fl2yGEGKo5zLNjkdw=; b=bBqZ7a6nMUjAupLCRceIRHqWWvg/VR2Cdut8jq4ZN8M3G7b8E6EQqJrFkATDECikAG L3BLJlNwgiEzTTTPxRo2Iap2WV039AAewYm2nrJnGjR0eFxsCn/Nwsaw78NcZg3BZIaN n0titE5HIlTF4xMda6hIZW7DN8W3ZhQiMaSAvvubLN2cLIvX7er0m1H7WDSbbopamIBp yhBVLC/KSx+X4a7NXBqVxCJs/i83JMG+HRyx5lIMbDeYutqRBTkOfeO2hm03vZd3D703 XqN6NgC9gIWGpsehrkDVxStto8u6KTN9c1NHHk4retl7n0zfvUsGU22ibDDnczcOT4Zj wnCw== X-Gm-Message-State: APjAAAXYp5Ij9E96aLsFjbIpIqvvvQpL8gj2LjP3fpwZhGISVAOF3ub4 9kXPvFOgxzXEurQzgQ+6P2O9p+9jWEg= X-Received: by 2002:a7b:c1cf:: with SMTP id a15mr1556030wmj.44.1556010166990; Tue, 23 Apr 2019 02:02:46 -0700 (PDT) Received: from boomer.local (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id z23sm12361894wma.0.2019.04.23.02.02.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Apr 2019 02:02:46 -0700 (PDT) From: Jerome Brunet To: Ulf Hansson , Kevin Hilman Cc: Jerome Brunet , linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/7] mmc: meson-gx: ack only raised irq Date: Tue, 23 Apr 2019 11:02:30 +0200 Message-Id: <20190423090235.17244-3-jbrunet@baylibre.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190423090235.17244-1-jbrunet@baylibre.com> References: <20190423090235.17244-1-jbrunet@baylibre.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is merely a clean up. It makes sense to only ack raised irqs instead of acking everything all the time. Signed-off-by: Jerome Brunet --- drivers/mmc/host/meson-gx-mmc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.20.1 diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index 2deeacc051b1..8b690ecde4c5 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -1082,9 +1082,6 @@ static irqreturn_t meson_mmc_irq(int irq, void *dev_id) } out: - /* ack all enabled interrupts */ - writel(irq_en, host->regs + SD_EMMC_STATUS); - if (cmd->error) { /* Stop desc in case of errors */ u32 start = readl(host->regs + SD_EMMC_START); @@ -1096,6 +1093,9 @@ static irqreturn_t meson_mmc_irq(int irq, void *dev_id) if (ret == IRQ_HANDLED) meson_mmc_request_done(host->mmc, cmd->mrq); + /* ack all raised interrupts */ + writel(status, host->regs + SD_EMMC_STATUS); + return ret; }