From patchwork Thu May 9 07:35:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 163695 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:142:0:0:0:0 with SMTP id j2csp618017ilr; Thu, 9 May 2019 00:36:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqwvKxbyJkJzTfKHdHhBd5mSb9Wq9+vHZYRTsLKv0ek8+U3oIR2l679Lq/AipCRIuxiOHVjw X-Received: by 2002:a63:5322:: with SMTP id h34mr3507017pgb.413.1557387391239; Thu, 09 May 2019 00:36:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557387391; cv=none; d=google.com; s=arc-20160816; b=hpKbUOV4Jc4lOSXfVDwc06ObDm3OQQ6JSg1BG5wjeHRoD7clAq+iFV3kJ+keecns7C Sl6QN/gMXRFzqVgrAoLnKthmgPKt3z8DMw8t/btAxD0ucAV7PQctbE6TjQULVPPV/P18 XgG9THM2MzoUAU6ImPAMQ1gIj92vRzXAXVpttxXEqEr1i1XuK4yU0Mqfat6Ce3PQVFin 3HIA5vR/4Vosb7xTTpyw2EXg7LNpHdci4e99r9V4Q+2qzgMtVn1cqwL3LXNcC8JV6CSZ uTu3+5sXaGgS28agoPyLnH3OhzVQKR/azn8F/ufSG94JNWPH1rz7rZIYW3B9IEXGUSIo dH8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=WvsKxYjmrZ0o9zogyEYzJJvBoltHq2gquWxe1gHwrUc=; b=ZTZkEIQ9xqyjlISWGv0I6qZMJY8njHFDJWLbM2BWa4+OntmWUx3+FzdjgN2sAeq7cc YGqOIjIT77ER9oEHVIsbvXOn5dmunzekKPAKmUN7mnXJSU/OXJdofBABia/DFBfwtqIi KG9J9LStVY3l5r/2F5sgKzl1a9CAtWYuHwLehdomyq/Q0PSbF5B3v+WFxHVJuGIiegOx DwV1zlLs3itxwcoy8Ja165fgdrHnEmysBSyFVq9RkLQ1WQ39fsc3vVI9tPl7FQw5LOwO /JVQUh83yFONkA49JvboI7z9pTz5dYsRTqL5goKqBhFGvz7Gx7RF7dRT5anxA8/iLmYd ILHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=cpV4dHle; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e193si1855441pgc.339.2019.05.09.00.36.30; Thu, 09 May 2019 00:36:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=cpV4dHle; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726650AbfEIHg3 (ORCPT + 30 others); Thu, 9 May 2019 03:36:29 -0400 Received: from conuserg-11.nifty.com ([210.131.2.78]:29879 "EHLO conuserg-11.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725940AbfEIHg3 (ORCPT ); Thu, 9 May 2019 03:36:29 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-11.nifty.com with ESMTP id x497a876027332; Thu, 9 May 2019 16:36:08 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com x497a876027332 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1557387369; bh=WvsKxYjmrZ0o9zogyEYzJJvBoltHq2gquWxe1gHwrUc=; h=From:To:Cc:Subject:Date:From; b=cpV4dHleODex4lgIfIxVwNfYJJEtBo43pLaA/Q9t8GWvQgeRihIoS6kAxsi11IX2V aBvELu+ReG0iOkTZ/PORlvSmyGKDkn+B6HUbcLUl9Iui6BHLKeY1KnyFHDXprvEbmC tDh1MGztCrDKncS4JnDqhaO3jP9G1s4A0n0VobzIR0CKa9AT+QT9WoNvUmN+S68yu4 /ap3fmIkrs4oioU2uRgpfGnhLdmw578XbsNwY2ZJFYDkCsXgr2dWizSIsz9z1Oy0GM A6BGU2TiCQ3IDcZ7I+E5y6U8w1HL7SD9JZmDjwI4VDhLNPPKkvKm92a7P1jVDdJ7f1 7+0fsu/TDbLIA== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Joel Stanley , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH] kbuild: terminate Kconfig when $(CC) or $(LD) is missing Date: Thu, 9 May 2019 16:35:55 +0900 Message-Id: <20190509073555.15545-1-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the compiler specified by $(CC) is not present, the Kconfig stage sprinkles 'not found' messages, then succeeds. $ make CROSS_COMPILE=foo defconfig /bin/sh: 1: foogcc: not found /bin/sh: 1: foogcc: not found *** Default configuration is based on 'x86_64_defconfig' ./scripts/gcc-version.sh: 17: ./scripts/gcc-version.sh: foogcc: not found ./scripts/gcc-version.sh: 18: ./scripts/gcc-version.sh: foogcc: not found ./scripts/gcc-version.sh: 19: ./scripts/gcc-version.sh: foogcc: not found ./scripts/gcc-version.sh: 17: ./scripts/gcc-version.sh: foogcc: not found ./scripts/gcc-version.sh: 18: ./scripts/gcc-version.sh: foogcc: not found ./scripts/gcc-version.sh: 19: ./scripts/gcc-version.sh: foogcc: not found ./scripts/clang-version.sh: 11: ./scripts/clang-version.sh: foogcc: not found ./scripts/gcc-plugin.sh: 11: ./scripts/gcc-plugin.sh: foogcc: not found init/Kconfig:16:warning: 'GCC_VERSION': number is invalid # # configuration written to .config # Terminate parsing files immediately if $(CC) or $(LD) is not found. "make *config" will fail more nicely. $ make CROSS_COMPILE=foo defconfig *** Default configuration is based on 'x86_64_defconfig' scripts/Kconfig.include:34: compiler 'foogcc' not found make[1]: *** [scripts/kconfig/Makefile;82: defconfig] Error 1 make: *** [Makefile;557: defconfig] Error 2 Signed-off-by: Masahiro Yamada --- Makefile | 2 +- scripts/Kconfig.include | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) -- 2.17.1 diff --git a/Makefile b/Makefile index 28965187c528..bd7ae11947cb 100644 --- a/Makefile +++ b/Makefile @@ -537,7 +537,7 @@ endif # Some architectures define CROSS_COMPILE in arch/$(SRCARCH)/Makefile. # CC_VERSION_TEXT is referenced from Kconfig (so it needs export), # and from include/config/auto.conf.cmd to detect the compiler upgrade. -CC_VERSION_TEXT = $(shell $(CC) --version | head -n 1) +CC_VERSION_TEXT = $(shell $(CC) --version 2>/dev/null | head -n 1) ifeq ($(config-targets),1) # =========================================================================== diff --git a/scripts/Kconfig.include b/scripts/Kconfig.include index 87ff1dcc6bd5..0b267fb27f07 100644 --- a/scripts/Kconfig.include +++ b/scripts/Kconfig.include @@ -18,6 +18,10 @@ if-success = $(shell,{ $(1); } >/dev/null 2>&1 && echo "$(2)" || echo "$(3)") # Return y if exits with 0, n otherwise success = $(if-success,$(1),y,n) +# $(failure,) +# Return n if exits with 0, y otherwise +failure = $(if-success,$(1),n,y) + # $(cc-option,) # Return y if the compiler supports , n otherwise cc-option = $(success,$(CC) -Werror $(1) -E -x c /dev/null -o /dev/null) @@ -26,5 +30,9 @@ cc-option = $(success,$(CC) -Werror $(1) -E -x c /dev/null -o /dev/null) # Return y if the linker supports , n otherwise ld-option = $(success,$(LD) -v $(1)) +# check if $(CC) and $(LD) exist +$(error-if,$(failure,command -v $(CC)),compiler '$(CC)' not found) +$(error-if,$(failure,command -v $(LD)),linker '$(LD)' not found) + # gcc version including patch level gcc-version := $(shell,$(srctree)/scripts/gcc-version.sh $(CC))