From patchwork Wed May 15 09:16:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 164266 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp510852ili; Wed, 15 May 2019 02:18:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqwEhmHm5XriUDNEQ2RJjZ3eQCi/KltEje2g/2iZu5zrMMVfOs9vCfgbKDE5AqKUZJoBdZpz X-Received: by 2002:a62:7d10:: with SMTP id y16mr46138486pfc.116.1557911899930; Wed, 15 May 2019 02:18:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557911899; cv=none; d=google.com; s=arc-20160816; b=dhXr79oiN5z3NSf1cLwPNu7DwO7fNlLSGb5XxM4v1DoFLnmm+ZCf/Y/6A7l0Exrvh9 19IW+fJ36CMWbq+djT5jbyKuhfiDox85Ck1bzHPhpequliQgKX3A0IN86Iq3w55fu48t p2JhfZEpWsiUcq2kZptvOjrrsOfSHDlaoKKHH0O9bqMgedtfo5bfGyNZ1wscXcgIySSa l8Lb2OXmTalyo/Y2Ydu4MtdTFjqH7IU+MaY1hOc0ar7fw1Pve3hZ6T12ZW5BZK3Cl3o8 WrlFKC9xoQ5aNsRzqjbXNp/KM+/a3c8xvVc8rJiFklVK7Z/0WU0RoxfvBfOyDBJrgXh0 GdUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=eQHuOwE/b9F/mxBiHP62sHrStEC5e25dADLb8lRvQz0=; b=U7Oh5n3J6R+uCvUltq7G0UX/JVL25QOWqmAhFP1bdNYGYsNvWbxonHgATNTHMLxwO8 moxGaHalYiO+/7GuA9ASHY/XGVdK7F6AcU7vFBIMVGl0u1TpQ1LsjVNFRiSzm9kR9s5w gTp6ZYmTVBXWCwJFp82jxSeGdwlfXzQ4Gri9G39u+R9pE5JLrRaRfWYKwiIcRFSIgT13 A7IKhvzFnDWuQH/9Cyk2rZ33qkyqQ0zWzwdym9fAWscBiw/znflxAuOxEzT8SfyYEde1 ArfftIcM4hiicZ1ohSbqLU3BLseOFbtxRgaNPk8QTCCrlndSV/dPCVpyIcyoRjFaY4MZ f6bg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m1si1439939pgt.93.2019.05.15.02.18.19; Wed, 15 May 2019 02:18:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726286AbfEOJSS (ORCPT + 30 others); Wed, 15 May 2019 05:18:18 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:8194 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725912AbfEOJSR (ORCPT ); Wed, 15 May 2019 05:18:17 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 339C08B7995CE51A24C9; Wed, 15 May 2019 17:18:15 +0800 (CST) Received: from FRA1000014316.huawei.com (100.126.230.97) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.439.0; Wed, 15 May 2019 17:18:04 +0800 From: Jonathan Cameron To: CC: Wen Yang , Catalin Marinas , Will Deacon , , , Jonathan Cameron Subject: [PATCH 07/60] arm64: cpu_ops: fix a leaked reference by adding missing of_node_put Date: Wed, 15 May 2019 17:16:44 +0800 Message-ID: <20190515091737.18578-7-Jonathan.Cameron@huawei.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190515091737.18578-1-Jonathan.Cameron@huawei.com> References: <20190515091737.18578-1-Jonathan.Cameron@huawei.com> MIME-Version: 1.0 X-Originating-IP: [100.126.230.97] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wen Yang The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./arch/arm64/kernel/cpu_ops.c:102:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 69, but without a corresponding object release within this function. Signed-off-by: Wen Yang Reviewed-by: Florian Fainelli Cc: Catalin Marinas Cc: Will Deacon Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Will Deacon Signed-off-by: Jonathan Cameron --- arch/arm64/kernel/cpu_ops.c | 1 + 1 file changed, 1 insertion(+) -- 2.19.1 diff --git a/arch/arm64/kernel/cpu_ops.c b/arch/arm64/kernel/cpu_ops.c index ea001241bdd47..00f8b8612b69f 100644 --- a/arch/arm64/kernel/cpu_ops.c +++ b/arch/arm64/kernel/cpu_ops.c @@ -85,6 +85,7 @@ static const char *__init cpu_read_enable_method(int cpu) pr_err("%pOF: missing enable-method property\n", dn); } + of_node_put(dn); } else { enable_method = acpi_get_enable_method(cpu); if (!enable_method) {