| Message ID | 20190517075428.13496-2-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | f1090b61a76f4af523418a4ff3de4324ae72ec47 |
| Headers | show |
| Series | [1/4] s390: do not pass $(LINUXINCLUDE) to gen_opcode_table.c | expand |
On Fri, May 17, 2019 at 04:54:25PM +0900, Masahiro Yamada wrote: > The top level Makefile adds -Wall globally for all host tools: > > KBUILD_HOSTCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 \ > > I see two "-Wall" added for compiling these tools. > > Of course, it is allowed to pass the same option multiple times, but > we do not need to do so. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > arch/s390/tools/Makefile | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile > index 4ff6a2124522..8fb66c99840a 100644 > --- a/arch/s390/tools/Makefile > +++ b/arch/s390/tools/Makefile > @@ -14,8 +14,7 @@ kapi: $(kapi-hdrs-y) > hostprogs-y += gen_facilities > hostprogs-y += gen_opcode_table > > -HOSTCFLAGS_gen_facilities.o += -Wall $(LINUXINCLUDE) > -HOSTCFLAGS_gen_opcode_table.o += -Wall > +HOSTCFLAGS_gen_facilities.o += $(LINUXINCLUDE) Applied, thanks.
diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile index 4ff6a2124522..8fb66c99840a 100644 --- a/arch/s390/tools/Makefile +++ b/arch/s390/tools/Makefile @@ -14,8 +14,7 @@ kapi: $(kapi-hdrs-y) hostprogs-y += gen_facilities hostprogs-y += gen_opcode_table -HOSTCFLAGS_gen_facilities.o += -Wall $(LINUXINCLUDE) -HOSTCFLAGS_gen_opcode_table.o += -Wall +HOSTCFLAGS_gen_facilities.o += $(LINUXINCLUDE) # Ensure output directory exists _dummy := $(shell [ -d '$(kapi)' ] || mkdir -p '$(kapi)')
The top level Makefile adds -Wall globally for all host tools: KBUILD_HOSTCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 \ I see two "-Wall" added for compiling these tools. Of course, it is allowed to pass the same option multiple times, but we do not need to do so. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- arch/s390/tools/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.17.1