| Message ID | 20190517075428.13496-4-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 10077c9f2dae1afabab2808a0326ecf3e8e5a82c |
| Headers | show |
| Series | [1/4] s390: do not pass $(LINUXINCLUDE) to gen_opcode_table.c | expand |
On Fri, May 17, 2019 at 04:54:27PM +0900, Masahiro Yamada wrote: > 'targets' should be specified to include .*.cmd files to evaluate > if_changed or friends. > > Here, facility-defs.h and dis-defs.h are generated by filechk. > > Because filechk does not generate .*.cmd file, the 'targets' addition > is meaningless. The filechk correctly updates the target when its > content is changed. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > arch/s390/tools/Makefile | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile > index 4864ea5e6ceb..b5e35e8f999a 100644 > --- a/arch/s390/tools/Makefile > +++ b/arch/s390/tools/Makefile > @@ -6,7 +6,6 @@ > kapi := arch/$(ARCH)/include/generated/asm > kapi-hdrs-y := $(kapi)/facility-defs.h $(kapi)/dis-defs.h > > -targets += $(addprefix ../../../,$(kapi-hdrs-y)) Applied, thanks.
diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile index 4864ea5e6ceb..b5e35e8f999a 100644 --- a/arch/s390/tools/Makefile +++ b/arch/s390/tools/Makefile @@ -6,7 +6,6 @@ kapi := arch/$(ARCH)/include/generated/asm kapi-hdrs-y := $(kapi)/facility-defs.h $(kapi)/dis-defs.h -targets += $(addprefix ../../../,$(kapi-hdrs-y)) PHONY += kapi kapi: $(kapi-hdrs-y)
'targets' should be specified to include .*.cmd files to evaluate if_changed or friends. Here, facility-defs.h and dis-defs.h are generated by filechk. Because filechk does not generate .*.cmd file, the 'targets' addition is meaningless. The filechk correctly updates the target when its content is changed. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- arch/s390/tools/Makefile | 1 - 1 file changed, 1 deletion(-) -- 2.17.1