From patchwork Tue May 21 04:03:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 164673 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp1096846ili; Mon, 20 May 2019 21:04:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqxx/ppMztgDMFrjZXi6AN1+HGRfCwngZ7Ahb8BwHlVSxjMuF643QwDWD9GopdeolSFJIS4G X-Received: by 2002:a62:bd11:: with SMTP id a17mr758944pff.126.1558411457925; Mon, 20 May 2019 21:04:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558411457; cv=none; d=google.com; s=arc-20160816; b=xJnGfK/o7ndazkFlvcc4+azGHj0hJbxekiOML2tSlfcUVjPy7i/JovdgQGcnah/iZw /mvUqX98txtDIUG7oN2WaSn6XJfOJseRyx8Z5lzhToFi3C4U5nVC3xanBRNSBDJPdJWB BoaZA1DVbEUkTAAnod88s9mx8CNy9OPYBct+67uT4m/SxbwongLXLYa94G+WVOFqnexP OqXBLE0DIVkjZMq92tqF4d2cU3zzL1jjbss5JTADZthOH1q0ZeC6Ae5QDBy7f5HQiIPL /KEjLsFaPfymu+WFvnOzVayXJf2QHxZ4Owdjxyatzs952Huo+6D5aHupUuQ6Yrw0l6YB R9vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=ih2ZgqObaUdBXIDdXtMeo+bCR3hhcOxpcDhp2NN3U6o=; b=WYdOMjdQRB0DI11jkjHKbnJQEWxmVtTUr2o6S2Xj0pxpwZX8GEytafniK/lTnEd3Lm fQVEQTr70+DzUHUHYc78vUvY3PKHWF33MJKr2zPIUNPiqeSfPzI/fjpUvlUjOTl92vBn m+cB0oC39i8i1JvFSV2lxF0iKf3q8POhRUMP5pL3yirqZaZl/rKFomF/xp8EHPqOVbz1 +yOUM5Ogtta6A4TH0L361M4pZ0YasSiGEoj0HY8CdW1OotHTaMEvxNIWY+X3E0siuDBh f+pnpmdW0uE+FvdcK05i3zJ/4z/O0o8TzTVehAczzmbLJSBeQuyXU+F7qFTzDG2dTkjF HQfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=yLwaFzBs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h25si20900232pfn.209.2019.05.20.21.04.17; Mon, 20 May 2019 21:04:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=yLwaFzBs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726022AbfEUEEQ (ORCPT + 30 others); Tue, 21 May 2019 00:04:16 -0400 Received: from conuserg-08.nifty.com ([210.131.2.75]:43888 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725283AbfEUEEQ (ORCPT ); Tue, 21 May 2019 00:04:16 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-08.nifty.com with ESMTP id x4L43VVg010681; Tue, 21 May 2019 13:03:32 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com x4L43VVg010681 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1558411413; bh=ih2ZgqObaUdBXIDdXtMeo+bCR3hhcOxpcDhp2NN3U6o=; h=From:To:Cc:Subject:Date:From; b=yLwaFzBsZMFY3pUDNfsPLXeEG1WjIBeu6gW7czqLdlKBc2OL/weJLUrEwe740+eCh U71t8T5NMJLw+aVWa238Y1vQnbt2+eZSESUNdLizoO49WjGeibChXqnZW+eMR/BMR5 xnQuj36WWvepgundBru/xONXsknEloGGu1T3E3QmddgjyUC00u3nlPfvAcsDP4cXmX hqxZOOC+Ie5BZvEuROyHw7jJ3MzprY78OWoD9SDyBsVHeVvlw23/4BaWQGLyYnBoW6 mvk8+4SaQeonazNpeO8wBE+Q2CDo4fsmiyGMsi3GU4d/09hvEMXh2WAXg4i/HLo1nK T603/ikgWFlvA== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Ralf Baechle , Paul Burton , James Hogan , linux-mips@vger.kernel.org Cc: Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH] MIPS: remove a space after -I to cope with header search paths for VDSO Date: Tue, 21 May 2019 13:03:27 +0900 Message-Id: <20190521040327.432-1-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 9cc342f6c4a0 ("treewide: prefix header search paths with $(srctree)/") caused a build error for MIPS VDSO. CC arch/mips/vdso/gettimeofday.o In file included from ../arch/mips/vdso/vdso.h:26, from ../arch/mips/vdso/gettimeofday.c:11: ../arch/mips/include/asm/page.h:12:10: fatal error: spaces.h: No such file or directory #include ^~~~~~~~~~ The cause of the error is a missing space after the compiler flag -I . Kbuild used to have a global restriction "no space after -I", but commit 48f6e3cf5bc6 ("kbuild: do not drop -I without parameter") got rid of it. Having a space after -I is no longer a big deal as far as Kbuild is concerned. It is still a big deal for MIPS because arch/mips/vdso/Makefile filters the header search paths, like this: ccflags-vdso := \ $(filter -I%,$(KBUILD_CFLAGS)) \ ..., which relies on the assumption that there is no space after -I . Fixes: 9cc342f6c4a0 ("treewide: prefix header search paths with $(srctree)/") Reported-by: kbuild test robot Signed-off-by: Masahiro Yamada --- arch/mips/pnx833x/Platform | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/arch/mips/pnx833x/Platform b/arch/mips/pnx833x/Platform index 6b1a847d593f..287260669551 100644 --- a/arch/mips/pnx833x/Platform +++ b/arch/mips/pnx833x/Platform @@ -1,5 +1,5 @@ # NXP STB225 platform-$(CONFIG_SOC_PNX833X) += pnx833x/ -cflags-$(CONFIG_SOC_PNX833X) += -I $(srctree)/arch/mips/include/asm/mach-pnx833x +cflags-$(CONFIG_SOC_PNX833X) += -I$(srctree)/arch/mips/include/asm/mach-pnx833x load-$(CONFIG_NXP_STB220) += 0xffffffff80001000 load-$(CONFIG_NXP_STB225) += 0xffffffff80001000