From patchwork Wed Jun 12 10:27:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 166535 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp3500873ilk; Wed, 12 Jun 2019 03:29:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqxFUHjntTcz2PMH0JUIRp4Hebp9J0ifOB3qYBVEahImNf2w8C/MMHUGrhGNQ1hUi6Bdxs/P X-Received: by 2002:a62:834d:: with SMTP id h74mr41197287pfe.254.1560335380443; Wed, 12 Jun 2019 03:29:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560335380; cv=none; d=google.com; s=arc-20160816; b=v0AqNYBGQcl9rJ94tqwrr1VRiLR1+a8dHxJCngudpj7e3eC1oFSoWvKU5EeiLRIS9z 9v+BAkx6JZ43PlIMm3xvnb2+K+PXhdeC+bHJRSCVhCd63pwpb0ap/V9WE4iBi73cVodH gTS1AGtYhRf3QsTjKJOfwlhPliFVcdMrtoMrm466sQt+pYfxAIlMy9RmfRw7awfUDOJ6 wZwESCe4E6bvFxERz4HT9j4axObgq8Ugh/zfPqsIkD9v52OymHvQs98Mm7MJnhcujf4w Ml3FyYGs047la+yPf5wOrQ7BVugx+Z+7AqKvljDyNCTOJHLTo2bpJ4MWkWYyHeLqClTZ PMtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=zxm1FjfX6D/JCJLoutYxeRUaHa9o4a+DtA7mM8KCfTA=; b=PwT1laSs7ph1w4ygof0f89egMh4Q+696CrTD/leJK6bzVGjy7i0j5JRKKOfPFC8+NE woUyQMSkO7PAn7uerL96p34DYR7R2cGRziRsLRKSrjtAn0srdRV30uMGBPMhRdDq06Ye HK6z9k7pZ9HmUkSafLd1N02d+HyK0e5VDRrvXodZAz/zMjCjJ9KvulAMTgb/JUvFAE97 GRS+0/0bPAKmnCNCERHHdmwy+/9b17EBYUGQgiLxEfFsnGrKQO5aFRd7lMsoyDPCVvZH BXrtBxW3jHlCvZKfMNhEdPXZSH20h6doo49DPQn4vKpvRKywDC5oOZZhFbcK25u00xUN HfUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=wi60MvvI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a8si9182572pls.118.2019.06.12.03.29.40; Wed, 12 Jun 2019 03:29:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=wi60MvvI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732150AbfFLK3j (ORCPT + 30 others); Wed, 12 Jun 2019 06:29:39 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:56396 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732130AbfFLK3j (ORCPT ); Wed, 12 Jun 2019 06:29:39 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x5CATbEG031899; Wed, 12 Jun 2019 05:29:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1560335377; bh=zxm1FjfX6D/JCJLoutYxeRUaHa9o4a+DtA7mM8KCfTA=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=wi60MvvIm+gMGlnlBpdcrLUC3rEekZeUiBp/8KDwm2PU+8qH3aHd/+7GpQozO3pw7 QbOjxIYrNhjnyxuR/XHweMBcLNz7hZRemepBfDCo4VY/qecJhaxyI6TE3aCKWaKJCC 56sSBjI7AbFZ5j8sbejpotrzw3wDeQwSEvLRrZmU= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x5CATbPX085272 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 12 Jun 2019 05:29:37 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 12 Jun 2019 05:29:37 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 12 Jun 2019 05:29:37 -0500 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x5CATTJX128310; Wed, 12 Jun 2019 05:29:34 -0500 From: Kishon Vijay Abraham I To: Greg Kroah-Hartman , CC: Subject: [PATCH 1/6] phy: qcom-qusb2: fix missing assignment of ret when calling clk_prepare_enable Date: Wed, 12 Jun 2019 15:57:58 +0530 Message-ID: <20190612102803.25398-2-kishon@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190612102803.25398-1-kishon@ti.com> References: <20190612102803.25398-1-kishon@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The error return from the call to clk_prepare_enable is not being assigned to variable ret even though ret is being used to check if the call failed. Fix this by adding in the missing assignment. Addresses-Coverity: ("Logically dead code") Fixes: 891a96f65ac3 ("phy: qcom-qusb2: Add support for runtime PM") Signed-off-by: Colin Ian King Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/qualcomm/phy-qcom-qusb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c index 1cbf1d6f28ce..bf94a52d3087 100644 --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c @@ -564,7 +564,7 @@ static int __maybe_unused qusb2_phy_runtime_resume(struct device *dev) } if (!qphy->has_se_clk_scheme) { - clk_prepare_enable(qphy->ref_clk); + ret = clk_prepare_enable(qphy->ref_clk); if (ret) { dev_err(dev, "failed to enable ref clk, %d\n", ret); goto disable_ahb_clk;