From patchwork Mon Jul 8 15:43:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 168674 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp7327338ilk; Mon, 8 Jul 2019 08:44:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqx9ENcD9bMBCsSUHW7d7zNxm7akPM7I7mzrOKHA7LTyCMtkXPVZncmOLS4GJjuwDizpoKqg X-Received: by 2002:a17:902:27e6:: with SMTP id i35mr25824621plg.190.1562600673690; Mon, 08 Jul 2019 08:44:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562600673; cv=none; d=google.com; s=arc-20160816; b=rKpxJtaOtyWLWngv1SGTdi+ZFXQAiFlhKiAO19KJlWhn1q3ksadl3lJaWP75Alb2dz RsNNwVlJpjinavPTfLSyhU++lgqLcfvPVEo0+ZhPc7uicHUJlY+4z+kyMdT4dWVNlKKp LtYu0iPQPHzCCQemXUc/f5kdIdsnOfbwCTe1C2xYUYKxfJRefXzsoFIA0Pf4LuAkuatL L1J4WDFWz0t4d0RNUhWKyqCzKo8cc0NyZJo2hKud2GDSE6rJbJo6VtLxX2GiAPbKCMfx D7ENjTqR3543MW2gcg2h23cZ6xp/e+3pkXX0cJNF7qBzQirklSJ6y/MwBv8RXYYqnXCx dEcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=/L/LOuIUmAIGtqCTCnIBdeoGVTyAKPSex/6AeJb6GeQ=; b=QRrxD5CcVMcxA6FHKYMkAiLIi/W8wotNoKv5Qq8CsGmL1Iy+VTliH1NnfJ+36ThxcK zaYcjMkWeJDFsQxn4JpBvwFCtdPffId8QCzOWU8Cr8s6EaL39u6UIzEnvF5+MJmhdcT0 aiqqoEzXLZanQkjYcdocpCLTsuT/S9VlAmP3rrEXlLgyg3RFLZM6f5ZEVAecWXSaUNIQ HdA0A8eCh2REBVQBfqp7qZsH6728ID2UUVUzdtYC8uphY8xISKA48qGLgWHGDVCa+u9o Jk9cS1cU6YiIgg9Pf5si+fU5gJV7PFTcHtvInhbQNrnWnlU/bIICmCw8Z4Js4ZX2AUO6 zIlg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b8si14787840plk.140.2019.07.08.08.44.33; Mon, 08 Jul 2019 08:44:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391243AbfGHPoc (ORCPT + 30 others); Mon, 8 Jul 2019 11:44:32 -0400 Received: from foss.arm.com ([217.140.110.172]:52052 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403855AbfGHPoN (ORCPT ); Mon, 8 Jul 2019 11:44:13 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A85B152B; Mon, 8 Jul 2019 08:44:13 -0700 (PDT) Received: from usa.arm.com (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 166063F59C; Mon, 8 Jul 2019 08:44:11 -0700 (PDT) From: Sudeep Holla To: linux-arm-kernel@lists.infradead.org Cc: Sudeep Holla , linux-kernel@vger.kernel.org, Peng Fan , Jim Quinlan , Bo Zhang , Volodymyr Babchuk Subject: [PATCH 5/6] firmware: arm_scmi: Use the term 'message' instead of 'command' Date: Mon, 8 Jul 2019 16:43:57 +0100 Message-Id: <20190708154358.16227-6-sudeep.holla@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190708154358.16227-1-sudeep.holla@arm.com> References: <20190708154358.16227-1-sudeep.holla@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to adding support for other two types of messages that SCMI specification mentions, let's replace the term 'command' with the correct term 'message'. As per the specification the messages are of 3 types: commands(synchronous or asynchronous), delayed responses and notifications. Signed-off-by: Sudeep Holla --- drivers/firmware/arm_scmi/common.h | 10 +++++----- drivers/firmware/arm_scmi/driver.c | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) -- 2.17.1 diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h index 44fd4f9404a9..4349d836b392 100644 --- a/drivers/firmware/arm_scmi/common.h +++ b/drivers/firmware/arm_scmi/common.h @@ -48,11 +48,11 @@ struct scmi_msg_resp_prot_version { /** * struct scmi_msg_hdr - Message(Tx/Rx) header * - * @id: The identifier of the command being sent - * @protocol_id: The identifier of the protocol used to send @id command - * @seq: The token to identify the message. when a message/command returns, - * the platform returns the whole message header unmodified including - * the token + * @id: The identifier of the message being sent + * @protocol_id: The identifier of the protocol used to send @id message + * @seq: The token to identify the message. when a message returns, the] + * platform returns the whole message header unmodified including the + * token * @status: Status of the transfer once it's complete * @poll_completion: Indicate if the transfer needs to be polled for * completion or interrupt mode is used diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index cac255c418b2..69bf85fea967 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -182,7 +182,7 @@ static inline int scmi_to_linux_errno(int errno) static inline void scmi_dump_header_dbg(struct device *dev, struct scmi_msg_hdr *hdr) { - dev_dbg(dev, "Command ID: %x Sequence ID: %x Protocol: %x\n", + dev_dbg(dev, "Message ID: %x Sequence ID: %x Protocol: %x\n", hdr->id, hdr->seq, hdr->protocol_id); } @@ -241,7 +241,7 @@ static void scmi_rx_callback(struct mbox_client *cl, void *m) * @hdr: pointer to header containing all the information on message id, * protocol id and sequence id. * - * Return: 32-bit packed command header to be sent to the platform. + * Return: 32-bit packed message header to be sent to the platform. */ static inline u32 pack_scmi_header(struct scmi_msg_hdr *hdr) { @@ -280,7 +280,7 @@ static void scmi_tx_prepare(struct mbox_client *cl, void *m) * * @handle: Pointer to SCMI entity handle * - * Helper function which is used by various command functions that are + * Helper function which is used by various message functions that are * exposed to clients of this driver for allocating a message traffic event. * * This function can sleep depending on pending requests already in the system