From patchwork Fri Jul 26 13:45:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 169832 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp83803ilk; Fri, 26 Jul 2019 06:46:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqxRuQGQHx8/k5eqnZNLGDHEVF440nPCZzEpLOZfqvfvwxUfpThiCFc6ra7VRpW0AxMyHLvk X-Received: by 2002:a17:902:8ec7:: with SMTP id x7mr95184443plo.224.1564148795235; Fri, 26 Jul 2019 06:46:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564148795; cv=none; d=google.com; s=arc-20160816; b=kiRPleh+HbgIlTjXQ5KQirG/CXmCQlOkD1muDhZQ00IvG8QgDk0D29ZfUOp++pYDNi r18DGoZHQSX9Q3wLw5aujmEm8yoeBcHrMJ64Nvdt+tSAIdtPQRU/qQGBrJ8gir6KF5Jm A6M2q3VzstNFp5SKmY58eUhkXrrxPpJgjPvnrnWCENFcVc3snC0eS7oEQTdCHOj1g4hB OHsdISM3EC4F3qYwxPlQpXfHtlEARNP2ttrh85JBOBro2IdhA/bnID2WKv1WuFNAtB9z Sfrt/OC+OdLTatyQU7+pMjtm92/r0Ldds3q9uWD3Wf3XEGHwm1C1V+X2F4wg0Er8vKJR tVVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=r4ql9z+8MulhD8zj66LLwe9NJ+/EKFUCirn7C87MRw8=; b=Tc2A482dsmOHmo9+sP5t8o0NYoEfy21VdNQxjCtjmpXX2+MIkZ0n4C/csQCM7WssuK F3E/86TqHC+zyXgD847Uqi/LeNUqlkfsf8OJycvtsdx+GzCRczJyv3eJ7uXAanlDhkJA xbYweYQz3SSnb9rmU4+UczDRzHyK5uqYRBeW6pOsC6UDq7GS/iNZGl+D8VlG3kEDZZNR TWRLQjH+hhkW7X4DWlQzPYvRZn4St/1xENk66WhWCYc8rDq+D4A2jqgwM+p4xyz82zPw NnSrnwyj1I9/OYv3T87yn2SMEKV8A+tMBvPlwflqgKzC6AZL9luZwtw8EEFxGPkJTbCR O2oA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e62si22998711pfh.254.2019.07.26.06.46.34; Fri, 26 Jul 2019 06:46:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388712AbfGZNq2 (ORCPT + 29 others); Fri, 26 Jul 2019 09:46:28 -0400 Received: from foss.arm.com ([217.140.110.172]:44078 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388656AbfGZNqM (ORCPT ); Fri, 26 Jul 2019 09:46:12 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7671C15BF; Fri, 26 Jul 2019 06:46:11 -0700 (PDT) Received: from usa.arm.com (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3B7613F694; Fri, 26 Jul 2019 06:46:10 -0700 (PDT) From: Sudeep Holla To: linux-arm-kernel@lists.infradead.org Cc: Sudeep Holla , Peng Fan , linux-kernel@vger.kernel.org, Bo Zhang , Jim Quinlan , Volodymyr Babchuk , Gaku Inami , Etienne Carriere Subject: [PATCH v2 5/6] firmware: arm_scmi: Use the term 'message' instead of 'command' Date: Fri, 26 Jul 2019 14:45:30 +0100 Message-Id: <20190726134531.8928-6-sudeep.holla@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190726134531.8928-1-sudeep.holla@arm.com> References: <20190726134531.8928-1-sudeep.holla@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to adding support for other two types of messages that SCMI specification mentions, let's replace the term 'command' with the correct term 'message'. As per the specification the messages are of 3 types: commands(synchronous or asynchronous), delayed responses and notifications. Signed-off-by: Sudeep Holla --- drivers/firmware/arm_scmi/common.h | 10 +++++----- drivers/firmware/arm_scmi/driver.c | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) -- 2.17.1 diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h index 44fd4f9404a9..a9eee62c7142 100644 --- a/drivers/firmware/arm_scmi/common.h +++ b/drivers/firmware/arm_scmi/common.h @@ -48,11 +48,11 @@ struct scmi_msg_resp_prot_version { /** * struct scmi_msg_hdr - Message(Tx/Rx) header * - * @id: The identifier of the command being sent - * @protocol_id: The identifier of the protocol used to send @id command - * @seq: The token to identify the message. when a message/command returns, - * the platform returns the whole message header unmodified including - * the token + * @id: The identifier of the message being sent + * @protocol_id: The identifier of the protocol used to send @id message + * @seq: The token to identify the message. When a message returns, the + * platform returns the whole message header unmodified including the + * token * @status: Status of the transfer once it's complete * @poll_completion: Indicate if the transfer needs to be polled for * completion or interrupt mode is used diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index cac255c418b2..69bf85fea967 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -182,7 +182,7 @@ static inline int scmi_to_linux_errno(int errno) static inline void scmi_dump_header_dbg(struct device *dev, struct scmi_msg_hdr *hdr) { - dev_dbg(dev, "Command ID: %x Sequence ID: %x Protocol: %x\n", + dev_dbg(dev, "Message ID: %x Sequence ID: %x Protocol: %x\n", hdr->id, hdr->seq, hdr->protocol_id); } @@ -241,7 +241,7 @@ static void scmi_rx_callback(struct mbox_client *cl, void *m) * @hdr: pointer to header containing all the information on message id, * protocol id and sequence id. * - * Return: 32-bit packed command header to be sent to the platform. + * Return: 32-bit packed message header to be sent to the platform. */ static inline u32 pack_scmi_header(struct scmi_msg_hdr *hdr) { @@ -280,7 +280,7 @@ static void scmi_tx_prepare(struct mbox_client *cl, void *m) * * @handle: Pointer to SCMI entity handle * - * Helper function which is used by various command functions that are + * Helper function which is used by various message functions that are * exposed to clients of this driver for allocating a message traffic event. * * This function can sleep depending on pending requests already in the system