From patchwork Fri Jul 26 13:51:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 169846 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp92246ilk; Fri, 26 Jul 2019 06:54:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqx/JtJbcsUUWaSoSoMqnjtYaZTolOQaXLtq+aTU1GXi/YItxDM1KaFZ0972D8lbMZMZt2gU X-Received: by 2002:a17:902:a60d:: with SMTP id u13mr97328119plq.144.1564149132842; Fri, 26 Jul 2019 06:52:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564149132; cv=none; d=google.com; s=arc-20160816; b=hkw05Fd47+7zwHrLwf4/Ab0elWOb93wr3Dk89fCYgUNZ25eKISFSk0gN+bEdubmYS6 kLxYylZmh2/ZsYwz0VURcWwLsA9lRASugO1xGNBu3e/hmNaq87pIRn0laee+o88sR48R F+1UULKesuVJF5St79ZhglHxIA510zOMvFIIdAaJpjQPTQLgmH1gOX0gsa0SW6CTOwKb mhAg9GPSvv/+RMm7VVMNBevFf0MebdBruoGapX8lo6kMsTS8HqLVBNlwUHIfGqKDDOvn aZPg7F2MXMFKK5H6s5ER+0OiQf20lq24spOh7oCCBsZwHb3Bma9v5gkOmvWVrEM3kWPT NIUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=xt3url+XzpfIMuHQR9FKcnT2rKRr5KmBDn8Vs5g3vws=; b=HwsFBjTIaFBExS1FtQutOC+dAHOkYoOhq0knxjMsf+Mx9/3RBhigfIj5nbGc4JeTwO Tr+N3IMl+lKBABZQkkypOJitIoPBhQBrwwphSOu+ikwEQ56eGSVIyjtnKd3l3AYIWtQc fFZF9wM9qxAwpz3HUiJ4yTnSbIPFbwGDjZLOGxte9PiFiJOiHv4dEkyClihne2qetD6m /wSwMc5UvFe/alagzNi+ZRTzeV9G8G1HgY8FzNKDzL7L7fDrU7awp07IPczDUgho7l4o teikWqEa5vjhokfciifaXHM1a5dbTTJ+sjh8r8CzP7QRP8EY+2l7nbColmBBcIpaajhP Jb0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e4si5924042pgh.434.2019.07.26.06.52.12; Fri, 26 Jul 2019 06:52:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388518AbfGZNwA (ORCPT + 29 others); Fri, 26 Jul 2019 09:52:00 -0400 Received: from foss.arm.com ([217.140.110.172]:44494 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728287AbfGZNvy (ORCPT ); Fri, 26 Jul 2019 09:51:54 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 39BC615A2; Fri, 26 Jul 2019 06:51:54 -0700 (PDT) Received: from usa.arm.com (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 01ABC3F694; Fri, 26 Jul 2019 06:51:52 -0700 (PDT) From: Sudeep Holla To: linux-arm-kernel@lists.infradead.org Cc: Sudeep Holla , Peng Fan , linux-kernel@vger.kernel.org, Bo Zhang , Jim Quinlan , Volodymyr Babchuk , Gaku Inami , Etienne Carriere Subject: [PATCH v2 05/10] firmware: arm_scmi: Add mechanism to unpack message headers Date: Fri, 26 Jul 2019 14:51:33 +0100 Message-Id: <20190726135138.9858-6-sudeep.holla@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190726135138.9858-1-sudeep.holla@arm.com> References: <20190726135138.9858-1-sudeep.holla@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In order to identify the message type when a response arrives, we need a mechanism to unpack the message header similar to packing. Let's add one. Signed-off-by: Sudeep Holla --- drivers/firmware/arm_scmi/driver.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) -- 2.17.1 diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 97618220ea02..9a670918b050 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -30,8 +30,14 @@ #include "common.h" #define MSG_ID_MASK GENMASK(7, 0) +#define MSG_XTRACT_ID(hdr) FIELD_GET(MSG_ID_MASK, (hdr)) #define MSG_TYPE_MASK GENMASK(9, 8) +#define MSG_XTRACT_TYPE(hdr) FIELD_GET(MSG_TYPE_MASK, (hdr)) +#define MSG_TYPE_COMMAND 0 +#define MSG_TYPE_DELAYED_RESP 2 +#define MSG_TYPE_NOTIFICATION 3 #define MSG_PROTOCOL_ID_MASK GENMASK(17, 10) +#define MSG_XTRACT_PROT_ID(hdr) FIELD_GET(MSG_PROTOCOL_ID_MASK, (hdr)) #define MSG_TOKEN_ID_MASK GENMASK(27, 18) #define MSG_XTRACT_TOKEN(hdr) FIELD_GET(MSG_TOKEN_ID_MASK, (hdr)) #define MSG_TOKEN_MAX (MSG_XTRACT_TOKEN(MSG_TOKEN_ID_MASK) + 1) @@ -214,6 +220,18 @@ static inline u32 pack_scmi_header(struct scmi_msg_hdr *hdr) FIELD_PREP(MSG_PROTOCOL_ID_MASK, hdr->protocol_id); } +/** + * unpack_scmi_header() - unpacks and records message and protocol id + * + * @msg_hdr: 32-bit packed message header sent from the platform + * @hdr: pointer to header to fetch message and protocol id. + */ +static inline void unpack_scmi_header(u32 msg_hdr, struct scmi_msg_hdr *hdr) +{ + hdr->id = MSG_XTRACT_ID(msg_hdr); + hdr->protocol_id = MSG_XTRACT_PROT_ID(msg_hdr); +} + /** * scmi_tx_prepare() - mailbox client callback to prepare for the transfer *