From patchwork Fri Jul 26 13:51:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 169842 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp89950ilk; Fri, 26 Jul 2019 06:52:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqziJ2mRJVi2I9goVgOGa7+b7yfnaEz7QCVCrM7JMPoUVekA90SluTy92I0IwDn3wosyF9Vu X-Received: by 2002:a62:d45d:: with SMTP id u29mr22241088pfl.135.1564149148777; Fri, 26 Jul 2019 06:52:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564149148; cv=none; d=google.com; s=arc-20160816; b=yxc7Ljox51mwRYXl81+1wuCCvps8CYZpwRKUh0s1fc+oqiMLLZx3o3f/Me2TpPoMpD c4U5a6/4BP180NWRtxckVF7WaLsEYrPaXzD77vMnHeIOe1sw38A7ZbmCfYPMnf7CU3iN SxKADkIfOTBBWXXw97sTJoULyrkNKUk6zQi39cBdQ4VY4SetEHCl7AjNx+9IpqmqvT8m zHGd8jWultqymUfT9ujCqU+L6bOpLpnMEw2+AF3ymNKUQ20tPuB2YUr1vvZgPBZtlPt/ LDGyZycyVp+MiUMt10Z5hdQ3bHulNdth5RtFFTyyhgrxlHrGSokHrFI/06UCueit+F+f t6bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=/Wgn3+dtwtU54zyyOcuv/XXD4nk7V/BKG2wa/CA4JSk=; b=y4eq+F0Lmmra+vRkJlZqQ3TwfjIVwFdCCS4SuLDjK1tI+j7ignQs9u6lRsThdugwzz CanSAECrvX2t2+RBRU0xPwx0aPXwhfGANuodUbai6d1yFa5QgJjCc6Rdk/r/5u9Rj9t6 ux+EGbMJYtvG8/DpRxSip+JslZ2ukfN1OEx8T+84Arcc84HnTPU2p5Sy72OtZWCKtzq9 itr+AQqNg+L3CsdW5dVzIillQBidRL+IvHYVm1YJJM0y0Rg+i7pnG7SkPI5OorQ3TxAM jCVMAqTXTUegNjqGlbF9u8nIcFRTbm0KQ32Bx46jZciWo1Mdjkby0YiOcovpB0ILMjzj 0IkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j187si20848394pge.591.2019.07.26.06.52.28; Fri, 26 Jul 2019 06:52:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388802AbfGZNw0 (ORCPT + 29 others); Fri, 26 Jul 2019 09:52:26 -0400 Received: from foss.arm.com ([217.140.110.172]:44518 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727796AbfGZNv6 (ORCPT ); Fri, 26 Jul 2019 09:51:58 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 39CD4152D; Fri, 26 Jul 2019 06:51:57 -0700 (PDT) Received: from usa.arm.com (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DB0033F694; Fri, 26 Jul 2019 06:51:55 -0700 (PDT) From: Sudeep Holla To: linux-arm-kernel@lists.infradead.org Cc: Sudeep Holla , Peng Fan , linux-kernel@vger.kernel.org, Bo Zhang , Jim Quinlan , Volodymyr Babchuk , Gaku Inami , Etienne Carriere , linux-hwmon@vger.kernel.org Subject: [PATCH v2 07/10] firmware: arm_scmi: Drop async flag in sensor_ops->reading_get Date: Fri, 26 Jul 2019 14:51:35 +0100 Message-Id: <20190726135138.9858-8-sudeep.holla@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190726135138.9858-1-sudeep.holla@arm.com> References: <20190726135138.9858-1-sudeep.holla@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SENSOR_DESCRIPTION_GET provides attributes to indicate if the sensor supports asynchronous read. Ideally we should be able to read that flag and use asynchronous reads for any sensors with that attribute set. In order to add that support, let's drop the async flag passed to sensor_ops->reading_get and dynamically switch between sync and async flags based on the attributes as provided by the firmware. Cc: linux-hwmon@vger.kernel.org Acked-by: Guenter Roeck Signed-off-by: Sudeep Holla --- drivers/firmware/arm_scmi/sensors.c | 4 ++-- drivers/hwmon/scmi-hwmon.c | 2 +- include/linux/scmi_protocol.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) -- 2.17.1 diff --git a/drivers/firmware/arm_scmi/sensors.c b/drivers/firmware/arm_scmi/sensors.c index 17dbabd8a94a..1b5757c77a35 100644 --- a/drivers/firmware/arm_scmi/sensors.c +++ b/drivers/firmware/arm_scmi/sensors.c @@ -211,7 +211,7 @@ scmi_sensor_trip_point_config(const struct scmi_handle *handle, u32 sensor_id, } static int scmi_sensor_reading_get(const struct scmi_handle *handle, - u32 sensor_id, bool async, u64 *value) + u32 sensor_id, u64 *value) { int ret; struct scmi_xfer *t; @@ -225,7 +225,7 @@ static int scmi_sensor_reading_get(const struct scmi_handle *handle, sensor = t->tx.buf; sensor->id = cpu_to_le32(sensor_id); - sensor->flags = cpu_to_le32(async ? SENSOR_READ_ASYNC : 0); + sensor->flags = cpu_to_le32(0); ret = scmi_do_xfer(handle, t); if (!ret) { diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c index 0c93fc5ca762..8a7732c0bef3 100644 --- a/drivers/hwmon/scmi-hwmon.c +++ b/drivers/hwmon/scmi-hwmon.c @@ -72,7 +72,7 @@ static int scmi_hwmon_read(struct device *dev, enum hwmon_sensor_types type, const struct scmi_handle *h = scmi_sensors->handle; sensor = *(scmi_sensors->info[type] + channel); - ret = h->sensor_ops->reading_get(h, sensor->id, false, &value); + ret = h->sensor_ops->reading_get(h, sensor->id, &value); if (ret) return ret; diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protocol.h index 1383d47e6435..2ace5af210ad 100644 --- a/include/linux/scmi_protocol.h +++ b/include/linux/scmi_protocol.h @@ -182,7 +182,7 @@ struct scmi_sensor_ops { int (*trip_point_config)(const struct scmi_handle *handle, u32 sensor_id, u8 trip_id, u64 trip_value); int (*reading_get)(const struct scmi_handle *handle, u32 sensor_id, - bool async, u64 *value); + u64 *value); }; /**