From patchwork Sat Aug 10 15:53:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 171028 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp696585ily; Sat, 10 Aug 2019 08:55:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqzunHT8kKuZ4nitFl6MKdT5w8YlA1WY745TB9BUSv6WGn3npjXmR60ryej4YSbticeFyzGx X-Received: by 2002:a17:90a:32c7:: with SMTP id l65mr15104031pjb.1.1565452500387; Sat, 10 Aug 2019 08:55:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565452500; cv=none; d=google.com; s=arc-20160816; b=eolzyCvv5w97cmIH6W7sVd3d7259GdaC6VxHaJ5wZU2JTtxiOWMm0uOla9NjcL2Y0k 8vKFBHebfGjVXAZYUZVIMmNJg2ye+7H5WwFMqDQVra7KYLlhim28RI1hYVfhuXl8PXN0 xGkcou0wL7eAQ834Xq6UJg1gkeP3TygC5UmNPe82bU++MG2JtYa+6ZnldIAnoQI5XrCf B8Oz+zZbltlKX7y8DMpInlj+pmU5ao12e+0Wh2yhyMjwmpfGPu68EmAzXX5yKLSjC6Jq BHtOc9DAAPM5c3URw9TBzI3fo6FuvRxuJSlqOwMexy9MzMIoudkftJ14r8f18QYeyT4u YhAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=l1ycP8oGkQD/aCe4zNqlB/biCW5yxV6/RDGMWKdUx8M=; b=hVCAiSy6C0KqhEHVc2b2MeGjEXqYvpXeck/8p9u34NDeXvhIF2o1iotctAj9PeRvl+ fQBFXsZrmBxzzKCpWm8Oa1Q74eOeK1yoEstVqGLJsMgY5HpAHjEISfxZ0U9wwCGq0Q6j LiyNPSufpjCwgWZq+1WBplJ0AF5otp8CL7XuZOScq4MonDLJ3Y/38Kl9bzdnPJyss/+d 9pV5U0oWPZK+b0VNwk59Wajk1h4HxbWVHkHb5xbxNRAJ+LgbEJ1BSDIk5VvL8PImoapH VUIsA1zuL9YBD57E1aqabeSgS22eTNuFbvGRGqLnM0mhDfqScwBU+DTuTgC8ib1weJn5 2/gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=cpOqqVK4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z9si7081933pju.2.2019.08.10.08.55.00; Sat, 10 Aug 2019 08:55:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=cpOqqVK4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726565AbfHJPy6 (ORCPT + 28 others); Sat, 10 Aug 2019 11:54:58 -0400 Received: from conuserg-11.nifty.com ([210.131.2.78]:34527 "EHLO conuserg-11.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726410AbfHJPyo (ORCPT ); Sat, 10 Aug 2019 11:54:44 -0400 Received: from grover.flets-west.jp (softbank126125143222.bbtec.net [126.125.143.222]) (authenticated) by conuserg-11.nifty.com with ESMTP id x7AFrG8x009713; Sun, 11 Aug 2019 00:53:20 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com x7AFrG8x009713 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1565452401; bh=l1ycP8oGkQD/aCe4zNqlB/biCW5yxV6/RDGMWKdUx8M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cpOqqVK4Hq+425fN3Q07m/br7bt9+bAgD4HL+2spwQAKxOu5IZPc4I295meOH5vky G7Ew8aK4DiJmLMw6/PPUDkNdD8NdCgQqi3vjQhZfF2qb1VwofRC7uDUYRFHPgq7T/S 0Bn1SkabQ3EaqUqDy8WusfrmaJIVNmRbU+kFM+ffpY3yztYW/n0gG35JkBAg2Q0CKR nSZNxdJ17QWmjSEs5YYbyGMhflZtmlQCItqEJ7ZrsoS5LoqEMn7uidgst9Vo94bziH ivcVJsA394d3TlNRClwQ6Mef234qwG9mWlQ98SLPIl0RQhZuRUX5+2K+5KGmh/tknk 8JdL6zSEyhRSg== X-Nifty-SrcIP: [126.125.143.222] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Christoph Hellwig , Sam Ravnborg , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH 04/11] kbuild: remove 'make /' support Date: Sun, 11 Aug 2019 00:53:00 +0900 Message-Id: <20190810155307.29322-5-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190810155307.29322-1-yamada.masahiro@socionext.com> References: <20190810155307.29322-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'make /' is just an alias for 'make ./'; this builds all objects of an external module, but skips the modpost stage. I am not a big fan of 'make /' since it looks as if it were touching the root directory of the system. I like 'make ./' better. I do not know how many people are using it, but let's show a hint if it is used. Also, move it close to the external module rules since this only makes sense for external modules. Signed-off-by: Masahiro Yamada --- Makefile | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) -- 2.17.1 diff --git a/Makefile b/Makefile index 24c9ed272b5f..86afce391582 100644 --- a/Makefile +++ b/Makefile @@ -1648,6 +1648,10 @@ $(clean-dirs): clean: rm-files := $(KBUILD_EXTMOD)/Module.symvers +PHONY += / +/: + @echo >&2 '"$(MAKE) /" is no longer supported. Please use "$(MAKE) ./" instead.' + PHONY += help help: @echo ' Building external modules.' @@ -1783,11 +1787,6 @@ endif $(Q)$(MAKE) $(build)=$(build-dir) $(build-target:.ko=.mod) $(Q)echo $(build-target) > $(MODORDER) $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modpost - -# Modules -PHONY += / -/: ./ - %/: prepare FORCE $(Q)$(MAKE) KBUILD_MODULES=1 $(build)=$(build-dir) need-modorder=1