From patchwork Wed Oct 9 19:10:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 175669 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp1174583ill; Wed, 9 Oct 2019 12:14:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqx00MmNu/tblun8qPKUGplf3kHh5ExA6GfRhEC3IQX3xh9V9+Mf+NnzfddN2GpwGZvNyk6M X-Received: by 2002:a05:6402:886:: with SMTP id e6mr4582508edy.152.1570648479793; Wed, 09 Oct 2019 12:14:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570648479; cv=none; d=google.com; s=arc-20160816; b=Ho68PFQk2NAWvGOUHJPfYdmSnQXMK0cxrweoZi96988PhY6hwq0McTB/yQQ9fggGHO W9u/3zCidgmueyjoiQlrGkLwV2IWE0el3hFIchOwjPAtxwixKyDZP4OptiHalDSyXOM5 44C9klyeg564J/KkA0hvK7H7xXlQIWyGRFmegliJSghsn3/f8USbD+thiHVX9ft19xPt 5ZWqhAWSBmhB4jzhq8gP2tcFip5XC/zRR8RFa89hFXivZYKvR3LJEPpqfwoKRSeBuEGv v8K5oJWAIiWSj824N3IcXRfSdT6MQPuP9vR5bPBf9sgN9gw1yI+OFT73LuTwDBxEe9el umNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Hmxjaat5qugSE/HexnSUZfSxauGWFFD3U4J3MxSVZpQ=; b=BNaiVlY7zwmQHi9ISaAK+EwelR+erdglKyhKoBzt4k8/MZncuhXMmC1m+fRHQ5KZsG wVG+778tpz8XLQZtEW8Tq0ADm/ZPkFa9r/IOZFQeASVk9m4WWfbAsL3tDa3+vWLmCSsS wU+pvs9bX8KYD43CiuseRp6YgnZ9DLJ9O0O3Qr46SouTp5yus2n09hegFkzaP853h+Up f9KNKGjfSRx/Wmv254KRqAE05mw7ah3+dl7w0Jb4LePI6kFvP9iOazPEQFCd9t3mGt0L QUyg2Y7T+ArLUr65i6G0j0Cv8f5UvEEEy1HRLTD5y5oUfTLDfHGR0mN4+8N64wGjxb5K uUJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j12si1672315ejx.282.2019.10.09.12.14.39; Wed, 09 Oct 2019 12:14:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732529AbfJITOj (ORCPT + 26 others); Wed, 9 Oct 2019 15:14:39 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:44107 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731815AbfJITLQ (ORCPT ); Wed, 9 Oct 2019 15:11:16 -0400 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPA (Nemesis) id 1MUGuZ-1iiRKk3Akl-00RHrY; Wed, 09 Oct 2019 21:11:13 +0200 From: Arnd Bergmann To: Al Viro Cc: linux-kernel@vger.kernel.org, y2038@lists.linaro.org, linux-fsdevel@vger.kernel.org, Arnd Bergmann , linux-bluetooth@vger.kernel.org, Marcel Holtmann , Johan Hedberg Subject: [PATCH v6 20/43] compat_ioctl: remove HIDIO translation Date: Wed, 9 Oct 2019 21:10:20 +0200 Message-Id: <20191009191044.308087-20-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20191009190853.245077-1-arnd@arndb.de> References: <20191009190853.245077-1-arnd@arndb.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:7RMTQj/IzXWYNqxbs38UjXmvOPx/nPUg/Jyhl5K5JkL70CQCnF4 P7q/KM2dZFFM1mtdBuyaIqUOFQ17HlCzmqS0tuXPXTEirxZH9GS8gORXXirs/gILMvMEyja 5hNst7E+UHJdZxWMQnw0p3I0VbnvpoDPWpJHRD/vsv8+rHK2g9WQfQad4vs+tpXs/xmRHjT MbggUfSSb6Uvr6f+ZBoDQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:x0djXe2zRmc=:ad8+YXein6bQ0QFyxFmaf5 3H7cUXons26UtN1mFsrj6+7EPNH5+j8wl04KuKJboRJXY6swmLiRvc2JyvfLrEwlXQnApxrrp JsHHkVh32zh6mpb/a1ZZzohM0N9ua+czPNFXB8Y5VKPHQB88O2yvmWRJ5v/EO/6e5vCMqGOGn HZQrkA8YxrqX8y3mXBAlsGQgF6eWxC9pet/+6xkbNcvRSiUfjTtwLO/D/1bdK3RjjVrMtfX13 Xf+DT120gHyHUcN0adf2srndF+BLmhNdds4gL9y+YukBzCKnRd/MrjS3PYPYs5CWwjMpwADFF ZXD21oeBdqGpQ9N2vhzZzGie+FQ/0pV3U8EI7RuzDHyv+HvmODurkqCyQ589vXvvkzeDfbRcl HfFO4XhgNzIKLH2PYpsoE21njqZi8n6u5N8zxYxCSyenIemzI1RWzck/FgqetAymWZeEkblrj xuJyI7N908igBl2AWWo8e3QHjMmmKzdx+blAea9rfGZAK7/FKCF3sdtZBV8OhbFgD3rWEPtTI Iwx1yNMvY4hiyhHf8ajTTJRvCeyMigqy/MorBDgZNFJdj66MK4Zlx/Itv9rjcv1S8pfERWjlI kZbOmbjKQG+w3GcxfAfeCJvE5uqiA+DYh4yJA1duY34hTLQsvBR8qKr7g7lPJpJMlp9C+TCEH YB+U6wL6C3kRUyp8skEW6cwIp23vVHz9t8WH5nvk6ypeLbdays2PKFEbiD20MRjpCZXCpgqVB Qs5zxUonl/onGJKMvt8dIrbIEdGPfGgHFFX4LZQRmmFlL5iuHF3xzgThTj53kV21/1G8oUnpW bomS/5kPMX2XtDxewQlWEkfyyOlvZFLk+OwzZg40ihqyPe2xvxr8qIM1sICy067JDcGPgnlzg sBUW1gq3ojBcK0FdJojg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The two drivers implementing these both gained proper compat_ioctl() handlers a long time ago with commits bb6c8d8fa9b5 ("HID: hiddev: Add 32bit ioctl compatibilty") and ae5e49c79c05 ("HID: hidraw: add compatibility ioctl() for 32-bit applications."), so the lists in fs/compat_ioctl.c are no longer used. It appears that the lists were also incomplete, so the translation didn't actually work correctly when it was still in use. Remove them as cleanup. Cc: linux-bluetooth@vger.kernel.org Cc: Marcel Holtmann Cc: Johan Hedberg Signed-off-by: Arnd Bergmann --- fs/compat_ioctl.c | 17 ----------------- 1 file changed, 17 deletions(-) -- 2.20.0 diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c index 758b8b934b70..03da7934a351 100644 --- a/fs/compat_ioctl.c +++ b/fs/compat_ioctl.c @@ -640,23 +640,6 @@ COMPATIBLE_IOCTL(PCIIOC_CONTROLLER) COMPATIBLE_IOCTL(PCIIOC_MMAP_IS_IO) COMPATIBLE_IOCTL(PCIIOC_MMAP_IS_MEM) COMPATIBLE_IOCTL(PCIIOC_WRITE_COMBINE) -/* hiddev */ -COMPATIBLE_IOCTL(HIDIOCGVERSION) -COMPATIBLE_IOCTL(HIDIOCAPPLICATION) -COMPATIBLE_IOCTL(HIDIOCGDEVINFO) -COMPATIBLE_IOCTL(HIDIOCGSTRING) -COMPATIBLE_IOCTL(HIDIOCINITREPORT) -COMPATIBLE_IOCTL(HIDIOCGREPORT) -COMPATIBLE_IOCTL(HIDIOCSREPORT) -COMPATIBLE_IOCTL(HIDIOCGREPORTINFO) -COMPATIBLE_IOCTL(HIDIOCGFIELDINFO) -COMPATIBLE_IOCTL(HIDIOCGUSAGE) -COMPATIBLE_IOCTL(HIDIOCSUSAGE) -COMPATIBLE_IOCTL(HIDIOCGUCODE) -COMPATIBLE_IOCTL(HIDIOCGFLAG) -COMPATIBLE_IOCTL(HIDIOCSFLAG) -COMPATIBLE_IOCTL(HIDIOCGCOLLECTIONINDEX) -COMPATIBLE_IOCTL(HIDIOCGCOLLECTIONINFO) /* joystick */ COMPATIBLE_IOCTL(JSIOCGVERSION) COMPATIBLE_IOCTL(JSIOCGAXES)