| Message ID | 20191016155954.29044-10-dmurphy@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | Multicolor Framework v13 | expand |
* Dan Murphy <dmurphy@ti.com> [191016 16:01]: > Add the reg property to each channel node. This update is > to accomodate the multicolor framework. In addition to the > accomodation this allows the LEDs to be placed on any channel > and allow designs to skip channels as opposed to requiring > sequential order. > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > CC: Tony Lindgren <tony@atomide.com> > CC: "Benoît Cousson" <bcousson@baylibre.com> > > k# interactive rebase in progress; onto ae89cc6d4a8c Maybe check what's up with the line above :) Othwerwise looks good to me, best to merge this together with the rest of the series when ready: Acked-by: Tony Lindgren <tony@atomide.com> > --- > arch/arm/boot/dts/omap3-n900.dts | 29 ++++++++++++++++++++--------- > 1 file changed, 20 insertions(+), 9 deletions(-) > > diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts > index 84a5ade1e865..643f35619246 100644 > --- a/arch/arm/boot/dts/omap3-n900.dts > +++ b/arch/arm/boot/dts/omap3-n900.dts > @@ -607,63 +607,74 @@ > }; > > lp5523: lp5523@32 { > + #address-cells = <1>; > + #size-cells = <0>; > compatible = "national,lp5523"; > reg = <0x32>; > clock-mode = /bits/ 8 <0>; /* LP55XX_CLOCK_AUTO */ > enable-gpio = <&gpio2 9 GPIO_ACTIVE_HIGH>; /* 41 */ > > - chan0 { > + chan@0 { > chan-name = "lp5523:kb1"; > led-cur = /bits/ 8 <50>; > max-cur = /bits/ 8 <100>; > + reg = <0>; > }; > > - chan1 { > + chan@1 { > chan-name = "lp5523:kb2"; > led-cur = /bits/ 8 <50>; > max-cur = /bits/ 8 <100>; > + reg = <1>; > }; > > - chan2 { > + chan@2 { > chan-name = "lp5523:kb3"; > led-cur = /bits/ 8 <50>; > max-cur = /bits/ 8 <100>; > + reg = <2>; > }; > > - chan3 { > + chan@3 { > chan-name = "lp5523:kb4"; > led-cur = /bits/ 8 <50>; > max-cur = /bits/ 8 <100>; > + reg = <3>; > }; > > - chan4 { > + chan@4 { > chan-name = "lp5523:b"; > led-cur = /bits/ 8 <50>; > max-cur = /bits/ 8 <100>; > + reg = <4>; > }; > > - chan5 { > + chan@5 { > chan-name = "lp5523:g"; > led-cur = /bits/ 8 <50>; > max-cur = /bits/ 8 <100>; > + reg = <5>; > }; > > - chan6 { > + chan@6 { > chan-name = "lp5523:r"; > led-cur = /bits/ 8 <50>; > max-cur = /bits/ 8 <100>; > + reg = <6>; > }; > > - chan7 { > + chan@7 { > chan-name = "lp5523:kb5"; > led-cur = /bits/ 8 <50>; > max-cur = /bits/ 8 <100>; > + reg = <7>; > }; > > - chan8 { > + chan@8 { > chan-name = "lp5523:kb6"; > led-cur = /bits/ 8 <50>; > max-cur = /bits/ 8 <100>; > + reg = <8>; > }; > }; > > -- > 2.22.0.214.g8dca754b1e >
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index 84a5ade1e865..643f35619246 100644 --- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -607,63 +607,74 @@ }; lp5523: lp5523@32 { + #address-cells = <1>; + #size-cells = <0>; compatible = "national,lp5523"; reg = <0x32>; clock-mode = /bits/ 8 <0>; /* LP55XX_CLOCK_AUTO */ enable-gpio = <&gpio2 9 GPIO_ACTIVE_HIGH>; /* 41 */ - chan0 { + chan@0 { chan-name = "lp5523:kb1"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <100>; + reg = <0>; }; - chan1 { + chan@1 { chan-name = "lp5523:kb2"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <100>; + reg = <1>; }; - chan2 { + chan@2 { chan-name = "lp5523:kb3"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <100>; + reg = <2>; }; - chan3 { + chan@3 { chan-name = "lp5523:kb4"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <100>; + reg = <3>; }; - chan4 { + chan@4 { chan-name = "lp5523:b"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <100>; + reg = <4>; }; - chan5 { + chan@5 { chan-name = "lp5523:g"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <100>; + reg = <5>; }; - chan6 { + chan@6 { chan-name = "lp5523:r"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <100>; + reg = <6>; }; - chan7 { + chan@7 { chan-name = "lp5523:kb5"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <100>; + reg = <7>; }; - chan8 { + chan@8 { chan-name = "lp5523:kb6"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <100>; + reg = <8>; }; };
Add the reg property to each channel node. This update is to accomodate the multicolor framework. In addition to the accomodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order. Signed-off-by: Dan Murphy <dmurphy@ti.com> CC: Tony Lindgren <tony@atomide.com> CC: "Benoît Cousson" <bcousson@baylibre.com> k# interactive rebase in progress; onto ae89cc6d4a8c --- arch/arm/boot/dts/omap3-n900.dts | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) -- 2.22.0.214.g8dca754b1e