diff mbox series

[v2,1/9] mfd: cs5535-mfd: Use PLATFORM_DEVID_* defines and tidy error message

Message ID 20191021105822.20271-2-lee.jones@linaro.org
State Superseded
Headers show
Series Simplify MFD Core | expand

Commit Message

Lee Jones Oct. 21, 2019, 10:58 a.m. UTC
In most contexts '-1' doesn't really mean much to the casual observer.
In almost all cases, it's better to use a human readable define.  In
this case PLATFORM_DEVID_* defines have already been provided for this
purpose.

While we're here, let's be specific about the 'MFD devices' which
failed.  It will help when trying to distinguish which of the 2 sets
of sub-devices we actually failed to register.

Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/mfd/cs5535-mfd.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.17.1

Comments

Daniel Thompson Oct. 21, 2019, 11:15 a.m. UTC | #1
On Mon, Oct 21, 2019 at 11:58:14AM +0100, Lee Jones wrote:
> In most contexts '-1' doesn't really mean much to the casual observer.

> In almost all cases, it's better to use a human readable define.  In

> this case PLATFORM_DEVID_* defines have already been provided for this

> purpose.

> 

> While we're here, let's be specific about the 'MFD devices' which

> failed.  It will help when trying to distinguish which of the 2 sets

> of sub-devices we actually failed to register.


No objections... but won't the tag added by dev_err() already
disambiguate?
> 

> Signed-off-by: Lee Jones <lee.jones@linaro.org>

> ---

>  drivers/mfd/cs5535-mfd.c | 5 +++--

>  1 file changed, 3 insertions(+), 2 deletions(-)

> 

> diff --git a/drivers/mfd/cs5535-mfd.c b/drivers/mfd/cs5535-mfd.c

> index f1825c0ccbd0..2c47afc22d24 100644

> --- a/drivers/mfd/cs5535-mfd.c

> +++ b/drivers/mfd/cs5535-mfd.c

> @@ -127,10 +127,11 @@ static int cs5535_mfd_probe(struct pci_dev *pdev,

>  		cs5535_mfd_cells[i].id = 0;

>  	}

>  

> -	err = mfd_add_devices(&pdev->dev, -1, cs5535_mfd_cells,

> +	err = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE, cs5535_mfd_cells,

>  			      ARRAY_SIZE(cs5535_mfd_cells), NULL, 0, NULL);

>  	if (err) {

> -		dev_err(&pdev->dev, "MFD add devices failed: %d\n", err);

> +		dev_err(&pdev->dev,

> +			"Failed to add CS5532 sub-devices: %d\n", err);


                                           ^^^

Typo (and MODULE_DESCRIPTION() says this is a driver for CS5536 too).
Once that is fixed:
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>



Daniel.
Lee Jones Oct. 21, 2019, 11:33 a.m. UTC | #2
On Mon, 21 Oct 2019, Daniel Thompson wrote:

> On Mon, Oct 21, 2019 at 11:58:14AM +0100, Lee Jones wrote:

> > In most contexts '-1' doesn't really mean much to the casual observer.

> > In almost all cases, it's better to use a human readable define.  In

> > this case PLATFORM_DEVID_* defines have already been provided for this

> > purpose.

> > 

> > While we're here, let's be specific about the 'MFD devices' which

> > failed.  It will help when trying to distinguish which of the 2 sets

> > of sub-devices we actually failed to register.

> 

> No objections... but won't the tag added by dev_err() already

> disambiguate?


The difference will be between CS5532 and  CS5532 OLPC.

Please see patch 4 in the series.

> > Signed-off-by: Lee Jones <lee.jones@linaro.org>

> > ---

> >  drivers/mfd/cs5535-mfd.c | 5 +++--

> >  1 file changed, 3 insertions(+), 2 deletions(-)

> > 

> > diff --git a/drivers/mfd/cs5535-mfd.c b/drivers/mfd/cs5535-mfd.c

> > index f1825c0ccbd0..2c47afc22d24 100644

> > --- a/drivers/mfd/cs5535-mfd.c

> > +++ b/drivers/mfd/cs5535-mfd.c

> > @@ -127,10 +127,11 @@ static int cs5535_mfd_probe(struct pci_dev *pdev,

> >  		cs5535_mfd_cells[i].id = 0;

> >  	}

> >  

> > -	err = mfd_add_devices(&pdev->dev, -1, cs5535_mfd_cells,

> > +	err = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE, cs5535_mfd_cells,

> >  			      ARRAY_SIZE(cs5535_mfd_cells), NULL, 0, NULL);

> >  	if (err) {

> > -		dev_err(&pdev->dev, "MFD add devices failed: %d\n", err);

> > +		dev_err(&pdev->dev,

> > +			"Failed to add CS5532 sub-devices: %d\n", err);

> 

>                                            ^^^

> 

> Typo (and MODULE_DESCRIPTION() says this is a driver for CS5536 too).

> Once that is fixed:

> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>


Ta.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Lee Jones Oct. 21, 2019, 11:35 a.m. UTC | #3
On Mon, 21 Oct 2019, Lee Jones wrote:

> On Mon, 21 Oct 2019, Daniel Thompson wrote:

> 

> > On Mon, Oct 21, 2019 at 11:58:14AM +0100, Lee Jones wrote:

> > > In most contexts '-1' doesn't really mean much to the casual observer.

> > > In almost all cases, it's better to use a human readable define.  In

> > > this case PLATFORM_DEVID_* defines have already been provided for this

> > > purpose.

> > > 

> > > While we're here, let's be specific about the 'MFD devices' which

> > > failed.  It will help when trying to distinguish which of the 2 sets

> > > of sub-devices we actually failed to register.

> > 

> > No objections... but won't the tag added by dev_err() already

> > disambiguate?

> 

> The difference will be between CS5532 and  CS5532 OLPC.

> 

> Please see patch 4 in the series.

> 

> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>

> > > ---

> > >  drivers/mfd/cs5535-mfd.c | 5 +++--

> > >  1 file changed, 3 insertions(+), 2 deletions(-)

> > > 

> > > diff --git a/drivers/mfd/cs5535-mfd.c b/drivers/mfd/cs5535-mfd.c

> > > index f1825c0ccbd0..2c47afc22d24 100644

> > > --- a/drivers/mfd/cs5535-mfd.c

> > > +++ b/drivers/mfd/cs5535-mfd.c

> > > @@ -127,10 +127,11 @@ static int cs5535_mfd_probe(struct pci_dev *pdev,

> > >  		cs5535_mfd_cells[i].id = 0;

> > >  	}

> > >  

> > > -	err = mfd_add_devices(&pdev->dev, -1, cs5535_mfd_cells,

> > > +	err = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE, cs5535_mfd_cells,

> > >  			      ARRAY_SIZE(cs5535_mfd_cells), NULL, 0, NULL);

> > >  	if (err) {

> > > -		dev_err(&pdev->dev, "MFD add devices failed: %d\n", err);

> > > +		dev_err(&pdev->dev,

> > > +			"Failed to add CS5532 sub-devices: %d\n", err);

> > 

> >                                            ^^^

> > 

> > Typo (and MODULE_DESCRIPTION() says this is a driver for CS5536 too).

> > Once that is fixed:

> > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>

> 

> Ta.


Looks like this comes from the failed message from the
mfd_add_devices() above.  I'll fix both.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
diff mbox series

Patch

diff --git a/drivers/mfd/cs5535-mfd.c b/drivers/mfd/cs5535-mfd.c
index f1825c0ccbd0..2c47afc22d24 100644
--- a/drivers/mfd/cs5535-mfd.c
+++ b/drivers/mfd/cs5535-mfd.c
@@ -127,10 +127,11 @@  static int cs5535_mfd_probe(struct pci_dev *pdev,
 		cs5535_mfd_cells[i].id = 0;
 	}
 
-	err = mfd_add_devices(&pdev->dev, -1, cs5535_mfd_cells,
+	err = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE, cs5535_mfd_cells,
 			      ARRAY_SIZE(cs5535_mfd_cells), NULL, 0, NULL);
 	if (err) {
-		dev_err(&pdev->dev, "MFD add devices failed: %d\n", err);
+		dev_err(&pdev->dev,
+			"Failed to add CS5532 sub-devices: %d\n", err);
 		goto err_disable;
 	}