From patchwork Thu Oct 24 16:38:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 177541 Delivered-To: patch@linaro.org Received: by 2002:ac9:3c86:0:0:0:0:0 with SMTP id w6csp2399892ocf; Thu, 24 Oct 2019 09:38:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqy2zatgr7bQANhDuS+nNpv5apYdK3aPSUz3PQOxMmrAymGlwg29QJ7L41xr3j3cbmdfdcN8 X-Received: by 2002:a17:906:e243:: with SMTP id gq3mr21042723ejb.302.1571935123172; Thu, 24 Oct 2019 09:38:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571935123; cv=none; d=google.com; s=arc-20160816; b=TRiILfHqfkEPDO0VfUMKUqmomFlhpew+ndn9VwM2j9OJ+NBVw5iMrIM8bZXuFoID5N z3jps3Ft+rIUCP10RanNlijFNlZ5cHVjEAYU7Sm9UpXRUw85W0zOWkeh8NVGFdr2UqBc uSEuRu8EZgF/nhnPsQWqAEnRbXc1FHwi6xafleIiVf2+HAVEmyKR+dr0Ic/0ivCuO2mL J9Oz3SpxD+AGU7YakcEPHMpjc2bRNAyAesWZHVJVUzN8RbA8pJvxcViOkIjBicENdgB/ uZF5if0yxsHNgir8UTjzaq/xAwNjXKEHiyHprbJSsL9QB8iA+MH2XZVyX+PsW/I/II3N Kn/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=YZmXO5ePw27XXjmw9aqXqaRd2VOTfPGeZBWp3iFdesM=; b=lO2slUDqP5dEH0jrdnu9kGklLHUR8+rQ0YUd8tB5kN1oxp4ZBHyAFD0n82hMWHtrIm Bp8lWLxmtYBhD07VY9AWYGTBFvCQd2dh6qOCWgOCDbbM7vqkt8GtZblA97jS595Qn/vy IjVCA5INkqKwi9fXXmEtJwEaKOYGFSYa1UF/Cqkwgv2JDO3OkFb7vfEUwKBu0lPkm5NG qUGJAyXN9l4QqjNJ1ED3xa4uc4lszmis1m1xuLFA+3fE4gSNWDNGW5C+GHad+dYnLfmc BnA9XvyKA5Me0NXriWk+fZRCOITa3aIsEgBEwFoD7VPWHz9zt8BocezM+tRACF5cEi3Q dz+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vPFphUo3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g31si813582eda.325.2019.10.24.09.38.42; Thu, 24 Oct 2019 09:38:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vPFphUo3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2503514AbfJXQik (ORCPT + 26 others); Thu, 24 Oct 2019 12:38:40 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:55657 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2503426AbfJXQik (ORCPT ); Thu, 24 Oct 2019 12:38:40 -0400 Received: by mail-wm1-f65.google.com with SMTP id g24so3569651wmh.5 for ; Thu, 24 Oct 2019 09:38:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YZmXO5ePw27XXjmw9aqXqaRd2VOTfPGeZBWp3iFdesM=; b=vPFphUo33Onh8HRK4E07pTzJ1f7NIAzAGVk483hJ9mrqwhKfpeM412ZrC+Mtnwzjp0 DT1qMsJ1/gCPq/F/1t4EqBTeVlCle5hjmdv+3EVPmZqvcSyOISZhN7XQp+GCXC6OBtuO J7eCaraw0d5fPtceFvVKfhirGWtc0Vpt1Y1gYBnNRe9ANPznLbQT7maKwMwOUxYQWAZu jexVQdSBRqBwtoNmWVaI816+ONrnsa1y6KWin9KEM0kUlFKJrjEtgNJlwaMBQKrnLylh M5tKLQIYz2aipnWQ9VGhgsLOmEfw2HuI9knyh2cHeVQy/RnXX32xk1Y8NUkbXHDcSPjL +b6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YZmXO5ePw27XXjmw9aqXqaRd2VOTfPGeZBWp3iFdesM=; b=UEsruUxgwwP6yOpheaowsx0AuMcWrzdMEB8CADS+ieCiG5WeFxbUBJPMKmGjQm1+kJ /CSrqNb00fuRzbPRghIhrsXvZFgZnLEDFsyHiJx2STeXCiIiPPDtTiyjDSQAP/Zh6BHJ YR75KqeD4W6VLAfdsMlJS47/0JPdaUAdTn7iqf8ILcZVwj7f8ANhNEY9N91DCTVmQ0Xe xAoxZUP+oK4urRuj2Ofd7I0JxvNGgJIxZzrmqSItppOoe8Ok+X/crruXTngPgG4XaJCf 3YIkCsCu9CGG/WG7DoM8584FQaohkPuODniz8xKmpTTQSj2IlF5BkHknLiGZIMVhMPk/ /v6A== X-Gm-Message-State: APjAAAXsBP21BAzuTgpYEImFwnAyln/42GANnyooTBOQSuILq1oqxXfk fbY0HdLmyEWINBlST8S86NG48g== X-Received: by 2002:a7b:c959:: with SMTP id i25mr6065618wml.26.1571935117250; Thu, 24 Oct 2019 09:38:37 -0700 (PDT) Received: from localhost.localdomain ([95.149.164.99]) by smtp.gmail.com with ESMTPSA id 6sm3446175wmd.36.2019.10.24.09.38.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2019 09:38:36 -0700 (PDT) From: Lee Jones To: daniel.thompson@linaro.org, arnd@arndb.de, broonie@kernel.org, linus.walleij@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, baohua@kernel.org, stephan@gerhold.net, Lee Jones Subject: [PATCH v3 01/10] mfd: cs5535-mfd: Use PLATFORM_DEVID_* defines and tidy error message Date: Thu, 24 Oct 2019 17:38:23 +0100 Message-Id: <20191024163832.31326-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191024163832.31326-1-lee.jones@linaro.org> References: <20191024163832.31326-1-lee.jones@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In most contexts '-1' doesn't really mean much to the casual observer. In almost all cases, it's better to use a human readable define. In this case PLATFORM_DEVID_* defines have already been provided for this purpose. While we're here, let's be specific about the 'MFD devices' which failed. It will help when trying to distinguish which of the 2 sets of sub-devices we actually failed to register. Signed-off-by: Lee Jones Reviewed-by: Daniel Thompson --- drivers/mfd/cs5535-mfd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/drivers/mfd/cs5535-mfd.c b/drivers/mfd/cs5535-mfd.c index f1825c0ccbd0..cda7f5b942e7 100644 --- a/drivers/mfd/cs5535-mfd.c +++ b/drivers/mfd/cs5535-mfd.c @@ -127,10 +127,11 @@ static int cs5535_mfd_probe(struct pci_dev *pdev, cs5535_mfd_cells[i].id = 0; } - err = mfd_add_devices(&pdev->dev, -1, cs5535_mfd_cells, + err = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE, cs5535_mfd_cells, ARRAY_SIZE(cs5535_mfd_cells), NULL, 0, NULL); if (err) { - dev_err(&pdev->dev, "MFD add devices failed: %d\n", err); + dev_err(&pdev->dev, + "Failed to add CS5535 sub-devices: %d\n", err); goto err_disable; }