From patchwork Tue Nov 19 14:16:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tero Kristo X-Patchwork-Id: 179758 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp698352ilf; Tue, 19 Nov 2019 06:18:08 -0800 (PST) X-Google-Smtp-Source: APXvYqyjG22iurWjjUaFMIsnR3JNkdFY2/o4P9D1A2yqjZhFLki69UuLYfZVuJV8yWr56PlmKWQf X-Received: by 2002:a05:600c:3cc:: with SMTP id z12mr6319544wmd.151.1574173087948; Tue, 19 Nov 2019 06:18:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574173087; cv=none; d=google.com; s=arc-20160816; b=MVvs1Iru274cl4vCS6cc3Tv4nJUnnSA4KQm4nJcDF282bGH24WbeqbNkO95l8bldWH aua8jNmok38SJaxv2x94nNMqANe0DPzVNcvp9sALZ0DaXl2qR2TOBygktCWVZ48hnytF cDoO0LytITFh4u7CFdYEHis59IzxCWxu2JIpzKwFAbJQQ1TVzNoGQwxeIBurYQfxlz4t aQnUP2AcWIHVp7sA1xzMn6w3a4LiQrBFNbcEMAopiabNC+mdTys1AL5vjNBKPaOwiLDI qWhoO9YnzAbsRqlGEqUnwHgzejB7348rtRXzHAnCa9TYI8PvOEZw9L6RGfx52K/Ewn5J hSIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=ZxSeH7426itbuI2GFr2ZNV2hY6DNiUZOU/kNhIh8m7o=; b=Ebj+BvlNBdOdU5WGrD5+adN7DC+8WsIXTVWTbuPewBLNocyOxfz72c2likGj5QBBaK HVtYRrISsAEbilaRPB56x0z0F9a+qWZrhXaSBC7LHYAKl/bdE+Ln3Fv9U4QsNtFxlZuT iJ2P3SkH6x0TAxzFtv37mFNaz3hJKGnfzHDAiwQDujAIbsF6AQYcdun0PqzFZD8L5pLz 0vuION1/La32m1smytH9RClCB0cjzFhOe4aVa56K5mxam9GvytpXP20KXhqswfiuX8FA OeU06R3++hjpHDyUJSDSgeNP1ctZQ9fty+rBWZolU1hEIDiBe9w18P5PyYiIPw3QgTyu 9Jsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=ks5M2C6F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s38si14876719edd.351.2019.11.19.06.18.07; Tue, 19 Nov 2019 06:18:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=ks5M2C6F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728160AbfKSORT (ORCPT + 26 others); Tue, 19 Nov 2019 09:17:19 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:47332 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728093AbfKSORR (ORCPT ); Tue, 19 Nov 2019 09:17:17 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id xAJEHF10128306; Tue, 19 Nov 2019 08:17:15 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1574173035; bh=ZxSeH7426itbuI2GFr2ZNV2hY6DNiUZOU/kNhIh8m7o=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=ks5M2C6FQWYzdbEs9i6CNL0HmlW8uYIrcBP61OQqF9LXblfLC8hlqi49GB4rWEEnq aq9RpgiDX6FOgdBFF+GVhxavFbhPyOXOteoIX6192I8ZOxFQrroDKU7Dn25XeiXSF9 4pG0jKVMZMhbPgQpu5gd/n3AP6dHiDyDtFf5BucY= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id xAJEHFMc100510 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 19 Nov 2019 08:17:15 -0600 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Tue, 19 Nov 2019 08:17:14 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Tue, 19 Nov 2019 08:17:14 -0600 Received: from sokoban.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id xAJEGvZ0027070; Tue, 19 Nov 2019 08:17:12 -0600 From: Tero Kristo To: , , CC: , , , Tero Kristo Subject: [PATCHv2 07/15] remoteproc/omap: Add support for DRA7xx remote processors Date: Tue, 19 Nov 2019 16:16:37 +0200 Message-ID: <20191119141645.19777-8-t-kristo@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191119141645.19777-1-t-kristo@ti.com> References: <20191119141645.19777-1-t-kristo@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Suman Anna DRA7xx/AM57xx SoCs have two IPU and up to two DSP processor subsystems for offloading different computation algorithms. The IPU processor subsystem contains dual-core ARM Cortex-M4 processors, and is very similar to those on OMAP5. The DSP processor subsystem is based on the TI's standard TMS320C66x DSP CorePac core. Support has been added to the OMAP remoteproc driver through new DRA7xx specific compatibles for properly probing and booting all the different processor subsystem instances on DRA7xx/AM57xx SoCs - IPU1, IPU2, DSP1 & DSP2. A build dependency with SOC_DRA7XX is added to enable the driver to be built in DRA7xx-only configuration. The DSP boot address programming needed enhancement for DRA7xx as the boot register fields are different on DRA7 compared to OMAP4 and OMAP5 SoCs. The register on DRA7xx contains additional fields within the register and the boot address bit-field is right-shifted by 10 bits. The internal memory parsing logic has also been updated to compute the device addresses for the L2 RAM for DSP devices using relative addressing logic, and to parse two additional RAMs at L1 level - L1P and L1D. This allows the remoteproc driver to support loading into these regions for a small subset of firmware images requiring as such. The most common usage would be to use the L1 programmable RAMs as L1 Caches. The firmware lookup logic also has to be adjusted for DRA7xx as there are (can be) more than one instance of both the IPU and DSP remote processors for the first time in OMAP4+ SoCs. Signed-off-by: Suman Anna [t-kristo@ti.com: moved address translation quirks to pdata] Signed-off-by: Tero Kristo --- v2: - moved address translation quirks to pdata drivers/remoteproc/Kconfig | 2 +- drivers/remoteproc/omap_remoteproc.c | 45 +++++++++++++++++++++++++++- 2 files changed, 45 insertions(+), 2 deletions(-) -- 2.17.1 -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig index 94afdde4bc9f..d6450d7fcf92 100644 --- a/drivers/remoteproc/Kconfig +++ b/drivers/remoteproc/Kconfig @@ -25,7 +25,7 @@ config IMX_REMOTEPROC config OMAP_REMOTEPROC tristate "OMAP remoteproc support" - depends on ARCH_OMAP4 || SOC_OMAP5 + depends on ARCH_OMAP4 || SOC_OMAP5 || SOC_DRA7XX depends on OMAP_IOMMU select MAILBOX select OMAP2PLUS_MBOX diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c index 3ad74c4b4071..4af55d1f2702 100644 --- a/drivers/remoteproc/omap_remoteproc.c +++ b/drivers/remoteproc/omap_remoteproc.c @@ -34,10 +34,13 @@ * struct omap_rproc_boot_data - boot data structure for the DSP omap rprocs * @syscon: regmap handle for the system control configuration module * @boot_reg: boot register offset within the @syscon regmap + * @boot_reg_shift: bit-field shift required for the boot address value in + * @boot_reg */ struct omap_rproc_boot_data { struct regmap *syscon; unsigned int boot_reg; + unsigned int boot_reg_shift; }; /* @@ -78,12 +82,14 @@ struct omap_rproc { * struct omap_rproc_dev_data - device data for the omap remote processor * @device_name: device name of the remote processor * @has_bootreg: true if this remote processor has boot register + * @boot_reg_shift: bit shift for the boot register mask * @mem_names: memory names for this remote processor * @dev_addrs: device addresses corresponding to the memory names */ struct omap_rproc_dev_data { const char *device_name; bool has_bootreg; + int boot_reg_shift; const char * const *mem_names; const u32 *dev_addrs; }; @@ -153,6 +159,8 @@ static int omap_rproc_write_dsp_boot_addr(struct rproc *rproc) struct omap_rproc *oproc = rproc->priv; struct omap_rproc_boot_data *bdata = oproc->boot_data; u32 offset = bdata->boot_reg; + u32 value; + u32 mask; if (rproc->bootaddr & (SZ_1K - 1)) { dev_err(dev, "invalid boot address 0x%x, must be aligned on a 1KB boundary\n", @@ -160,7 +168,10 @@ static int omap_rproc_write_dsp_boot_addr(struct rproc *rproc) return -EINVAL; } - regmap_write(bdata->syscon, offset, rproc->bootaddr); + value = rproc->bootaddr >> bdata->boot_reg_shift; + mask = ~(SZ_1K - 1) >> bdata->boot_reg_shift; + + regmap_update_bits(bdata->syscon, offset, mask, value); return 0; } @@ -286,6 +297,14 @@ static const u32 ipu_dev_addrs[] = { 0x20000000, }; +static const char * const dra7_dsp_mem_names[] = { + "l2ram", "l1pram", "l1dram", NULL +}; + +static const u32 dra7_dsp_dev_addrs[] = { + 0x800000, 0xe00000, 0xf00000, +}; + static const struct omap_rproc_dev_data omap4_dsp_dev_data = { .device_name = "dsp", .has_bootreg = true, @@ -308,6 +327,20 @@ static const struct omap_rproc_dev_data omap5_ipu_dev_data = { .dev_addrs = ipu_dev_addrs, }; +static const struct omap_rproc_dev_data dra7_dsp_dev_data = { + .device_name = "dsp", + .has_bootreg = true, + .boot_reg_shift = 10, + .mem_names = dra7_dsp_mem_names, + .dev_addrs = dra7_dsp_dev_addrs, +}; + +static const struct omap_rproc_dev_data dra7_ipu_dev_data = { + .device_name = "ipu", + .mem_names = ipu_mem_names, + .dev_addrs = ipu_dev_addrs, +}; + static const struct of_device_id omap_rproc_of_match[] = { { .compatible = "ti,omap4-dsp", @@ -325,6 +358,14 @@ static const struct of_device_id omap_rproc_of_match[] = { .compatible = "ti,omap5-ipu", .data = &omap5_ipu_dev_data, }, + { + .compatible = "ti,dra7-dsp", + .data = &dra7_dsp_dev_data, + }, + { + .compatible = "ti,dra7-ipu", + .data = &dra7_ipu_dev_data, + }, { /* end */ }, @@ -382,6 +423,8 @@ static int omap_rproc_get_boot_data(struct platform_device *pdev, return -EINVAL; } + oproc->boot_data->boot_reg_shift = data->boot_reg_shift; + return 0; }