From patchwork Wed Jan 22 08:24:13 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Shi X-Patchwork-Id: 23486 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f200.google.com (mail-pd0-f200.google.com [209.85.192.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id EE882218DC for ; Wed, 22 Jan 2014 08:24:33 +0000 (UTC) Received: by mail-pd0-f200.google.com with SMTP id y10sf147127pdj.7 for ; Wed, 22 Jan 2014 00:24:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to:sender:precedence :list-id:x-original-sender:x-original-authentication-results :mailing-list:list-post:list-help:list-archive:list-unsubscribe :content-type:content-transfer-encoding; bh=gvmXOBcclGm0e0hAbvRQ75a/kA3SgMoPw+MxLS9BMFc=; b=ClcIH4zt+qw/scQRWTFp1icKj6AAWkxUQPCkSyzCj6IwhoEyv1Kf5DYOLCMDYFE/4F kjzXXtxzhU42Q2WgNZahp/Tu2bzHAQhxCdSrKpnfIFPvYDTb4m05Oks+b5P+v3b1CEBQ Vz43SHEbtReQS2ztdQ+4+aHPJ9VJojdoyMfLuzmoS9LPrzOXuXRh34BWTNqcSFkuFMru IRzJ/MVKYHesij9HbPunXZ0t/GUYWq+O7wUvzoNT2+3LZlCYEhathO3kxR1WF7VKV4cw Orj8KaI5ofCyqoe2lMVYup8bg7XQ3AlZY7b5h2JN27cwfM0iEkVsXKZpczqd7pZi67wq 4+jQ== X-Gm-Message-State: ALoCoQmq4Uz08sX53dSrO2+gWLKftGe+mbKBETA8ocgfrFzN7mmDPEgLyUacnupfTHn5T7V336/W X-Received: by 10.68.197.137 with SMTP id iu9mr93665pbc.3.1390379073216; Wed, 22 Jan 2014 00:24:33 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.62.169 with SMTP id z9ls8486qer.42.gmail; Wed, 22 Jan 2014 00:24:33 -0800 (PST) X-Received: by 10.220.168.65 with SMTP id t1mr66893vcy.76.1390379073054; Wed, 22 Jan 2014 00:24:33 -0800 (PST) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx.google.com with ESMTPS id qw5si4075398vcb.48.2014.01.22.00.24.33 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 22 Jan 2014 00:24:33 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.182 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.182; Received: by mail-vc0-f182.google.com with SMTP id id10so33766vcb.41 for ; Wed, 22 Jan 2014 00:24:33 -0800 (PST) X-Received: by 10.58.187.98 with SMTP id fr2mr86494vec.38.1390379072968; Wed, 22 Jan 2014 00:24:32 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.174.196 with SMTP id u4csp169200vcz; Wed, 22 Jan 2014 00:24:32 -0800 (PST) X-Received: by 10.68.130.103 with SMTP id od7mr138866pbb.87.1390379071795; Wed, 22 Jan 2014 00:24:31 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r3si2458162pbh.40.2014.01.22.00.24.31; Wed, 22 Jan 2014 00:24:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750746AbaAVIYV (ORCPT + 27 others); Wed, 22 Jan 2014 03:24:21 -0500 Received: from mail-pb0-f50.google.com ([209.85.160.50]:39033 "EHLO mail-pb0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751696AbaAVIYS (ORCPT ); Wed, 22 Jan 2014 03:24:18 -0500 Received: by mail-pb0-f50.google.com with SMTP id rq2so71476pbb.37 for ; Wed, 22 Jan 2014 00:24:18 -0800 (PST) X-Received: by 10.66.43.135 with SMTP id w7mr124522pal.97.1390379058067; Wed, 22 Jan 2014 00:24:18 -0800 (PST) Received: from [10.0.0.100] ([162.243.130.63]) by mx.google.com with ESMTPSA id sx8sm42801645pab.5.2014.01.22.00.24.14 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 22 Jan 2014 00:24:16 -0800 (PST) Message-ID: <52DF802D.4030608@linaro.org> Date: Wed, 22 Jan 2014 16:24:13 +0800 From: Alex Shi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Jason Low CC: Ingo Molnar , Peter Zijlstra , morten.rasmussen@arm.com, vincent.guittot@linaro.org, daniel.lezcano@linaro.org, Mike Galbraith , wangyun@linux.vnet.ibm.com, Linux Kernel Mailing List Subject: Re: [PATCH 2/2] sched: add statistic for rq->max_idle_balance_cost References: <1390282399-17091-1-git-send-email-alex.shi@linaro.org> <1390282399-17091-2-git-send-email-alex.shi@linaro.org> In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: alex.shi@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.182 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 01/21/2014 03:43 PM, Jason Low wrote: > On Mon, Jan 20, 2014 at 9:33 PM, Alex Shi wrote: >> It's useful to track this value in debug mode. >> >> Signed-off-by: Alex Shi >> --- >> kernel/sched/debug.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c >> index 1e43e70..f5c529a 100644 >> --- a/kernel/sched/debug.c >> +++ b/kernel/sched/debug.c >> @@ -315,6 +315,7 @@ do { \ >> P(sched_goidle); >> #ifdef CONFIG_SMP >> P64(avg_idle); >> + p64(max_idle_balance_cost); > > Hi Alex, > > Does this need to be P64(max_idle_balance_cost)? > Ops, this letter lay in my Drafts box. Yes, thanks for fix! === >From 173417f3646ac1c6ac83809b51d0471591cbc8f0 Mon Sep 17 00:00:00 2001 From: Alex Shi Date: Tue, 21 Jan 2014 13:28:55 +0800 Subject: [RFC PATCH] sched: add statistic for rq->max_idle_balance_cost It's useful to track this value in debug mode. Signed-off-by: Alex Shi --- kernel/sched/debug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c index 1e43e70..f5c529a 100644 --- a/kernel/sched/debug.c +++ b/kernel/sched/debug.c @@ -315,6 +315,7 @@ do { \ P(sched_goidle); #ifdef CONFIG_SMP P64(avg_idle); + P64(max_idle_balance_cost); #endif P(ttwu_count); -- 1.8.1.2