From patchwork Mon Apr 11 16:24:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 65551 Delivered-To: patch@linaro.org Received: by 10.112.43.237 with SMTP id z13csp1570830lbl; Mon, 11 Apr 2016 09:24:44 -0700 (PDT) X-Received: by 10.98.75.147 with SMTP id d19mr33554204pfj.29.1460391884540; Mon, 11 Apr 2016 09:24:44 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 74si4248846pfk.37.2016.04.11.09.24.44; Mon, 11 Apr 2016 09:24:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754221AbcDKQYm (ORCPT + 29 others); Mon, 11 Apr 2016 12:24:42 -0400 Received: from foss.arm.com ([217.140.101.70]:50960 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbcDKQYl (ORCPT ); Mon, 11 Apr 2016 12:24:41 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2FD2C28; Mon, 11 Apr 2016 09:23:27 -0700 (PDT) Received: from [10.1.207.150] (e103737-lin.cambridge.arm.com [10.1.207.150]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 32C3A3F25F; Mon, 11 Apr 2016 09:24:39 -0700 (PDT) Cc: Sudeep Holla , Stephen Hemminger , Mirko Lindner To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org From: Sudeep Holla Subject: Unhandled fault during system suspend in sky2_shutdown Organization: ARM Message-ID: <570BCFC5.4070208@arm.com> Date: Mon, 11 Apr 2016 17:24:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I am seeing unhandled fault during system suspend in sky2_shutdown. I am not sure if it's something missing in the firmware, but just wanted to check. I see that networkmanager is invoking calling to netlink_sendmsg which calls sky2_get_stats after the device is shutdown. Unhandled fault: synchronous external abort (0x96000210) at 0xffff0000091c2918 Internal error: : 96000210 [#1] PREEMPT SMP Modules linked in: CPU: 3 PID: 2029 Comm: NetworkManager Not tainted 4.6.0-rc3 #126 Hardware name: ARM Juno development board (r2) (DT) task: ffff80007a673000 ti: ffff800940b5c000 task.ti: ffff800940b5c000 PC is at sky2_get_stats+0x44/0x3b8 LR is at dev_get_stats+0x58/0xc8 sky2_get_stats+0x44/0x3b8 rtnl_fill_stats+0x20/0x138 rtnl_fill_ifinfo+0x440/0xb38 rtnl_getlink+0xe8/0x198 rtnetlink_rcv_msg+0xe4/0x220 netlink_rcv_skb+0xc4/0xf8 rtnetlink_rcv+0x2c/0x40 netlink_unicast+0x160/0x238 netlink_sendmsg+0x2f0/0x358 sock_sendmsg+0x18/0x30 ___sys_sendmsg+0x204/0x218 __sys_sendmsg+0x44/0x88 SyS_sendmsg+0xc/0x18 el0_svc_naked+0x24/0x28 The below patch is the hack I came up to check if the netdev is detached and unregistered, I no longer see the issue. Regards, Sudeep -->8 pci_set_power_state(pdev, PCI_D3hot); diff --git i/drivers/net/ethernet/marvell/sky2.c w/drivers/net/ethernet/marvell/sky2.c index ec0a22119e09..0ff0434e32fc 100644 --- i/drivers/net/ethernet/marvell/sky2.c +++ w/drivers/net/ethernet/marvell/sky2.c @@ -5220,6 +5220,13 @@ static SIMPLE_DEV_PM_OPS(sky2_pm_ops, sky2_suspend, sky2_resume); static void sky2_shutdown(struct pci_dev *pdev) { + struct sky2_hw *hw = pci_get_drvdata(pdev); + int i; + + for (i = hw->ports - 1; i >= 0; --i) { + sky2_detach(hw->dev[i]); + unregister_netdev(hw->dev[i]); + } sky2_suspend(&pdev->dev); pci_wake_from_d3(pdev, device_may_wakeup(&pdev->dev));