From patchwork Sat Dec 7 10:17:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean Pihet X-Patchwork-Id: 22138 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qe0-f70.google.com (mail-qe0-f70.google.com [209.85.128.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id A7D5823FD2 for ; Sat, 7 Dec 2013 10:17:05 +0000 (UTC) Received: by mail-qe0-f70.google.com with SMTP id 6sf3586875qea.1 for ; Sat, 07 Dec 2013 02:17:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=YCNXC06rN7IvNI2NSa5KN+RtaTGqx73EL9sxSujom8E=; b=Hm5sknGZ8+kHvx7oXDIaxbTGj3fyvaAb9uISKgbuWukTHKU5/KbtADn6AAy/v40shH cz3WBQbEYWqEt4/f2QrfaO9gbW7biwjni96D/yCZXHtOth0qmUBr0aiej31Z2edj9CUs HoJXRpHf0Ktzi3t++5eo/uKmZum6QD9VJ2NVTUhxfPFu9yYPco4EEJ3+LqCtQ18mLNJ0 gTruBHFnBnFBUZFgzlfUZCL6QaOcaRsE2ZqhFFDpxWtDEd160xe9BR0wyqTrtavT0Wzy ZmlLRaZboitsUCd0ZVyJ1bhJBWRYp2sWyx1I1DukZnWuKPfp62VOfIjio2/hlrTMFH7G A1kg== X-Gm-Message-State: ALoCoQmGI0s7xhm8WbQ8qETQeQN3QossMpnwLqW9O+e0DF6bOQxqMAqJy+pje9j184K/V0UpVsfs X-Received: by 10.236.52.7 with SMTP id d7mr2692481yhc.32.1386411424806; Sat, 07 Dec 2013 02:17:04 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.17.65 with SMTP id m1ls1656415qed.91.gmail; Sat, 07 Dec 2013 02:17:04 -0800 (PST) X-Received: by 10.220.95.139 with SMTP id d11mr4815506vcn.21.1386411424644; Sat, 07 Dec 2013 02:17:04 -0800 (PST) Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com [209.85.220.181]) by mx.google.com with ESMTPS id eb1si675270vec.144.2013.12.07.02.17.04 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 07 Dec 2013 02:17:04 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.181; Received: by mail-vc0-f181.google.com with SMTP id ks9so1768633vcb.26 for ; Sat, 07 Dec 2013 02:17:04 -0800 (PST) X-Received: by 10.221.19.5 with SMTP id qi5mr4738854vcb.15.1386411424441; Sat, 07 Dec 2013 02:17:04 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp163413vcz; Sat, 7 Dec 2013 02:17:04 -0800 (PST) X-Received: by 10.52.98.99 with SMTP id eh3mr4039159vdb.29.1386411423650; Sat, 07 Dec 2013 02:17:03 -0800 (PST) Received: from mail-vc0-f172.google.com (mail-vc0-f172.google.com [209.85.220.172]) by mx.google.com with ESMTPS id e3si686031vek.93.2013.12.07.02.17.03 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 07 Dec 2013 02:17:03 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.172 is neither permitted nor denied by best guess record for domain of jean.pihet@linaro.org) client-ip=209.85.220.172; Received: by mail-vc0-f172.google.com with SMTP id hz11so1785084vcb.17 for ; Sat, 07 Dec 2013 02:17:03 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.52.50.177 with SMTP id d17mr3982217vdo.23.1386411422807; Sat, 07 Dec 2013 02:17:02 -0800 (PST) Received: by 10.58.96.5 with HTTP; Sat, 7 Dec 2013 02:17:02 -0800 (PST) In-Reply-To: References: <1385583394-3703-1-git-send-email-acme@infradead.org> <1385583394-3703-35-git-send-email-acme@infradead.org> <20131127224323.GB1350@krava.redhat.com> <20131128095801.GA1245@krava.brq.redhat.com> <20131128125619.GA12292@ghostprotocols.net> <20131128134642.GB12292@ghostprotocols.net> <20131129154549.GA28562@krava.brq.redhat.com> Date: Sat, 7 Dec 2013 11:17:02 +0100 Message-ID: Subject: Re: [PATCH 34/34] perf tools unwinding: Use the per-feature check flags From: Jean Pihet To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , Ingo Molnar , "linux-kernel@vger.kernel.org" , Will Deacon , "linaro-kernel@lists.linaro.org" , Patch Tracking X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: jean.pihet@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Hi, On 3 December 2013 17:15, Jean Pihet wrote: > I just resent the patches as v2. > > I tested on x86_64, ARMv7 and ARMv8 with and without LIBUNWIND_DIR= > set in 'make -C tools/perf'. Can you check on your build setup? I just found that the linker options may not work on some distros (in my case Ubuntu on ARMv7). The fix is here below. v3 is on its way. Can you please check? Thanks, Jean > > On 29 November 2013 16:45, Jiri Olsa wrote: >> On Thu, Nov 28, 2013 at 09:02:23PM +0100, Jean Pihet wrote: >>> On 28 November 2013 14:46, Arnaldo Carvalho de Melo wrote: >>> > Em Thu, Nov 28, 2013 at 09:56:19AM -0300, Arnaldo Carvalho de Melo escreveu: >>> >> Em Thu, Nov 28, 2013 at 10:58:01AM +0100, Jiri Olsa escreveu: >>> >> > On Wed, Nov 27, 2013 at 11:43:23PM +0100, Jiri Olsa wrote: >>> >> > > On Wed, Nov 27, 2013 at 05:16:34PM -0300, Arnaldo Carvalho de Melo wrote: >>> >> > > LINK perf >>> >> > > /bin/ld: cannot find -lunwind >>> >> > > /bin/ld: cannot find -lunwind-x86_64 >>> >> > > collect2: error: ld returned 1 exit status >>> >> > > make[1]: *** [perf] Error 1 >>> >> > > make[1]: *** Waiting for unfinished jobs.... >>> >> > > make: *** [all] Error 2 >>> >> >>> >> > > I haven't checked this one.. will do tomorrow >>> >> >>> >> > we need to plug libunwind flags/libs only if >>> >> > the $(feature-libunwind) is enabled.. >>> >> >>> >> > NO_LIBUNWIND - user's decision not to link with libunwind or >>> >> > architecture that does not support it >>> >> >>> >> > $(feature-libunwind) - if it's actually installed >>> >> >>> >> > attached change fixies that for me, feel free to use/merge it >>> >> >>> >> Argh, I used tests/make on one machine where those two patches by Jean >>> >> were not applied, then rebased on another, the one I use to submit, >>> >> those got included but not tests/make tested, which probably explains >>> >> why this got thru :-\ >>> >> >>> >> Jean, can you please check that this works for you on ARM too? >>> > >>> > I just noticed that this patch breaks the feature detection mechanism, >>> > after it is applied it is back performing all tests at every make call, >>> > this needs rethinking, so I'm dropping both. >>> Oh I am sorry about that. I tested on ARM with and without the >>> LIBUNWIND_DIR option set. >>> Let me rethink/rework this and come back to you with a proper fix. >>> >>> > >>> > Ingo, please disregard, yet again, my latest pull request, sigh. >>> > >>> > Jiri, this could be something for tests/make, till then I'll try >>> > to check this manually. >>> >>> One question though: are you OK with the principle of having >>> per-feature check flags? This brings two things to the feature >>> detection and build: >>> 1. the ability to specify specific flags for the feature check, which >>> is not possible on the current code, >>> 2. a simplification in the Makefiles. >> >> looks good to me >> >> jirka diff --git a/tools/perf/config/feature-checks/Makefile b/tools/perf/config/feature-checks/Makefile index 87e7900..0bf3af7 100644 --- a/tools/perf/config/feature-checks/Makefile +++ b/tools/perf/config/feature-checks/Makefile @@ -33,7 +33,7 @@ CC := $(CC) -MD all: $(FILES) -BUILD = $(CC) $(CFLAGS) $(LDFLAGS) -o $(OUTPUT)$@ $@.c +BUILD = $(CC) $(CFLAGS) -o $(OUTPUT)$@ $@.c $(LDFLAGS) ###############################