From patchwork Fri Nov 7 09:36:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 40380 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f69.google.com (mail-wg0-f69.google.com [74.125.82.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 300AA24237 for ; Fri, 7 Nov 2014 09:37:02 +0000 (UTC) Received: by mail-wg0-f69.google.com with SMTP id l18sf1640035wgh.8 for ; Fri, 07 Nov 2014 01:37:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=UT5PLmWJwxoROb0U5xVGVx4BfG3Wvz2IcE8e+MPkfIg=; b=MyC/IMCuFKRXY/IGgUeW4y5xLQ0T6SMOzwlgYzpdiUeQ2SVV2IEemYG6jhpEH1Aipk bRywtCry69To2i9ViJpQrEOQ/BnXdYrSNDqfYOIqt02xvaUKDl9tEBD7DBSdIEMtyNWI liCaBxeK3SwRMb0Cp+ohPzW8ragJ+h+kTkjerq2B0aMlx/c9WZefK7/x3cVDsnn6FRpP zThMj9m55nRJRpDH8WIl+gSv7/mvloLCt30x3MPKFwZPkVloLXpIa7Lbmx4wzDxYrCM5 660CL2urGEKAV17/UtV500+uIksDsDEDdRIJwlSYcqDFdlrdpXkTZVx7xFUC/aY3J+gI VYHA== X-Gm-Message-State: ALoCoQkg/PnNLDSFahIpp6ldpL5GtXFwjSDfwTXTVNz258ZfT68u/j1w2FNf67D7UAeYEXwVC7pH X-Received: by 10.194.91.180 with SMTP id cf20mr207658wjb.4.1415353021477; Fri, 07 Nov 2014 01:37:01 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.26.200 with SMTP id n8ls44973lag.10.gmail; Fri, 07 Nov 2014 01:37:01 -0800 (PST) X-Received: by 10.152.120.167 with SMTP id ld7mr9896400lab.77.1415353021284; Fri, 07 Nov 2014 01:37:01 -0800 (PST) Received: from mail-la0-f50.google.com (mail-la0-f50.google.com. [209.85.215.50]) by mx.google.com with ESMTPS id bc1si14396716lbc.80.2014.11.07.01.37.01 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 07 Nov 2014 01:37:01 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.50 as permitted sender) client-ip=209.85.215.50; Received: by mail-la0-f50.google.com with SMTP id hz20so4125950lab.9 for ; Fri, 07 Nov 2014 01:37:01 -0800 (PST) X-Received: by 10.152.29.8 with SMTP id f8mr10218724lah.56.1415353021185; Fri, 07 Nov 2014 01:37:01 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp171118lbc; Fri, 7 Nov 2014 01:37:00 -0800 (PST) X-Received: by 10.68.236.168 with SMTP id uv8mr10638320pbc.5.1415353019453; Fri, 07 Nov 2014 01:36:59 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id fq1si8443446pdb.197.2014.11.07.01.36.49 for ; Fri, 07 Nov 2014 01:36:59 -0800 (PST) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751399AbaKGJgr (ORCPT + 25 others); Fri, 7 Nov 2014 04:36:47 -0500 Received: from mail-la0-f42.google.com ([209.85.215.42]:51765 "EHLO mail-la0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbaKGJgp (ORCPT ); Fri, 7 Nov 2014 04:36:45 -0500 Received: by mail-la0-f42.google.com with SMTP id gq15so4132915lab.15 for ; Fri, 07 Nov 2014 01:36:43 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.152.203.196 with SMTP id ks4mr10063747lac.51.1415353002945; Fri, 07 Nov 2014 01:36:42 -0800 (PST) Received: by 10.112.84.67 with HTTP; Fri, 7 Nov 2014 01:36:42 -0800 (PST) In-Reply-To: References: <20141107054741.GB30507@yliu-dev.sh.intel.com> <20141107073720.GB24745@yliu-dev.sh.intel.com> <20141107081344.GC24745@yliu-dev.sh.intel.com> <20141107084604.GD24745@yliu-dev.sh.intel.com> <20141107092651.GE24745@yliu-dev.sh.intel.com> Date: Fri, 7 Nov 2014 10:36:42 +0100 Message-ID: Subject: Re: [LKP] [dmi] PANIC: early exception 0e rip 10:ffffffff81899e6b error 9 cr2 ffffffffff240000 From: Ard Biesheuvel To: Yuanhan Liu Cc: LKP , Matt Fleming , Leif Lindholm , LKML Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ard.biesheuvel@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.50 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 7 November 2014 10:35, Ard Biesheuvel wrote: > On 7 November 2014 10:26, Yuanhan Liu wrote: >> On Fri, Nov 07, 2014 at 10:03:55AM +0100, Ard Biesheuvel wrote: >>> On 7 November 2014 09:46, Yuanhan Liu wrote: >>> > On Fri, Nov 07, 2014 at 09:23:56AM +0100, Ard Biesheuvel wrote: >>> >> On 7 November 2014 09:13, Yuanhan Liu wrote: >>> >> > On Fri, Nov 07, 2014 at 08:44:40AM +0100, Ard Biesheuvel wrote: >>> >> >> On 7 November 2014 08:37, Yuanhan Liu wrote: >>> >> >> > On Fri, Nov 07, 2014 at 08:17:36AM +0100, Ard Biesheuvel wrote: >>> >> >> >> On 7 November 2014 06:47, LKP wrote: >>> >> >> >> > FYI, we noticed the below changes on >>> >> >> >> > >>> >> >> >> > https://git.linaro.org/people/ard.biesheuvel/linux-arm efi-for-3.19 >>> >> >> >> > commit aacdce6e880894acb57d71dcb2e3fc61b4ed4e96 ("dmi: add support for SMBIOS 3.0 64-bit entry point") >>> >> >> >> > >>> >> >> >> > >>> >> >> >> > +-----------------------+------------+------------+ >>> >> >> >> > | | 2fa165a26c | aacdce6e88 | >>> >> >> >> > +-----------------------+------------+------------+ >>> >> >> >> > | boot_successes | 20 | 10 | >>> >> >> >> > | early-boot-hang | 1 | | >>> >> >> >> > | boot_failures | 0 | 5 | >>> >> >> >> > | PANIC:early_exception | 0 | 5 | >>> >> >> >> > +-----------------------+------------+------------+ >>> >> >> >> > >>> >> >> >> > >>> >> >> >> > [ 0.000000] BIOS-e820: [mem 0x0000000100000000-0x000000036fffffff] usable >>> >> >> >> > [ 0.000000] bootconsole [earlyser0] enabled >>> >> >> >> > [ 0.000000] NX (Execute Disable) protection: active >>> >> >> >> > PANIC: early exception 0e rip 10:ffffffff81899e6b error 9 cr2 ffffffffff240000 >>> >> >> >> > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 3.18.0-rc2-gc5221e6 #1 >>> >> >> >> > [ 0.000000] 0000000000000000 ffffffff82203d30 ffffffff819f0a6e 00000000000003f8 >>> >> >> >> > [ 0.000000] ffffffffff240000 ffffffff82203e18 ffffffff823701b0 ffffffff82511401 >>> >> >> >> > [ 0.000000] 0000000000000000 0000000000000ba3 0000000000000000 ffffffffff240000 >>> >> >> >> > [ 0.000000] Call Trace: >>> >> >> >> > [ 0.000000] [] dump_stack+0x4e/0x68 >>> >> >> >> > [ 0.000000] [] early_idt_handler+0x90/0xb7 >>> >> >> >> > [ 0.000000] [] ? dmi_save_one_device+0x81/0x81 >>> >> >> >> > [ 0.000000] [] ? dmi_table+0x3f/0x94 >>> >> >> >> > [ 0.000000] [] ? dmi_table+0x16/0x94 >>> >> >> >> > [ 0.000000] [] ? dmi_save_one_device+0x81/0x81 >>> >> >> >> > [ 0.000000] [] ? dmi_save_one_device+0x81/0x81 >>> >> >> >> > [ 0.000000] [] dmi_walk_early+0x44/0x69 >>> >> >> >> > [ 0.000000] [] dmi_present+0x180/0x1ff >>> >> >> >> > [ 0.000000] [] dmi_scan_machine+0x144/0x191 >>> >> >> >> > [ 0.000000] [] ? loglevel+0x31/0x31 >>> >> >> >> > [ 0.000000] [] setup_arch+0x490/0xc73 >>> >> >> >> > [ 0.000000] [] ? printk+0x4d/0x4f >>> >> >> >> > [ 0.000000] [] start_kernel+0x9c/0x43f >>> >> >> >> > [ 0.000000] [] ? early_idt_handlers+0x120/0x120 >>> >> >> >> > [ 0.000000] [] x86_64_start_reservations+0x2a/0x2c >>> >> >> >> > [ 0.000000] [] x86_64_start_kernel+0x13b/0x14a >>> >> >> >> > [ 0.000000] RIP 0x4 >>> >> >> >> > >>> >> >> >> >>> >> >> >> This is most puzzling. Could anyone decode the exception? >>> >> >> >> This looks like the non-EFI path through dmi_scan_machine(), which >>> >> >> >> calls dmi_present() /after/ calling dmi_smbios3_present(), which >>> >> >> >> apparently has not found the _SM3_ header tag. Or could the call stack >>> >> >> >> be inaccurate? >>> >> >> >> >>> >> >> >> Anyway, it would be good to know the exact type of the platform, >>> >> >> > >>> >> >> > It's a Nehalem-EP machine, wht 16 CPU and 12G memory. >>> >> >> > >>> >> >> >> and >>> >> >> >> perhaps we could find out if there is an inadvertent _SM3_ tag >>> >> >> >> somewhere in the 0xF0000 - 0xFFFFF range? >>> >> >> > >>> >> >> > Sorry, how? >>> >> >> > >>> >> >> >>> >> >> That's not a brand new machine, so I suppose there wouldn't be a >>> >> >> SMBIOS 3.0 header lurking in there. >>> >> >> >>> >> >> Anyway, if you are in a position to try things, could you apply this >>> >> >> >>> >> >> --- a/drivers/firmware/dmi_scan.c >>> >> >> +++ b/drivers/firmware/dmi_scan.c >>> >> >> @@ -617,7 +617,7 @@ void __init dmi_scan_machine(void) >>> >> >> memset(buf, 0, 16); >>> >> >> for (q = p; q < p + 0x10000; q += 16) { >>> >> >> memcpy_fromio(buf + 16, q, 16); >>> >> >> - if (!dmi_smbios3_present(buf) || !dmi_present(buf)) { >>> >> >> + if (!dmi_present(buf)) { >>> >> >> dmi_available = 1; >>> >> >> dmi_early_unmap(p, 0x10000); >>> >> >> goto out; >>> >> >> >>> >> >> and try again? >>> >> > >>> >> > kernel boots perfectly with this patch applied. >>> >> > >>> >> > --yliu >>> >> > >>> >> >>> >> Thank you! Very useful to know >>> >> >>> > >>> > Sigh, I made a silly error, I speicified wrong commit while testing your >>> > patch. Sorry for that. >>> > >>> > And I tested it again, with your former patch, sorry, the panic still >>> > happens. >>> > >>> > --yliu >>> > >>> >>> OK, no worries. >>> >>> Could you please try the attached patch? On my ARM system, it produces >>> something like this >>> >>> ====== Decoding _DMI_ header: >>> 5f 44 4d 49 5f 89 62 02 00 c0 8a fe 0c 00 27 cf >>> ====== Remapped SMBIOS table 0xfe8ac000 at ffffff800001e000, size 0x262, num 0xc >>> ====== Processing SMBIOS table entry at ffffff800001e000, type 0x0, length 0x18 >>> ====== Processing SMBIOS table entry at ffffff800001e043, type 0x1, length 0x1b >>> ====== Processing SMBIOS table entry at ffffff800001e09d, type 0x2, length 0x11 >>> ====== Processing SMBIOS table entry at ffffff800001e105, type 0x3, length 0x18 >>> ====== Processing SMBIOS table entry at ffffff800001e155, type 0x4, length 0x2a >>> ====== Processing SMBIOS table entry at ffffff800001e19a, type 0x7, length 0x13 >>> ====== Processing SMBIOS table entry at ffffff800001e1b5, type 0x9, length 0x11 >>> ====== Processing SMBIOS table entry at ffffff800001e1cf, type 0x10, length 0x17 >>> ====== Processing SMBIOS table entry at ffffff800001e1e8, type 0x11, length 0x28 >>> ====== Processing SMBIOS table entry at ffffff800001e22e, type 0x13, length 0x1f >>> ====== Processing SMBIOS table entry at ffffff800001e24f, type 0x20, length 0xb >>> ====== Processing SMBIOS table entry at ffffff800001e25c, type 0x7f, length 0x4 >>> SMBIOS 2.7 present. >>> DMI: ARM Arm Versatile Express/Arm Versatile Express, BIOS 16:20:46 Oct 28 2014 >>> >>> That should help us pinpoint what is going on here. >>> >> >> Here is the output: >> >> [ 0.000000] NX (Execute Disable) protection: active >> [ 0.000000] ====== Decoding _DMI_ header: >> [ 0.000000] 5f 44 4d 49 5f 48 a3 0b 00 20 60 8f 3e 00 25 00 >> [ 0.000000] ====== Remapped SMBIOS table 0xffffffff8f602000 at ffffffffff240000, size 0xba3, num 0x3e > > OK, so that looks like more type promotion silliness. > > Could you apply this, and retry? > (I hit 'send' by accident) --- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ --- a/drivers/firmware/dmi_scan.c +++ b/drivers/firmware/dmi_scan.c @@ -497,7 +497,7 @@ static int __init dmi_present(const u8 *buf) if (memcmp(buf, "_DMI_", 5) == 0 && dmi_checksum(buf, 15)) { dmi_num = get_unaligned_le16(buf + 12); dmi_len = get_unaligned_le16(buf + 6); - dmi_base = get_unaligned_le32(buf + 8); + dmi_base = (u32)get_unaligned_le32(buf + 8); if (dmi_walk_early(dmi_decode) == 0) { if (smbios_ver) {