From patchwork Fri Mar 17 06:54:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 95410 Delivered-To: patch@linaro.org Received: by 10.140.89.134 with SMTP id v6csp173334qgd; Thu, 16 Mar 2017 23:55:38 -0700 (PDT) X-Received: by 10.84.212.8 with SMTP id d8mr17958605pli.152.1489733738697; Thu, 16 Mar 2017 23:55:38 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c11si7692733pgn.188.2017.03.16.23.55.38; Thu, 16 Mar 2017 23:55:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751164AbdCQGzU (ORCPT + 12 others); Fri, 17 Mar 2017 02:55:20 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:35174 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011AbdCQGzS (ORCPT ); Fri, 17 Mar 2017 02:55:18 -0400 Received: by mail-pf0-f180.google.com with SMTP id x63so30158857pfx.2 for ; Thu, 16 Mar 2017 23:54:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=6yiUiSWDBS18bV+Dc82sSB/cMBhZU9F9qpSB0LJWKf4=; b=SLjsl1npsgfNhPSJL9lR2dUFepDHVEG3mK+7QYIDR4NJU3OCRHe37L9ulUHCBx9DMF 2ywG4IO6Uh+obUQzJWQ+zPvrYLxOfOoji14gvcLQ9KrL03SiZ2z6b8dWzY/MHZ6Owwk7 JXy0XZYBGMCkUGELTOpVQ1+vVi6hBfmT3nEsE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6yiUiSWDBS18bV+Dc82sSB/cMBhZU9F9qpSB0LJWKf4=; b=tFF/5WE3mNAa68AvffOH0/h/gcoc1NrmQt6E6lxijk7Mfi8p5vFYQlGBQwYl20In1v 8J3jMmg0dMF8y3WT/1aapoESKAfrusGwX+t6gK6YoPbC/3b/baCClnP5AB5h0SxWk+pW aRcKxJpEmebi78MPH8MAyC2rY0EH4Ta06H1myKc4O+g5O+cBndI74O4svmutlGL5COmT Q7LyZlvlm+mJpnB44111R++9Nmp978Af7lPnDAlxwG0vWjv97z2fKk9jE+7LrOhJqRR8 uya28GidvnpMeMKZGls17zduaQgUgj3SDpjE28+1XXzTo8qRuYVb+hOHiuUHWPkfMv7i 6QyA== X-Gm-Message-State: AFeK/H2hfLF82+MipgDxsNm+C4hd3MTZouhaBC6LAo35TIVZSLvH1Okm2uKLPIpT4deSYpsv X-Received: by 10.99.156.2 with SMTP id f2mr14697852pge.189.1489733672605; Thu, 16 Mar 2017 23:54:32 -0700 (PDT) Received: from localhost ([122.171.239.200]) by smtp.gmail.com with ESMTPSA id s13sm14361278pfk.26.2017.03.16.23.54.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Mar 2017 23:54:32 -0700 (PDT) From: Viresh Kumar To: Greg Kroah-Hartman Cc: linaro-kernel@lists.linaro.org, Vincent Guittot , Viresh Kumar , linux-kernel@vger.kernel.org Subject: [PATCH] driver core: don't initialize 'parent' in device_add() Date: Fri, 17 Mar 2017 12:24:22 +0530 Message-Id: X-Mailer: git-send-email 2.12.0.432.g71c3a4f4ba37 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'parent' is always overwritten before getting used and there is no need to initialize it with NULL. Signed-off-by: Viresh Kumar --- drivers/base/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.12.0.432.g71c3a4f4ba37 diff --git a/drivers/base/core.c b/drivers/base/core.c index 684bda4d14a1..5fc1a50f7577 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -1612,7 +1612,7 @@ int device_private_init(struct device *dev) */ int device_add(struct device *dev) { - struct device *parent = NULL; + struct device *parent; struct kobject *kobj; struct class_interface *class_intf; int error = -EINVAL;