From patchwork Tue Jan 9 10:09:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 123855 Delivered-To: patch@linaro.org Received: by 10.80.140.226 with SMTP id r31csp266735edr; Tue, 9 Jan 2018 02:10:18 -0800 (PST) X-Google-Smtp-Source: ACJfBot4j5cY6EKINrJ6uG+gzqP1J7LXl3+yPjFk/pn6HRxbuaoFPO5OCiWSSYlcOzf54eNId1QB X-Received: by 10.99.150.18 with SMTP id c18mr11653890pge.136.1515492617949; Tue, 09 Jan 2018 02:10:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515492617; cv=none; d=google.com; s=arc-20160816; b=H2uGUFRaw7GT/fVqaMO54Cyo9LjbVmmxucp6UApFuMimORvPurDehCoFOTgT3trSTc UxTVmdytK9LevNIdRy1cPr6u2iEa3JuOhhcjCDS08fAOi3HEvObx0LtDbt1M934/3wC7 P6Vxaq73jYNJYGpm+1yeqGmebQUmnw4GF4zHhaepWNNby3SAGZCFPlQqeuAtLy2aufzA Ih1GgCXvv8Wdf1ZyOwx5MFeLbRk76GJs+Tt3O0bwsan1iqVkDIowrXM4eG3XAydfjSbg DqntuosKD47dN7HZZhWPU2GrUcbUy6FBL7bN2qMtpaTad9Bp/GrtRH+vfEdv4+O6VrU0 LHwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=1VnqwqnSHKnEk2Xjnimny25mmDKJ1Dv++O9t4drEOvs=; b=SuCQzOtiXHJpthMXs2eVb15GnCdmi50oLigP3hFTJcp399vyI+UeT70CvxfTx2i0QX cHMW71lcCtNHSANdvrg6raY95E7HhCIOsjwvKPeVW1iuAR4atvVH7dpj/7L8BkeWLAII x+CDK+LBsHYDFISllPNsYrgfYFwxLhGzhHfUWZzZsuW8tUjI/59n0TDP14ToNLd/ZH3a 0tQIgnEt/KlYXZd6RtWXCLbHtgESzJEPtDr0CjemHLgNREkPS1hcW4Jz2uTsr0l/83jU mVen9m/zE/Lsvo2o9Dm4ZgmO+LL8lfRrgFHPchIqQCPO3u+3pgWtvvFsvbe/vtyjhRAv tWOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n3si8838670pgr.696.2018.01.09.02.10.17; Tue, 09 Jan 2018 02:10:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754041AbeAIKKO (ORCPT + 28 others); Tue, 9 Jan 2018 05:10:14 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:48481 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753511AbeAIKJw (ORCPT ); Tue, 9 Jan 2018 05:09:52 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id C00FC2074A; Tue, 9 Jan 2018 11:09:49 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.free-electrons.com (Postfix) with ESMTPSA id 82B3020377; Tue, 9 Jan 2018 11:09:32 +0100 (CET) From: Maxime Ripard To: Daniel Vetter , David Airlie , Chen-Yu Tsai , Maxime Ripard Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , narmstrong@baylibre.com, thomas@vitsch.nl Subject: [PATCH v3 11/13] drm/sun4i: backend: Use runtime_pm variant of atomic_commit_tail Date: Tue, 9 Jan 2018 11:09:24 +0100 Message-Id: X-Mailer: git-send-email 2.14.3 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org During a hardware commit, the commit bit in the backend will only be cleared if the TCON is enabled. Use the runtime_pm variant of the atomic_commit_tail hook that makes sure that the CRTC, our TCON, is enabled when we perform an atomic_commit. Reviewed-by: Chen-Yu Tsai Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun4i_framebuffer.c | 6 ++++++ 1 file changed, 6 insertions(+) -- git-series 0.9.1 diff --git a/drivers/gpu/drm/sun4i/sun4i_framebuffer.c b/drivers/gpu/drm/sun4i/sun4i_framebuffer.c index 2992f0a6b349..a01a5b7d46e6 100644 --- a/drivers/gpu/drm/sun4i/sun4i_framebuffer.c +++ b/drivers/gpu/drm/sun4i/sun4i_framebuffer.c @@ -10,6 +10,7 @@ * the License, or (at your option) any later version. */ +#include #include #include #include @@ -32,6 +33,10 @@ static const struct drm_mode_config_funcs sun4i_de_mode_config_funcs = { .fb_create = drm_gem_fb_create, }; +static struct drm_mode_config_helper_funcs sun4i_de_mode_config_helpers = { + .atomic_commit_tail = drm_atomic_helper_commit_tail_rpm, +}; + struct drm_fbdev_cma *sun4i_framebuffer_init(struct drm_device *drm) { drm_mode_config_reset(drm); @@ -40,6 +45,7 @@ struct drm_fbdev_cma *sun4i_framebuffer_init(struct drm_device *drm) drm->mode_config.max_height = 8192; drm->mode_config.funcs = &sun4i_de_mode_config_funcs; + drm->mode_config.helper_private = &sun4i_de_mode_config_helpers; return drm_fbdev_cma_init(drm, 32, drm->mode_config.num_connector); }